Bug 864428 - Don't call hideContextUI in startup and tear down test helpers as it can cause random test timeouts. r=bbondy

browser/metro/base/tests/mochitest/browser_selection_basic.js

@@ -25,7 +25,6 @@ function setUpAndTearDown() {
   yield waitForCondition(function () {
       return !SelectionHelperUI.isSelectionUIVisible;
     }, kCommonWaitMs, kCommonPollMs);
-  yield hideContextUI();
 }
 
 gTests.push({
@@ -40,6 +39,8 @@ gTests.push({
         return !StartUI.isStartPageVisible;
       }, 10000, 100);
 
+    yield hideContextUI();
+
     gWindow = Browser.selectedTab.browser.contentWindow;
     InputSourceHelper.isPrecise = false;
   },

browser/metro/base/tests/mochitest/browser_selection_frame_content.js

@@ -25,7 +25,6 @@ function setUpAndTearDown() {
   yield waitForCondition(function () {
       return !SelectionHelperUI.isSelectionUIVisible;
     }, kCommonWaitMs, kCommonPollMs);
-  yield hideContextUI();
 }
 
 gTests.push({
@@ -40,6 +39,8 @@ gTests.push({
       return !StartUI.isStartPageVisible;
       }, 10000, 100);
 
+    yield hideContextUI();
+
     gWindow = Browser.selectedTab.browser.contentWindow;
     gFrame = gWindow.document.getElementById("frame1");
 

browser/metro/base/tests/mochitest/browser_selection_inputs.js

@@ -25,7 +25,6 @@ function setUpAndTearDown() {
   yield waitForCondition(function () {
       return !SelectionHelperUI.isSelectionUIVisible;
     }, kCommonWaitMs, kCommonPollMs);
-  yield hideContextUI();
 }
 
 /*
@@ -46,6 +45,8 @@ gTests.push({
       return !StartUI.isStartPageVisible;
       }, 10000, 100);
 
+    yield hideContextUI();
+
     gWindow = Browser.selectedTab.browser.contentWindow;
     gInput = gWindow.document.getElementById("a");
     InputSourceHelper.isPrecise = false;

browser/metro/base/tests/mochitest/browser_selection_textarea.js

@@ -25,7 +25,6 @@ function setUpAndTearDown() {
   yield waitForCondition(function () {
       return !SelectionHelperUI.isSelectionUIVisible;
     }, kCommonWaitMs, kCommonPollMs);
-  yield hideContextUI();
 }
 
 gTests.push({
@@ -40,6 +39,8 @@ gTests.push({
       return !StartUI.isStartPageVisible;
       }, 10000, 100);
 
+    yield hideContextUI();
+
     gWindow = Browser.selectedTab.browser.contentWindow;
     InputSourceHelper.isPrecise = false;
   },