Bug 1322343 - Enable no-unused-vars in the local scope in toolkit/.eslintrc.js. r=mossop

MozReview-Commit-ID: CiIsUjQzp4D

--HG--
extra : rebase_source : 1b98e88673625a52ef82c1fad5d56aec3e2e8e80
This commit is contained in:
Mark Banner 2016-11-09 22:06:32 +00:00
Родитель 4aef1bde99
Коммит 4f94e4bd68
70 изменённых файлов: 62 добавлений и 192 удалений

Просмотреть файл

@ -6,11 +6,6 @@ module.exports = {
],
"rules": {
"no-unused-vars": ["error", {
"vars": "local",
"varsIgnorePattern": "^Cc|Ci|Cu|Cr|EXPORTED_SYMBOLS",
"args": "none",
}],
"no-shadow": "error"
}
};

Просмотреть файл

@ -1,11 +1,4 @@
"use strict";
module.exports = {
"rules": {
"no-unused-vars": ["error", {
"vars": "local",
"varsIgnorePattern": "^Cc|Ci|Cu|Cr|EXPORTED_SYMBOLS",
"args": "none",
}]
}
};

Просмотреть файл

@ -24,7 +24,7 @@ function test_bug429521() {
// BUG: the print commands after the following statement
// are never executed. Script stops immediately.
var tzId = stmt.row.zone;
stmt.row.zone;
print("*** test_bug429521: step() Read wrapper.row.zone finished");
}

Просмотреть файл

@ -828,7 +828,7 @@ function test_not_right_owning_statement()
);
let array1 = stmt1.newBindingParamsArray();
let array2 = stmt2.newBindingParamsArray();
stmt2.newBindingParamsArray();
let bp = array1.newBindingParams();
bp.bindByName("int", INTEGER);
array1.addParams(bp);

Просмотреть файл

@ -181,7 +181,7 @@ add_task(function* test_createTable() {
});
add_task(function* test_defaultSynchronousAtNormal() {
var msc = getOpenedDatabase();
getOpenedDatabase();
var stmt = createStatement("PRAGMA synchronous;");
try {
stmt.executeStep();

Просмотреть файл

@ -151,11 +151,11 @@ module.exports = {
"no-unreachable": "error",
// No declaring variables that are never used
// "no-unused-vars": ["error", {
// "vars": "local",
// "varsIgnorePattern": "^Cc|Ci|Cu|Cr|EXPORTED_SYMBOLS",
// "args": "none",
// }],
"no-unused-vars": ["error", {
"vars": "local",
"varsIgnorePattern": "^Cc|Ci|Cu|Cr|EXPORTED_SYMBOLS",
"args": "none",
}],
// No using variables before defined
// "no-use-before-define": ["error", "nofunc"],

Просмотреть файл

@ -2,10 +2,5 @@
module.exports = {
"rules": {
"no-unused-vars": ["error", {
"vars": "local",
"varsIgnorePattern": "^Cc|Ci|Cu|Cr|EXPORTED_SYMBOLS",
"args": "none",
}]
}
};

Просмотреть файл

@ -437,7 +437,7 @@ var snapshotFormatters = {
showGpu("gpu-2", "2");
// Remove adapter keys.
for (let [prop, key] of adapterKeys) {
for (let [prop, /* key */] of adapterKeys) {
delete data[prop];
delete data[prop + "2"];
}

Просмотреть файл

@ -414,7 +414,6 @@ var PingPicker = {
let weekSelector = document.getElementById("choose-ping-week");
removeAllChildNodes(weekSelector);
let index = 0;
for (let week of this._weeks) {
let text = shortDateString(week.startDate)
+ " - " + shortDateString(yesterday(week.endDate));
@ -628,7 +627,6 @@ var EnvironmentData = {
},
renderActivePlugins: function(addonObj, addonSection, sectionTitle) {
let data = explodeObject(addonObj);
let table = document.createElement("table");
table.setAttribute("id", sectionTitle);
this.appendAddonSubsectionTitle(sectionTitle, table);

Просмотреть файл

@ -272,7 +272,6 @@ AecLogging.prototype.offState = function() {
AecLogging.prototype.onState = function() {
this._label = getString("aec_logging_on_state_label");
try {
let file = Services.prefs.getCharPref("media.webrtc.debug.aec_log_dir");
this._message = getString("aec_logging_on_state_msg");
} catch (e) {
this._message = null;

Просмотреть файл

@ -438,7 +438,6 @@ var Printing = {
},
receiveMessage(message) {
let objects = message.objects;
let data = message.data;
switch (message.name) {
case "Printing:Preview:Enter": {
@ -664,7 +663,6 @@ var Printing = {
print(contentWindow, simplifiedMode) {
let printSettings = this.getPrintSettings();
let rv = Cr.NS_OK;
// If we happen to be on simplified mode, we need to set docURL in order
// to generate header/footer content correctly, since simplified tab has

Просмотреть файл

@ -3,19 +3,8 @@
add_task(function* () {
// Get a bunch of DOM nodes
let winUtils = window.QueryInterface(Ci.nsIInterfaceRequestor).
getInterface(Ci.nsIDOMWindowUtils);
let editMenu = document.getElementById("edit-menu");
let menubar = editMenu.parentNode;
let menuPopup = editMenu.menupopup;
let editMenuIndex = -1;
for (let i = 0; i < menubar.children.length; i++) {
if (menubar.children[i] === editMenu) {
editMenuIndex = i;
break;
}
}
let closeMenu = function(aCallback) {
if (OS.Constants.Sys.Name == "Darwin") {

Просмотреть файл

@ -2,7 +2,6 @@ var url = "https://example.com/browser/toolkit/content/tests/browser/file_conten
add_task(function*() {
let tab = gBrowser.selectedTab = gBrowser.addTab(url);
let browser = tab.linkedBrowser;
yield new Promise((resolve) => {
addEventListener("TestLocationChange", function listener() {
removeEventListener("TestLocationChange", listener);

Просмотреть файл

@ -100,7 +100,7 @@ add_task(function* test_crash_in_previous_frameloader() {
gBrowser.updateBrowserRemoteness(browser, false);
info("Waiting for content process to go away.");
let [subject, data] = yield contentProcessGone;
let [subject /* , data */] = yield contentProcessGone;
// If we don't clean up the minidump, the harness will
// complain.

Просмотреть файл

@ -12,7 +12,6 @@ add_task(function * ()
var expectedKeyEvents;
var dispatchedKeyEvents;
var key;
var root;
/**
* Encapsulates EventUtils.sendChar().

Просмотреть файл

@ -38,13 +38,13 @@ function runTests()
synthesizeKey("VK_RETURN", {});
target.value = "";
var test1 = new nsDoTestsForAutoCompleteWithComposition(
new nsDoTestsForAutoCompleteWithComposition(
"Testing on HTML input (asynchronously search)",
window, target, formFillController.controller, is,
function() { return target.value; },
function() {
target.setAttribute("timeout", 0);
var test2 = new nsDoTestsForAutoCompleteWithComposition(
new nsDoTestsForAutoCompleteWithComposition(
"Testing on HTML input (synchronously search)",
window, target, formFillController.controller, is,
function() { return target.value; },

Просмотреть файл

@ -319,7 +319,7 @@ function test_nsIDOMXULSelectControlElement_UI(element, testprefix)
var thirditem = element.appendItem("Third Item", "third");
var fourthitem = element.appendItem("Fourth Item", "fourth");
if (behaviourContains(element.localName, "select-extended-keynav")) {
var fifthitem = element.appendItem("Fifth Item", "fifth");
element.appendItem("Fifth Item", "fifth");
var sixthitem = element.appendItem("Sixth Item", "sixth");
synthesizeKeyExpectEvent("VK_END", {}, element, "select", testid + "key end");

Просмотреть файл

@ -175,17 +175,11 @@ function() {
};
}
function clampViewportWH(width, height, visibleRect) {
let minW = visibleRect.width;
let minH = visibleRect.height;
return [Math.max(width, minW), Math.max(height, minH)];
}
function initContainer(container, visibleRect) {
container.style.width = visibleRect.width + 'px';
container.style.height = visibleRect.height + 'px';
container.style.overflow = '-moz-hidden-unscrollable';
}
// function clampViewportWH(width, height, visibleRect) {
// let minW = visibleRect.width;
// let minH = visibleRect.height;
// return [Math.max(width, minW), Math.max(height, minH)];
// }
function resizeContainerToViewport(container, viewportRect) {
container.style.width = viewportRect.width + 'px';
@ -257,7 +251,6 @@ function() {
setViewportDimensions: function setViewportDimensions(width, height, causedByZoom) {
let bvs = this._browserViewportState;
let vis = this._visibleRect;
if (!bvs)
return;
@ -330,9 +323,6 @@ function() {
},
moveVisibleBy: function moveVisibleBy(dx, dy) {
let vr = this._visibleRect;
let vs = this._browserViewportState;
this.onBeforeVisibleMove(dx, dy);
this.onAfterVisibleMove(dx, dy);
},
@ -691,4 +681,3 @@ BrowserView.BrowserViewportState.prototype = {
}
};

Просмотреть файл

@ -109,7 +109,6 @@ BrowserView.prototype = {
scrollboxToViewportRect: function scrollboxToViewportRect(rect, clip) {
let leftbar = this._leftbar.getBoundingClientRect();
let rightbar = this._rightbar.getBoundingClientRect();
let topbar = this._topbar.getBoundingClientRect();
let xtrans = -leftbar.width;

Просмотреть файл

@ -176,7 +176,6 @@ TileManager.prototype = {
// this._tileCache.forEachIntersectingRect(destCriticalRect, false, appendNonDirtyTile, this);
let visited = {};
let evictGuard = null;
if (create) {
evictGuard = function evictGuard(tile) {
return !visited[tile.toString()];
@ -828,8 +827,6 @@ TileManager.Tile.prototype = {
ctx.translate(x, y);
let cw = browserView._contentWindow;
// let cw = browser.contentWindow;
ctx.asyncDrawXULElement(browserView._browser,
rect.left, rect.top,
rect.right - rect.left, rect.bottom - rect.top,

Просмотреть файл

@ -589,8 +589,6 @@ WidgetStack.prototype = {
throw "Invalid number of arguments to setViewportBounds";
}
let vp = this._viewport;
let dleft = this._viewportBounds.left - oldBounds.left;
let dright = this._viewportBounds.right - oldBounds.right;
let dtop = this._viewportBounds.top - oldBounds.top;
@ -627,7 +625,6 @@ WidgetStack.prototype = {
if (barrier.vpRelative) {
if (barrier.type == "vertical") {
let q = "v barrier moving from " + barrier.x + " to ";
if (barrier.vpOffsetXBefore) {
barrier.x += dleft;
} else {
@ -635,7 +632,6 @@ WidgetStack.prototype = {
}
// log2(q += barrier.x);
} else if (barrier.type == "horizontal") {
let q = "h barrier moving from " + barrier.y + " to ";
if (barrier.vpOffsetYBefore) {
barrier.y += dtop;
} else {
@ -1240,8 +1236,6 @@ WidgetStack.prototype = {
_updateWidgets: function() {
let vp = this._viewport;
let ofRect = this._viewingRect.clone();
for (let wid in this._widgetState) {
let state = this._widgetState[wid];
if (vp && state.vpRelative) {
@ -1376,8 +1370,6 @@ WidgetStack.prototype = {
throw "Invalid barrier type: " + t;
}
let x, y;
let barrier = {};
let vp = this._viewport;

Просмотреть файл

@ -6,8 +6,8 @@
<title>Mouse Capture Tests</title>
<link rel="stylesheet" href="chrome://global/skin/" type="text/css"/>
<link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
<script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
<script type="text/javascript" src="/tests/SimpleTest/EventUtils.js"></script>
<script type="text/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
<script type="text/javascript" src="/tests/SimpleTest/EventUtils.js"></script>
</head>
<body id="body" xmlns="http://www.w3.org/1999/xhtml">
<p id="display"/><div id="content" style="display: none"/><pre id="test"/>
@ -172,9 +172,6 @@ function runTests()
var scrollX = parent ? parent.scrollX : 0;
var scrollY = parent ? parent.scrollY : 0;
var b = frames[0].document.getElementById("b");
// runCaptureTest(b, selectionCallback);
// restore scroll
if (parent) parent.scroll(scrollX, scrollY);
@ -336,4 +333,3 @@ SimpleTest.waitForFocus(runTests);
</body>
</html>

Просмотреть файл

@ -625,7 +625,6 @@ function testtag_tree_UI_editing(tree, testid, rowInfo)
// check editing UI
var ecolumn = tree.columns[0];
var rowIndex = 2;
var inputField = tree.inputField;
// temporary make the tree editable to test mouse double click
var wasEditable = tree.editable;
@ -923,7 +922,6 @@ function testtag_tree_TreeView_rows(tree, testid, rowInfo, startRow)
var failedMethods = { };
var checkMethod, actual, expected;
var containerInfo = null;
var toggleOpenStateOK = true;
for (r = startRow; r < length; r++) {

Просмотреть файл

@ -58,7 +58,6 @@ var gTreeUtils = {
if (aDataSet.length == 0)
return ascending;
var numericSort = !isNaN(aDataSet[0][aColumn]);
var sortFunction = null;
if (aComparator) {
sortFunction = function(a, b) { return aComparator(a[aColumn], b[aColumn]); };
@ -75,4 +74,3 @@ var gTreeUtils = {
return ascending;
}
};

Просмотреть файл

@ -944,7 +944,8 @@
Components.utils.reportError(e);
}
try {
var securityUI = this.securityUI;
// Ensures the securityUI is initialized.
var securityUI = this.securityUI; // eslint-disable-line no-unused-vars
}
catch (e) {
}
@ -1569,7 +1570,6 @@
if (!this.droppedLinkHandler || event.defaultPrevented || this.isRemoteBrowser)
return;
let name = { };
let linkHandler = Components.classes["@mozilla.org/content/dropped-link-handler;1"].
getService(Components.interfaces.nsIDroppedLinkHandler);
try {

Просмотреть файл

@ -401,8 +401,6 @@
<method name="adjustArrowPosition">
<body>
<![CDATA[
var arrow = document.getAnonymousElementByAttribute(this, "anonid", "arrow");
var anchor = this.anchorNode;
if (!anchor) {
return;

Просмотреть файл

@ -1068,8 +1068,6 @@
.getService(Components.interfaces.nsIScriptSecurityManager);
if (this.type == "child" && window.opener &&
secMan.isSystemPrincipal(window.opener.document.nodePrincipal)) {
let psvc = Components.classes["@mozilla.org/preferences-service;1"]
.getService(Components.interfaces.nsIPrefBranch);
var pdocEl = window.opener.document.documentElement;
if (pdocEl.instantApply) {
let panes = this.preferencePanes;

Просмотреть файл

@ -18,7 +18,6 @@ function Spinner(props, context) {
}
{
const debug = 0 ? console.log.bind(console, "[spinner]") : function() {};
const ITEM_HEIGHT = 2.5,
VIEWPORT_SIZE = 7,
@ -96,7 +95,6 @@ function Spinner(props, context) {
* }
*/
setState(newState) {
const { spinner } = this.elements;
const { value, items } = this.state;
const { value: newValue, items: newItems, isValueSet, isInvalid } = newState;
@ -129,7 +127,7 @@ function Spinner(props, context) {
_onScroll() {
const { items, itemsView, isInfiniteScroll } = this.state;
const { viewportSize, viewportTopOffset } = this.props;
const { spinner, itemsViewElements } = this.elements;
const { spinner } = this.elements;
this.state.index = this._getIndexByOffset(spinner.scrollTop);

Просмотреть файл

@ -31,7 +31,7 @@
]]>
</getter>
</property>
<property name="handleCtrlPageUpDown">
<setter>
<![CDATA[
@ -74,7 +74,7 @@
]]>
</getter>
</property>
<property name="selectedIndex">
<getter>
<![CDATA[
@ -244,7 +244,7 @@
<children/>
<xul:spacer class="tabs-right" flex="1"/>
</content>
<implementation implements="nsIDOMXULSelectControlElement, nsIDOMXULRelatedElement">
<constructor>
<![CDATA[
@ -299,8 +299,6 @@
// Get linked tab panel by 'linkedpanel' attribute on the given tab
// element.
let linkedPanelElm = null;
let linkedPanelId = aTabElm.linkedPanel;
if (linkedPanelId) {
let ownerDoc = this.ownerDocument;
@ -386,7 +384,7 @@
return -1;
]]>
</getter>
<setter>
<![CDATA[
var tab = this.getItemAtIndex(val);
@ -551,7 +549,7 @@
]]>
</body>
</method>
<method name="insertItemAt">
<parameter name="index"/>
<parameter name="label"/>
@ -889,4 +887,3 @@
</binding>
</bindings>

Просмотреть файл

@ -24,8 +24,6 @@ function TimeKeeper(props) {
}
{
const debug = 0 ? console.log.bind(console, '[timekeeper]') : function() {};
const DAY_PERIOD_IN_HOURS = 12,
SECOND_IN_MS = 1000,
MINUTE_IN_MS = 60000,

Просмотреть файл

@ -10,8 +10,6 @@ function TimePicker(context) {
}
{
const debug = 0 ? console.log.bind(console, "[timepicker]") : function() {};
const DAY_PERIOD_IN_HOURS = 12,
SECOND_IN_MS = 1000,
MINUTE_IN_MS = 60000,
@ -78,7 +76,7 @@ function TimePicker(context) {
* Initalize the spinner components.
*/
_createComponents() {
const { locale, step, format } = this.props;
const { locale, format } = this.props;
const { timeKeeper } = this.state;
const wrapSetValueFn = (setTimeFunction) => {

Просмотреть файл

@ -401,7 +401,7 @@ Submitter.prototype = {
if ("additional_minidumps" in this.extraKeyVals) {
let names = this.extraKeyVals.additional_minidumps.split(',');
for (let name of names) {
let [dump, extra, memory] = getPendingMinidump(this.id + "-" + name);
let [dump /* , extra, memory */] = getPendingMinidump(this.id + "-" + name);
if (!dump.exists()) {
this.notifyStatus(FAILED);
this.cleanup();
@ -454,8 +454,6 @@ this.CrashSubmit = {
{
params = params || {};
let recordSubmission = false;
let submitSuccess = null;
let submitError = null;
let noThrottle = false;
let extraExtraKeyVals = null;
@ -496,7 +494,7 @@ this.CrashSubmit = {
*/
ignore: function CrashSubmit_ignore(id) {
let [dump, extra, mem] = getPendingMinidump(id);
let [dump /* , extra, memory */] = getPendingMinidump(id);
return OS.File.open(dump.path + ".ignore", {create: true},
{unixFlags: OS.Constants.libc.O_CREAT})
.then((file) => { file.close(); });

Просмотреть файл

@ -8,7 +8,7 @@ function run_test()
do_check_true(cr.enabled);
try {
let su = cr.serverURL;
cr.serverURL;
do_throw("Getting serverURL when not set should have thrown!");
}
catch (ex) {

Просмотреть файл

@ -16,7 +16,7 @@ function run_test()
let dir = Components.classes["@mozilla.org/file/local;1"]
.createInstance(Components.interfaces.nsILocalFile);
dir.initWithPath(profd);
let lock = CrashTestUtils.lockDir(dir);
CrashTestUtils.lockDir(dir);
// when we crash, the lock file should be cleaned up
},
function(mdump, extra) {

Просмотреть файл

@ -93,7 +93,6 @@ this.ForgetAboutSite = {
let promises = [];
for (let i = 0; i < tags.length; i++) {
let promise = new Promise(resolve => {
let tag = tags[i];
try {
ph.clearSiteData(tags[i], aDomain, FLAG_CLEAR_ALL, -1, function(rv) {
resolve();

Просмотреть файл

@ -489,7 +489,7 @@ function* test_push_cleared()
do_get_profile();
setPrefs();
const {PushDB, PushService, PushServiceWebSocket} = serviceExports;
const {PushService, PushServiceWebSocket} = serviceExports;
const userAgentID = 'bd744428-f125-436a-b6d0-dd0c9845837f';
const channelID = '0ef2ad4a-6c49-41ad-af6e-95d2425276bf';

Просмотреть файл

@ -178,7 +178,6 @@ IdentityProviderService.prototype = {
provFlow.caller = aCaller;
let identity = provFlow.identity;
let frame = provFlow.provisioningFrame;
// Determine recommended length of cert.
let duration = this.certDuration;

Просмотреть файл

@ -87,8 +87,6 @@ IdentityLogger.prototype = {
* our log function
*/
reportError: function reportError(aPrefix, ...aArgs) {
let prefix = aPrefix + ' ERROR';
// Report the error in the browser
let output = this._generateLogMessage(aPrefix, aArgs);
Cu.reportError(output);

Просмотреть файл

@ -180,8 +180,6 @@ function test_logout() {
function test_error() {
do_test_pending();
let received = [];
// Mock the fxAccountsManager so that getAssertion rejects its promise and
// triggers our onerror handler. (This is the method that's used internally
// by FirefoxAccounts.RP.request().)

Просмотреть файл

@ -215,7 +215,7 @@ function test_audience_encoding_bug972582() {
function(err2, backedAssertion) {
do_check_null(err2);
let [cert, assertion] = backedAssertion.split("~");
let [/* cert */, assertion] = backedAssertion.split("~");
let components = extractComponents(assertion);
do_check_eq(components.payload.aud, audience);

Просмотреть файл

@ -28,7 +28,7 @@ function toggle_debug() {
}
};
var wrapper = new Wrapper();
new Wrapper();
Services.prefs.setBoolPref('toolkit.identity.debug', true);
}

Просмотреть файл

@ -110,7 +110,6 @@ this.DateTimePickerHelper = {
// Get picker from browser and show it anchored to the input box.
showPicker: function(aBrowser, aData) {
let rect = aData.rect;
let dir = aData.dir;
let type = aData.type;
let detail = aData.detail;

Просмотреть файл

@ -417,7 +417,6 @@ Finder.prototype = {
return;
}
let window = this._getWindow();
this._currentFoundRange = this._fastFind.getFoundRange();
let params = {

Просмотреть файл

@ -1495,8 +1495,6 @@ FinderHighlighter.prototype = {
let controller = editor.selectionController;
let fSelection = controller.getSelection(Ci.nsISelectionController.SELECTION_FIND);
let selectionIndex = 0;
let findSelectionIndex = 0;
let shouldDelete = {};
let numberOfDeletedSelections = 0;
let numberOfMatches = fSelection.rangeCount;

Просмотреть файл

@ -453,7 +453,7 @@ this.FinderIterator = {
this._notifyListeners("start", this.params);
let { linksOnly, window, word } = this._currentParams;
let { linksOnly, window } = this._currentParams;
// First we collect all frames we need to search through, whilst making sure
// that the parent window gets dibs.
let frames = [window].concat(this._collectFrames(window, finder));

Просмотреть файл

@ -219,7 +219,6 @@ InlineSpellChecker.prototype = {
var o1 = {}, o2 = {};
spellchecker.GetDictionaryList(o1, o2);
list = o1.value;
var listcount = o2.value;
try {
curlang = spellchecker.GetCurrentDictionary();
} catch (e) {}
@ -263,7 +262,7 @@ InlineSpellChecker.prototype = {
try {
// Get the display name for this dictionary.
let languageTagMatch = /^([a-z]{2,3}|[a-z]{4}|[a-z]{5,8})(?:[-_]([a-z]{4}))?(?:[-_]([A-Z]{2}|[0-9]{3}))?((?:[-_](?:[a-z0-9]{5,8}|[0-9][a-z0-9]{3}))*)(?:[-_][a-wy-z0-9](?:[-_][a-z0-9]{2,8})+)*(?:[-_]x(?:[-_][a-z0-9]{1,8})+)?$/i;
var [languageTag, languageSubtag, scriptSubtag, regionSubtag, variantSubtags] = dictionaryName.match(languageTagMatch);
var [/* languageTag */, languageSubtag, scriptSubtag, regionSubtag, variantSubtags] = dictionaryName.match(languageTagMatch);
} catch (e) {
// If we weren't given a valid language tag, just use the raw dictionary name.
return dictionaryName;

Просмотреть файл

@ -909,7 +909,7 @@ var Links = {
}
let numProvidersRemaining = this._providers.size;
for (let [provider, links] of this._providers) {
for (let [provider /* , links */] of this._providers) {
this._populateProviderCache(provider, () => {
if (--numProvidersRemaining == 0)
executeCallbacks();
@ -1022,7 +1022,7 @@ var Links = {
* @param increment A boolean for whether to increment or decrement siteMap
*/
_adjustSiteMapAndNotify: function(aLink, increment = true) {
for (let [provider, cache] of this._providers) {
for (let [/* provider */, cache] of this._providers) {
// We only update siteMap if aLink is already stored in linkMap.
if (cache.linkMap.get(aLink.url)) {
if (increment) {

Просмотреть файл

@ -21,7 +21,6 @@ PageMenu.prototype = {
// Given a target node, get the context menu for it or its ancestor.
getContextMenu: function(aTarget) {
let pageMenu = null;
let target = aTarget;
while (target) {
let contextMenu = target.contextMenu;

Просмотреть файл

@ -514,7 +514,7 @@ var observer = (window) => {
.QueryInterface(Ci.nsIInterfaceRequestor)
.getInterface(Ci.nsIContentFrameMessageManager);
// Set up the child side of the message port
let port = new ChildMessagePort(messageManager, window);
new ChildMessagePort(messageManager, window);
};
Services.obs.addObserver(observer, "chrome-document-global-created", false);
Services.obs.addObserver(observer, "content-document-global-created", false);

Просмотреть файл

@ -207,8 +207,6 @@ function getComputedStyles(element) {
function buildOptionListForChildren(node) {
let result = [];
let win = node.ownerDocument.defaultView;
for (let child of node.children) {
let tagName = child.tagName.toUpperCase();

Просмотреть файл

@ -144,8 +144,6 @@ this.SelectParentHelper = {
case "command":
if (event.target.hasAttribute("value")) {
let win = currentBrowser.ownerDocument.defaultView;
currentBrowser.messageManager.sendAsyncMessage("Forms:SelectDropDownItem", {
value: event.target.value,
closedWithEnter: closedWithEnter

Просмотреть файл

@ -249,7 +249,6 @@ function _getRootBounds(windowUtils) {
function _getBestToFocus(nodes, key, currentlyFocused) {
let best = null;
let bestDist;
let bestMid;
let nodeMid;
let currentlyFocusedMid = _getMidpoint(currentlyFocused);
let currentlyFocusedRect = currentlyFocused.getBoundingClientRect();

Просмотреть файл

@ -427,7 +427,7 @@ ConnectionData.prototype = Object.freeze({
_finalize: function() {
this._log.debug("Finalizing connection.");
// Cancel any pending statements.
for (let [k, statement] of this._pendingStatements) {
for (let [/* k */, statement] of this._pendingStatements) {
statement.cancel();
}
this._pendingStatements.clear();
@ -436,12 +436,12 @@ ConnectionData.prototype = Object.freeze({
this._statementCounter = 0;
// Next we finalize all active statements.
for (let [k, statement] of this._anonymousStatements) {
for (let [/* k */, statement] of this._anonymousStatements) {
statement.finalize();
}
this._anonymousStatements.clear();
for (let [k, statement] of this._cachedStatements) {
for (let [/* k */, statement] of this._cachedStatements) {
statement.finalize();
}
this._cachedStatements.clear();
@ -661,7 +661,7 @@ ConnectionData.prototype = Object.freeze({
discardCachedStatements: function() {
let count = 0;
for (let [k, statement] of this._cachedStatements) {
for (let [/* k */, statement] of this._cachedStatements) {
++count;
statement.finalize();
}
@ -1170,7 +1170,6 @@ OpenedConnection.prototype = Object.freeze({
* @return Promise<int>
*/
getSchemaVersion: function() {
let self = this;
return this.execute("PRAGMA user_version").then(
function onSuccess(result) {
if (result == null) {

Просмотреть файл

@ -423,7 +423,6 @@ TaskImpl.prototype = {
// Rewrite the stack for more readability.
let bottomStack = this._stack;
let topStack = stack;
stack = Task.Debugging.generateReadableStack(stack);

Просмотреть файл

@ -324,23 +324,6 @@ XPCOMUtils.defineLazyGetter(UpdateUtils, "OSVersion", function() {
{wReserved: BYTE}
]);
// This structure is described at:
// http://msdn.microsoft.com/en-us/library/ms724958%28v=vs.85%29.aspx
const SYSTEM_INFO = new ctypes.StructType('SYSTEM_INFO',
[
{wProcessorArchitecture: WORD},
{wReserved: WORD},
{dwPageSize: DWORD},
{lpMinimumApplicationAddress: ctypes.voidptr_t},
{lpMaximumApplicationAddress: ctypes.voidptr_t},
{dwActiveProcessorMask: DWORD.ptr},
{dwNumberOfProcessors: DWORD},
{dwProcessorType: DWORD},
{dwAllocationGranularity: DWORD},
{wProcessorLevel: WORD},
{wProcessorRevision: WORD}
]);
let kernel32 = false;
try {
kernel32 = ctypes.open("Kernel32");

Просмотреть файл

@ -169,7 +169,7 @@ var SimpleServiceDiscovery = {
// to allow for packet loss on noisy networks.
let timeout = SSDP_DISCOVER_DELAY;
for (let attempts = 0; attempts < SSDP_DISCOVER_ATTEMPTS; attempts++) {
for (let [key, device] of this._devices) {
for (let [/* key */, device] of this._devices) {
let target = device.target;
setTimeout(function() {
let msgData = data.replace("%SEARCH_TARGET%", target);
@ -224,7 +224,7 @@ var SimpleServiceDiscovery = {
this._searchSocket.close();
// Clean out any stale services
for (let [key, service] of this._services) {
for (let [/* key */, service] of this._services) {
if (service.lastPing != this._searchTimestamp) {
this.removeService(service.uuid);
}
@ -305,7 +305,7 @@ var SimpleServiceDiscovery = {
// Returns an array copy of the active services
get services() {
let array = [];
for (let [key, service] of this._services) {
for (let [/* key */, service] of this._services) {
let target = this._devices.get(service.deviceID);
service.extensions = target.extensions;
service.types = target.types;
@ -317,7 +317,7 @@ var SimpleServiceDiscovery = {
// Returns false if the service does not match the device's filters
_filterService: function _filterService(aService) {
// Loop over all the devices, looking for one that matches the service
for (let [key, device] of this._devices) {
for (let [/* key */, device] of this._devices) {
// First level of match is on the target itself
if (device.target != aService.target) {
continue;

Просмотреть файл

@ -100,7 +100,7 @@ add_task(function* init_navigate() {
port = yield waitForPort(TEST_URL, false);
port.sendAsyncMessage("Ping2");
let message = yield waitForMessage(port, "Pong2");
yield waitForMessage(port, "Pong2");
port.destroy();
gBrowser.removeCurrentTab();

Просмотреть файл

@ -69,7 +69,6 @@ add_task(function* test_canonicalJSON_preserves_data() {
{'foo': 'bar', 'last_modified': '12345', 'id': '1'},
{'bar': 'baz', 'last_modified': '45678', 'id': '2'},
]
const serialized = CanonicalJSON.stringify(records);
const expected = '[{"foo":"bar","id":"1","last_modified":"12345"},' +
'{"bar":"baz","id":"2","last_modified":"45678"}]';
do_check_eq(CanonicalJSON.stringify(records), expected);

Просмотреть файл

@ -33,7 +33,7 @@ add_test(function test_getFile() {
add_test(function test_getFile_nonexistentDir() {
do_check_throws(function() {
let file = FileUtils.getFile("NonexistentD", ["foobar"]);
FileUtils.getFile("NonexistentD", ["foobar"]);
}, Components.results.NS_ERROR_FAILURE);
run_next_test();
@ -69,7 +69,7 @@ add_test(function test_getDir() {
add_test(function test_getDir_nonexistentDir() {
do_check_throws(function() {
let file = FileUtils.getDir("NonexistentD", ["foodir"]);
FileUtils.getDir("NonexistentD", ["foodir"]);
}, Components.results.NS_ERROR_FAILURE);
run_next_test();

Просмотреть файл

@ -549,13 +549,9 @@ add_task(function* test_simpleCheckAndInstall_tooFrequent() {
* Tests that installing addons when there is no server works as expected
*/
add_test(function test_installAddon_noServer() {
let dir = FileUtils.getDir("TmpD", [], true);
let zipFileName = "test_GMP.zip";
let zipURL = URL_HOST + ":0/" + zipFileName;
let data = "e~=0.5772156649";
let zipFile = createNewZipFile(zipFileName, data);
let responseXML =
"<?xml version=\"1.0\"?>" +
"<updates>" +

Просмотреть файл

@ -57,7 +57,7 @@ add_task(function test_Logger_parent() {
let childLog = Log.repository.getLogger("grandparent.parent.child");
do_check_eq(childLog.parent.name, "grandparent");
let parentLog = Log.repository.getLogger("grandparent.parent");
Log.repository.getLogger("grandparent.parent");
do_check_eq(childLog.parent.name, "grandparent.parent");
// Check that appends are exactly in scope

Просмотреть файл

@ -287,7 +287,7 @@ tests.push(
throw exception_content;
});
let observer_2 = source.promise.then(
source.promise.then(
function onResolve() {
do_check_true(exception_thrown, "Second observer called after first observer has thrown");
}
@ -960,7 +960,6 @@ function wait_for_uncaught(aMustAppear, aTimeout = undefined) {
}
let deferred = Promise.defer();
let print = do_print;
let execute_soon = do_execute_soon;
let observer = function({message, stack}) {
let data = message + stack;
print("Observing " + message + ", looking for " + aMustAppear.join(", "));

Просмотреть файл

@ -31,7 +31,7 @@ function monkeypatchStartupInfo(recorder, start = new Date(), offset = 500) {
function sleep(wait) {
let deferred = Promise.defer();
let timer = CommonUtils.namedTimer(function onTimer() {
CommonUtils.namedTimer(function onTimer() {
deferred.resolve();
}, wait, deferred.promise, "_sleepTimer");
@ -303,4 +303,3 @@ add_task(function* test_record_activity() {
recorder.onShutdown();
});

Просмотреть файл

@ -494,7 +494,6 @@ add_task(function* test_no_shrink_on_init() {
let c = yield getConnection("no_shrink_on_init",
{shrinkMemoryOnConnectionIdleMS: 200});
let oldShrink = c._connectionData.shrinkMemory;
let count = 0;
Object.defineProperty(c._connectionData, "shrinkMemory", {
value: function() {
@ -759,11 +758,11 @@ add_task(function* test_programmatic_binding_transaction_partial_rollback() {
try {
yield c.executeTransaction(function* transaction() {
// Insert one row. This won't implicitly start a transaction.
let result = yield c.execute(sql, bindings[0]);
yield c.execute(sql, bindings[0]);
// Insert multiple rows. mozStorage will want to start a transaction.
// One of the inserts will fail, so the transaction should be rolled back.
result = yield c.execute(sql, bindings);
yield c.execute(sql, bindings);
secondSucceeded = true;
});
} catch (ex) {
@ -795,7 +794,7 @@ add_task(function* test_programmatic_binding_implicit_transaction() {
let secondSucceeded = false;
yield c.execute(sql, {id: 1, path: "works"});
try {
let result = yield c.execute(sql, bindings);
yield c.execute(sql, bindings);
secondSucceeded = true;
} catch (ex) {
print("Caught expected exception: " + ex);
@ -918,7 +917,7 @@ add_task(function* test_cloneStorageConnection() {
// Test Sqlite.cloneStorageConnection invalid argument.
add_task(function* test_cloneStorageConnection() {
try {
let clone = yield Sqlite.cloneStorageConnection({ connection: null });
yield Sqlite.cloneStorageConnection({ connection: null });
do_throw(new Error("Should throw on invalid connection"));
} catch (ex) {
if (ex.name != "TypeError") {

Просмотреть файл

@ -44,7 +44,7 @@ add_task(function* test_setInterval() {
let calls = 0;
yield new Promise((resolve) => {
let interval2 = imported.setInterval((param1, param2) => {
imported.setInterval((param1, param2) => {
do_check_true(true, "Should be called");
do_check_eq(param1, 15, "first parameter is correct");
do_check_eq(param2, "hola", "second parameter is correct");

Просмотреть файл

@ -152,4 +152,3 @@ add_test(function test_addon_manager_get_by_sync_guid() {
});
});
});

Просмотреть файл

@ -164,4 +164,3 @@ add_task(function*() {
yield promiseRestartManager();
});

Просмотреть файл

@ -440,7 +440,7 @@ function getCanApplyUpdates() {
try {
// KEY_UPDROOT will fail and throw an exception if
// appDir is not under the Program Files, so we rely on that
let dir = Services.dirsvc.get(KEY_UPDROOT, Ci.nsIFile);
Services.dirsvc.get(KEY_UPDROOT, Ci.nsIFile);
// appDir is under Program Files, so check if the user can elevate
userCanElevate = Services.appinfo.QueryInterface(Ci.nsIWinAppHelper).
userCanElevate;

Просмотреть файл

@ -1326,7 +1326,7 @@ function getSpecialFolderDir(aCSIDL) {
ctypes.bool /* BOOL fCreate */);
let aryPath = ctypes.char16_t.array()(260);
let rv = SHGetSpecialFolderPath(0, aryPath, aCSIDL, false);
SHGetSpecialFolderPath(0, aryPath, aCSIDL, false);
lib.close();
let path = aryPath.readString(); // Convert the c-string to js-string
@ -4075,8 +4075,6 @@ function runUpdateUsingApp(aExpectedStatus) {
debugDump("start - launching application to apply update");
let appBin = getApplyDirFile(DIR_MACOS + FILE_APP_BIN, false);
let launchBin = getLaunchBin();
let args = getProcessArgs();
debugDump("launching " + launchBin.path + " " + args.join(" "));

Просмотреть файл

@ -227,7 +227,6 @@ function RenameProfile()
function ConfirmDelete()
{
var deleteButton = document.getElementById("delbutton");
var profileList = document.getElementById( "profiles" );
var selectedItem = profileList.selectedItem;