Bug 1373326 - Reformat repackage mozharness code to support new mach repackage stuff. r=aki

(For Landing more OSX Nightly Support from date to central)

MozReview-Commit-ID: FSbQZ1Fbdcs

--HG--
extra : rebase_source : 3651dd368f032ae9f17cba42010902f850a64700

testing/mozharness/configs/repackage/osx_signed.py

@@ -1,15 +1,22 @@
 import os
 
 config = {
-    "input_filename": "target.tar.gz",
-    "output_filename": "target.dmg",
-    "input_home": "/home/worker/workspace/inputs",
+    "input_home": "{abs_work_dir}/inputs",
     "src_mozconfig": "browser/config/mozconfigs/macosx64/repack",
 
+    "download_config": {
+        "target.tar.gz": os.environ.get("SIGNED_INPUT"),
+    },
+
+    "repackage_config": [[
+        "dmg",
+        "-i", "{abs_work_dir}/inputs/target.tar.gz",
+        "-o", "{output_home}/target.dmg"
+    ]],
+
     # ToolTool
     "tooltool_manifest_src": 'browser/config/tooltool-manifests/macosx64/cross-releng.manifest',
     "tooltool_url": 'http://relengapi/tooltool/',
-    "tooltool_bootstrap": "setup.sh",
     'tooltool_script': ["/builds/tooltool.py"],
     'tooltool_cache': os.environ.get('TOOLTOOL_CACHE'),
 }

testing/mozharness/scripts/repackage.py

@@ -10,21 +10,6 @@ from mozharness.mozilla.mock import ERROR_MSGS
 
 class Repackage(BaseScript):
 
-    config_options = [[
-        ['--signed-input', ],
-        {"action": "store",
-         "dest": "signed_input",
-         "type": "string",
-         "default": os.environ.get('SIGNED_INPUT'),
-         "help": "Specify the signed input (url)"}
-    ], [
-        ['--output-file', ],
-        {"action": "store",
-         "dest": "output_file",
-         "type": "string",
-         "help": "Specify the output filename"}
-    ]]
-
     def __init__(self, require_config_file=False):
         script_kwargs = {
             'all_actions': [
@@ -35,24 +20,22 @@ class Repackage(BaseScript):
         }
         BaseScript.__init__(
             self,
-            config_options=self.config_options,
             require_config_file=require_config_file,
             **script_kwargs
         )
 
-        # Assert we have it either passed in or in environment
-        assert self.config.get('signed_input'), \
-            "Must pass --signed-input or be set in the environment as SIGNED_INPUT"
-
     def download_input(self):
         config = self.config
+        dirs = self.query_abs_dirs()
 
-        url = config['signed_input']
+        input_home = config['input_home'].format(**dirs)
+
+        for path, url in config["download_config"].items():
             status = self.download_file(url=url,
-                                    file_name=config['input_filename'],
-                                    parent_dir=config['input_home'])
+                                        file_name=path,
+                                        parent_dir=input_home)
             if not status:
-            self.fatal("Unable to fetch signed input from %s" % config['signed_input'])
+                self.fatal("Unable to fetch signed input from %s" % url)
 
     def setup(self):
         self._run_tooltool()
@@ -69,6 +52,7 @@ class Repackage(BaseScript):
         dirs = {}
         dirs['abs_tools_dir'] = os.path.join(abs_dirs['abs_work_dir'], 'tools')
         dirs['abs_mozilla_dir'] = os.path.join(abs_dirs['abs_work_dir'], 'src')
+        dirs['output_home'] = os.path.join(abs_dirs['abs_work_dir'], 'artifacts')
         for key in dirs.keys():
             if key not in abs_dirs:
                 abs_dirs[key] = dirs[key]
@@ -78,13 +62,15 @@ class Repackage(BaseScript):
     def repackage(self):
         config = self.config
         dirs = self.query_abs_dirs()
-        infile = os.path.join(config['input_home'], config['input_filename'])
-        outfile = os.path.join(dirs['abs_upload_dir'], config['output_filename'])
-        command = [sys.executable, 'mach', '--log-no-times', 'repackage',
-                   'dmg',
-                   '--input', infile,
-                   '--output', outfile]
-        return self.run_command(
+
+        # Make sure the upload dir is around.
+        self.mkdir_p(dirs['output_home'])
+
+        for repack_config in config["repackage_config"]:
+            command = [sys.executable, 'mach', '--log-no-times', 'repackage'] + \
+                [arg.format(**dirs)
+                    for arg in list(repack_config)]
+            self.run_command(
                 command=command,
                 cwd=dirs['abs_mozilla_dir'],
                 halt_on_failure=True,
@@ -98,24 +84,46 @@ class Repackage(BaseScript):
             manifest_src = config.get('tooltool_manifest_src')
         if not manifest_src:
             return self.warning(ERROR_MSGS['tooltool_manifest_undetermined'])
-        fetch_script_path = os.path.join(dirs['abs_tools_dir'],
-                                         'scripts/tooltool/tooltool_wrapper.sh')
         tooltool_manifest_path = os.path.join(dirs['abs_mozilla_dir'],
                                               manifest_src)
         cmd = [
-            'sh',
-            fetch_script_path,
+            sys.executable, '-u',
+            os.path.join(dirs['abs_mozilla_dir'], 'mach'),
+            'artifact',
+            'toolchain',
+            '-v',
+            '--retry', '4',
+            '--tooltool-manifest',
             tooltool_manifest_path,
+            '--tooltool-url',
             config['tooltool_url'],
-            config['tooltool_bootstrap'],
         ]
-        cmd.extend(config['tooltool_script'])
+        auth_file = self._get_tooltool_auth_file()
+        if auth_file:
+            cmd.extend(['--authentication-file', auth_file])
         cache = config.get('tooltool_cache')
         if cache:
-            cmd.extend(['-c', cache])
+            cmd.extend(['--cache-dir', cache])
         self.info(str(cmd))
         self.run_command(cmd, cwd=dirs['abs_mozilla_dir'], halt_on_failure=True)
 
+    def _get_tooltool_auth_file(self):
+        # set the default authentication file based on platform; this
+        # corresponds to where puppet puts the token
+        if 'tooltool_authentication_file' in self.config:
+            fn = self.config['tooltool_authentication_file']
+        elif self._is_windows():
+            fn = r'c:\builds\relengapi.tok'
+        else:
+            fn = '/builds/relengapi.tok'
+
+        # if the file doesn't exist, don't pass it to tooltool (it will just
+        # fail).  In taskcluster, this will work OK as the relengapi-proxy will
+        # take care of auth.  Everywhere else, we'll get auth failures if
+        # necessary.
+        if os.path.exists(fn):
+            return fn
+
     def _get_mozconfig(self):
         """assign mozconfig."""
         c = self.config