From 505671ed77de2059c1defd37c0079a6a5b584dc6 Mon Sep 17 00:00:00 2001 From: "nelson%bolyard.com" Date: Thu, 18 May 2006 23:29:19 +0000 Subject: [PATCH] Eliminate a crash and plug a leak in the error path for function nssSMIMEProfile_Create. Coverity bug 337101. r=alexei.volkov. --- security/nss/lib/pki/certificate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/security/nss/lib/pki/certificate.c b/security/nss/lib/pki/certificate.c index 01b4b77b8d20..db6c62257988 100644 --- a/security/nss/lib/pki/certificate.c +++ b/security/nss/lib/pki/certificate.c @@ -35,7 +35,7 @@ * ***** END LICENSE BLOCK ***** */ #ifdef DEBUG -static const char CVS_ID[] = "@(#) $RCSfile: certificate.c,v $ $Revision: 1.57 $ $Date: 2006/04/07 05:49:04 $"; +static const char CVS_ID[] = "@(#) $RCSfile: certificate.c,v $ $Revision: 1.58 $ $Date: 2006/05/18 23:29:19 $"; #endif /* DEBUG */ #ifndef NSSPKI_H @@ -930,7 +930,8 @@ nssSMIMEProfile_Create ( } return rvProfile; loser: - nssPKIObject_Destroy(object); + if (object) nssPKIObject_Destroy(object); + else if (arena) nssArena_Destroy(arena); return (nssSMIMEProfile *)NULL; }