Bug 1436263 - Part 4: Remove unnecessary `virtual` and `final` from non-overriding final virtual function declarations. r=froydnj

AccessibleNode::GetParentObject is a non-overriding final virtual function. GetParentObject is a common virtual function in many DOM classes, but AccessibleNode does not derive from any base classes that define virtual GetParentObject or have any derived classes of its own.

WebCryptoTask::CalculateResult and CallCallback are non-overriding final virtual functions that mirror virtual function names in the CryptoTask class, even though WebCryptoTask does not actually derive from CryptoTask.

nsWindowBase::GetWindowHandle is a non-overriding final virtual function. The only other function called GetWindowHandle is MouseScrollHandler::EventInfo::GetWindowHandle, which is not related to the nsWindowBase class.

MozReview-Commit-ID: 4ldSAyP3ZpP

--HG--
extra : rebase_source : cd6fea309c042183db59653ed39e1e63b70c6a63

accessible/aom/AccessibleNode.h

@@ -34,7 +34,7 @@ public:
   NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS(AccessibleNode);
 
   JSObject* WrapObject(JSContext* aCx, JS::Handle<JSObject*> aGivenProto) final;
-  virtual dom::ParentObject GetParentObject() const final;
+  dom::ParentObject GetParentObject() const;
 
   void GetRole(nsAString& aRole);
   void GetStates(nsTArray<nsString>& aStates);

dom/crypto/WebCryptoTask.h

@@ -179,9 +179,9 @@ protected:
 
   void FailWithError(nsresult aRv);
 
-  virtual nsresult CalculateResult() final;
+  nsresult CalculateResult();
 
-  virtual void CallCallback(nsresult rv) final;
+  void CallCallback(nsresult rv);
 
 private:
   NS_IMETHOD Run() final;

widget/windows/nsWindowBase.h

@@ -25,7 +25,7 @@ public:
   /*
    * Return the HWND or null for this widget.
    */
-  virtual HWND GetWindowHandle() final {
+  HWND GetWindowHandle() {
     return static_cast<HWND>(GetNativeData(NS_NATIVE_WINDOW));
   }