From 5109c421bca53515c980db68043a8fc7b134b5f8 Mon Sep 17 00:00:00 2001
From: Srestha <sresthasrivastava.ss@gmail.com>
Date: Thu, 31 Jan 2019 13:52:10 +0000
Subject: [PATCH] Bug 1523679 - Remove `autocomplete=off` from `<button>`
 elements in aboutNetError.xhtml and aboutNetError-new.xhtml. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D18212

--HG--
extra : moz-landing-system : lando
---
 browser/base/content/aboutNetError-new.xhtml | 18 +++++++++---------
 browser/base/content/aboutNetError.xhtml     | 14 +++++++-------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/browser/base/content/aboutNetError-new.xhtml b/browser/base/content/aboutNetError-new.xhtml
index b152039e661e..665922862733 100644
--- a/browser/base/content/aboutNetError-new.xhtml
+++ b/browser/base/content/aboutNetError-new.xhtml
@@ -190,20 +190,20 @@
              init for other error types .-->
         <div id="prefChangeContainer" class="button-container">
           <p>&prefReset.longDesc;</p>
-          <button id="prefResetButton" class="primary" autocomplete="off">&prefReset.label;</button>
+          <button id="prefResetButton" class="primary">&prefReset.label;</button>
         </div>
 
         <div id="certErrorAndCaptivePortalButtonContainer" class="button-container">
-          <button id="returnButton" class="primary" autocomplete="off" data-telemetry-id="return_button_top">&returnToPreviousPage1.label;</button>
-          <button id="openPortalLoginPageButton" class="primary" autocomplete="off">&openPortalLoginPage.label2;</button>
-          <button id="errorTryAgain" class="primary" autocomplete="off">&retry.label;</button>
-          <button id="advancedButton" data-telemetry-id="advanced_button" autocomplete="off">&advanced2.label;</button>
-          <button id="moreInformationButton" autocomplete="off">&moreInformation.label;</button>
+          <button id="returnButton" class="primary" data-telemetry-id="return_button_top">&returnToPreviousPage1.label;</button>
+          <button id="openPortalLoginPageButton" class="primary">&openPortalLoginPage.label2;</button>
+          <button id="errorTryAgain" class="primary">&retry.label;</button>
+          <button id="advancedButton" data-telemetry-id="advanced_button">&advanced2.label;</button>
+          <button id="moreInformationButton">&moreInformation.label;</button>
         </div>
       </div>
 
       <div id="netErrorButtonContainer" class="button-container">
-        <button id="errorTryAgain" class="primary" autocomplete="off">&retry.label;</button>
+        <button id="errorTryAgain" class="primary">&retry.label;</button>
       </div>
 
       <div id="advancedPanelContainer">
@@ -211,8 +211,8 @@
           <p id="badCertTechnicalInfo"/>
           <a id="viewCertificate" href="javascript:void(0)">&viewCertificate.label;</a>
           <div id="advancedPanelButtonContainer" class="button-container">
-            <button id="advancedPanelReturnButton" class="primary" autocomplete="off" data-telemetry-id="return_button_adv">&returnToPreviousPage1.label;</button>
-            <button id="advancedPanelErrorTryAgain" class="primary" autocomplete="off">&retry.label;</button>
+            <button id="advancedPanelReturnButton" class="primary" data-telemetry-id="return_button_adv">&returnToPreviousPage1.label;</button>
+            <button id="advancedPanelErrorTryAgain" class="primary">&retry.label;</button>
             <div class="exceptionDialogButtonContainer">
               <button id="exceptionDialogButton" data-telemetry-id="exception_button">&securityOverride.exceptionButton1Label;</button>
             </div>
diff --git a/browser/base/content/aboutNetError.xhtml b/browser/base/content/aboutNetError.xhtml
index fb8b8bfa9538..dbbfbf3aa0e9 100644
--- a/browser/base/content/aboutNetError.xhtml
+++ b/browser/base/content/aboutNetError.xhtml
@@ -150,26 +150,26 @@
 
         <div id="prefChangeContainer" class="button-container">
           <p>&prefReset.longDesc;</p>
-          <button id="prefResetButton" class="primary" autocomplete="off">&prefReset.label;</button>
+          <button id="prefResetButton" class="primary">&prefReset.label;</button>
         </div>
 
         <div id="certErrorAndCaptivePortalButtonContainer" class="button-container">
-          <button id="returnButton" class="primary" autocomplete="off" data-telemetry-id="return_button_top">&returnToPreviousPage.label;</button>
-          <button id="openPortalLoginPageButton" class="primary" autocomplete="off">&openPortalLoginPage.label2;</button>
-          <button id="advancedButton" data-telemetry-id="advanced_button" autocomplete="off">&advanced.label;</button>
-          <button id="moreInformationButton" autocomplete="off">&moreInformation.label;</button>
+          <button id="returnButton" class="primary" data-telemetry-id="return_button_top">&returnToPreviousPage.label;</button>
+          <button id="openPortalLoginPageButton" class="primary">&openPortalLoginPage.label2;</button>
+          <button id="advancedButton" data-telemetry-id="advanced_button">&advanced.label;</button>
+          <button id="moreInformationButton">&moreInformation.label;</button>
         </div>
       </div>
 
       <div id="netErrorButtonContainer" class="button-container">
-        <button id="errorTryAgain" class="primary" autocomplete="off">&retry.label;</button>
+        <button id="errorTryAgain" class="primary">&retry.label;</button>
       </div>
 
       <div id="advancedPanelContainer">
         <div id="badCertAdvancedPanel" class="advanced-panel">
           <p id="badCertTechnicalInfo"/>
           <div id="advancedPanelButtonContainer" class="button-container">
-            <button id="advancedPanelErrorTryAgain" class="primary" autocomplete="off">&retry.label;</button>
+            <button id="advancedPanelErrorTryAgain" class="primary">&retry.label;</button>
           </div>
           <div class="exceptionDialogButtonContainer">
             <button id="exceptionDialogButton" data-telemetry-id="exception_button">&securityOverride.exceptionButtonLabel;</button>