From 51213edc3271346388443a1c9a05b66e58949fd2 Mon Sep 17 00:00:00 2001 From: "peterv%propagandism.org" Date: Mon, 5 Jul 2004 16:15:14 +0000 Subject: [PATCH] Add comment to explain the bustage fix for bug 236408. --- content/base/public/nsIDocument.h | 4 ++++ content/base/src/nsDocument.cpp | 1 + 2 files changed, 5 insertions(+) diff --git a/content/base/public/nsIDocument.h b/content/base/public/nsIDocument.h index a859489e4393..e680002e1ce3 100644 --- a/content/base/public/nsIDocument.h +++ b/content/base/public/nsIDocument.h @@ -121,6 +121,10 @@ public: virtual ~nsIDocument() { + // XXX The cleanup of mNodeInfoManager (calling DropDocumentReference and + // releasing it) happens in the nsDocument destructor. We'd prefer to + // do it here but nsNodeInfoManager is a concrete class that we don't + // want to expose to users of the nsIDocument API outside of Gecko. } virtual nsresult StartDocumentLoad(const char* aCommand, diff --git a/content/base/src/nsDocument.cpp b/content/base/src/nsDocument.cpp index b7172a6abbea..78ae2b97ea8a 100644 --- a/content/base/src/nsDocument.cpp +++ b/content/base/src/nsDocument.cpp @@ -587,6 +587,7 @@ nsDocument::~nsDocument() mCSSLoader->DropDocumentReference(); } + // XXX Ideally we'd do this cleanup in the nsIDocument destructor. if (mNodeInfoManager) { mNodeInfoManager->DropDocumentReference(); NS_RELEASE(mNodeInfoManager);