mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1646096 - Mark bug number for the incorrect calculation of the cross size for column-oriented flex container. r=dholbert 

Differential Revision: https://phabricator.services.mozilla.com/D88686
This commit is contained in:
Boris Chiou 2020-09-21 15:20:58 +00:00
Родитель 20eecc6085
Коммит 51ee1b55f9
6 изменённых файлов: 36 добавлений и 0 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

7
layout/generic/nsFlexContainerFrame.cpp
Просмотреть файл

@ -4135,6 +4135,13 @@ nscoord nsFlexContainerFrame::ComputeCrossSize(
"Unconstrained inline size; this should only result from huge sizes "
"(not intrinsic sizing w/ orthogonal flows)");
*aIsDefinite = true;
// FIXME: Bug 1661847 - there are cases where aReflowInput.ComputedISize()
// might not be the right thing to return here. Specifically: if our cross
// size is an intrinsic size, and we have flex items that are flexible and
// have intrinsic aspect ratios, then we may need to take their post-flexing
// main sizes into account (multiplied through their aspect ratios to get
// their cross sizes), in order to determine their flex line's size & the
// flex container's cross size (e.g. as `aSumLineCrossSizes`).
return aReflowInput.ComputedISize();
}

1
testing/web-platform/meta/css/css-sizing/aspect-ratio/flex-aspect-ratio-013.tentative.html.ini
Просмотреть файл

@ -1,2 +1,3 @@
[flex-aspect-ratio-013.tentative.html]
bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1661847
expected: FAIL

1
testing/web-platform/meta/css/css-sizing/aspect-ratio/flex-aspect-ratio-014.tentative.html.ini
Просмотреть файл

@ -1,2 +1,3 @@
[flex-aspect-ratio-014.tentative.html]
bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1661847
expected: FAIL

3
testing/web-platform/meta/css/css-sizing/aspect-ratio/flex-aspect-ratio-024.tentative.html.ini Normal file
Просмотреть файл

@ -0,0 +1,3 @@
[flex-aspect-ratio-024.tentative.html]
bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1661847
expected: FAIL

12
testing/web-platform/tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-023.tentative.html Normal file
Просмотреть файл

@ -0,0 +1,12 @@
<!DOCTYPE html>
<title>CSS aspect-ratio: Row flex container cross size with the replaced-element item</title>
<link rel="author" title="Mozilla" href="https://www.mozilla.org">
<link rel="help" href="https://drafts.csswg.org/css-sizing-4/#aspect-ratio">
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#algo-cross-item">
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht" />
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div style="display: flex; width: 100px;">
<img src="support/20x50-green.png" style="width: 50px; aspect-ratio: 1/1; flex: 1; min-height: 0;">
</div>

12
testing/web-platform/tests/css/css-sizing/aspect-ratio/flex-aspect-ratio-024.tentative.html Normal file
Просмотреть файл

@ -0,0 +1,12 @@
<!DOCTYPE html>
<title>CSS aspect-ratio: Column flex container cross size with the replaced-element item</title>
<link rel="author" title="Mozilla" href="https://www.mozilla.org/">
<link rel="help" href="https://drafts.csswg.org/css-sizing-4/#aspect-ratio">
<link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#algo-cross-item">
<link rel="match" href="../../reference/ref-filled-green-100px-square.xht" />
<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
<div style="display: inline-flex; flex-direction: column; height: 100px;">
<img src="support/20x50-green.png" style="aspect-ratio: 1/1; min-height: 0; height: 50px; flex: 1;">
</div>