From 5219cd120487ab7c47b804682f8153706a2dac95 Mon Sep 17 00:00:00 2001 From: Nicholas Nethercote Date: Tue, 17 Mar 2020 02:59:29 +0000 Subject: [PATCH] Bug 1622701 - Eliminate use of `fix_stack_using_bpsyms.py` in `utils.py`. r=gsvelto Differential Revision: https://phabricator.services.mozilla.com/D66918 --HG-- extra : moz-landing-system : lando --- testing/mozbase/mozrunner/mozrunner/utils.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/testing/mozbase/mozrunner/mozrunner/utils.py b/testing/mozbase/mozrunner/mozrunner/utils.py index 671e92587d82..d5f2091839d6 100755 --- a/testing/mozbase/mozrunner/mozrunner/utils.py +++ b/testing/mozbase/mozrunner/mozrunner/utils.py @@ -247,15 +247,14 @@ def get_stack_fixer_function(utilityPath, symbolsPath): return module if symbolsPath and os.path.exists(symbolsPath): - # Run each line through a function in fix_stack_using_bpsyms.py (uses breakpad - # symbol files). - # This method is preferred for Tinderbox builds, since native - # symbols may have been stripped. - stack_fixer_module = import_stack_fixer_module( - 'fix_stack_using_bpsyms') + # Run each line through fix_stacks.py, using breakpad symbol files. + # This method is preferred for automation, since native symbols may + # have been stripped. + stack_fixer_module = import_stack_fixer_module('fix_stacks') def stack_fixer_function(line): - return stack_fixer_module.fixSymbols(line, symbolsPath) + return stack_fixer_module.fixSymbols( + line, slowWarning=True, breakpadSymsDir=symbolsPath) elif mozinfo.isLinux or mozinfo.isMac or mozinfo.isWin: # Run each line through fix_stacks.py. This method is preferred for