Bug 1013664 - Fix bad implicit conversion constructors in XPCOM; r=froydnj

--HG--
extra : rebase_source : e3260a536292175cb1ad23a53dfe9e3f4bb8ff10

editor/txtsvc/src/nsTextServicesDocument.cpp

@@ -80,8 +80,6 @@ public:
 
 nsTextServicesDocument::nsTextServicesDocument()
 {
-  mRefCnt         = 0;
-
   mSelStartIndex  = -1;
   mSelStartOffset = -1;
   mSelEndIndex    = -1;

xpcom/glue/nsISupportsImpl.h

@@ -138,7 +138,7 @@ public:
     : mRefCntAndFlags(0)
   {}
 
-  nsCycleCollectingAutoRefCnt(uintptr_t aValue)
+  explicit nsCycleCollectingAutoRefCnt(uintptr_t aValue)
     : mRefCntAndFlags(aValue << NS_NUMBER_OF_FLAGS_IN_REFCNT)
   {
   }
@@ -233,7 +233,7 @@ class nsAutoRefCnt {
 
  public:
     nsAutoRefCnt() : mValue(0) {}
-    nsAutoRefCnt(nsrefcnt aValue) : mValue(aValue) {}
+    explicit nsAutoRefCnt(nsrefcnt aValue) : mValue(aValue) {}
 
     // only support prefix increment/decrement
     nsrefcnt operator++() { return ++mValue; }

xpcom/glue/nsTArray.h

@@ -102,7 +102,7 @@ class nsIntRegion;
 struct nsTArrayFallibleResult
 {
   // Note: allows implicit conversions from and to bool
-  nsTArrayFallibleResult(bool result)
+  MOZ_IMPLICIT nsTArrayFallibleResult(bool result)
     : mResult(result)
   {}
 

xpcom/string/public/nsString.h

@@ -83,7 +83,7 @@ public:
 
 private:
   // NOT TO BE IMPLEMENTED
-  NS_LossyConvertUTF16toASCII( char );
+  NS_LossyConvertUTF16toASCII( char ) MOZ_DELETE;
 };
 
 
@@ -109,7 +109,7 @@ public:
 
 private:
   // NOT TO BE IMPLEMENTED
-  NS_ConvertASCIItoUTF16( char16_t );
+  NS_ConvertASCIItoUTF16( char16_t ) MOZ_DELETE;
 };
 
 
@@ -145,7 +145,7 @@ public:
 
 private:
   // NOT TO BE IMPLEMENTED
-  NS_ConvertUTF16toUTF8( char );
+  NS_ConvertUTF16toUTF8( char ) MOZ_DELETE;
 };
 
 
@@ -171,7 +171,7 @@ public:
 
 private:
   // NOT TO BE IMPLEMENTED
-  NS_ConvertUTF8toUTF16( char16_t );
+  NS_ConvertUTF8toUTF16( char16_t ) MOZ_DELETE;
 };
 
 

xpcom/string/public/nsTDependentString.h

@@ -94,5 +94,5 @@ public:
 private:
 
   // NOT USED
-  nsTDependentString_CharT( const substring_tuple_type& );
+  nsTDependentString_CharT( const substring_tuple_type& ) MOZ_DELETE;
 };