Bug 1522529 - Remove focus hack from the gURLBar getter and properly implement UrlbarInput focus and blur methods. r=adw

Differential Revision: https://phabricator.services.mozilla.com/D17521

--HG--
extra : moz-landing-system : lando

browser/base/content/browser.js

@@ -190,11 +190,6 @@ XPCOMUtils.defineLazyGetter(this, "gURLBar", () => {
     return element;
   }
 
-  // Re-focus the input field if it was focused before switching bindings.
-  if (element.hasAttribute("focused")) {
-    element.inputField.focus();
-  }
-
   return new UrlbarInput({
     textbox: element,
     panel: document.getElementById("urlbar-results"),

browser/components/urlbar/UrlbarInput.jsm

@@ -62,7 +62,7 @@ class UrlbarInput {
     // Forward textbox methods and properties.
     const METHODS = ["addEventListener", "removeEventListener",
       "setAttribute", "hasAttribute", "removeAttribute", "getAttribute",
-      "focus", "blur", "select"];
+      "select"];
     const READ_ONLY_PROPERTIES = ["inputField", "editor"];
     const READ_WRITE_PROPERTIES = ["placeholder", "readOnly",
       "selectionStart", "selectionEnd"];
@@ -141,6 +141,14 @@ class UrlbarInput {
     this.view.close();
   }
 
+  focus() {
+    this.inputField.focus();
+  }
+
+  blur() {
+    this.inputField.blur();
+  }
+
   /**
    * Converts an internal URI (e.g. a wyciwyg URI) into one which we can
    * expose to the user.