From 53979f7c8a488fc8193687616019519fca4baea9 Mon Sep 17 00:00:00 2001 From: Mike Hommey Date: Wed, 5 Aug 2020 22:48:45 +0000 Subject: [PATCH] Bug 1657420 - Use single quotes instead of double quotes for the version_win.py command. r=dmajor On Windows, with the double quotes, the command goes through the msys shell, which then alters the command line such that empty arguments are transformed into \ when they reach python. With the single quotes, make invokes the command directly, without going through the msys shell, and empty arguments are preserved. Differential Revision: https://phabricator.services.mozilla.com/D86097 --- config/version.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/version.mk b/config/version.mk index 20d736c2fbcd..8c0c6395e22d 100644 --- a/config/version.mk +++ b/config/version.mk @@ -33,7 +33,7 @@ GARBAGE += $(RESFILE) $(RCFILE) all:: $(RCFILE): $(RCINCLUDE) $(MOZILLA_DIR)/config/version_win.py - $(PYTHON3) $(MOZILLA_DIR)/config/version_win.py "$(_RC_BINARY)" "$(RCINCLUDE)" + $(PYTHON3) $(MOZILLA_DIR)/config/version_win.py '$(_RC_BINARY)' '$(RCINCLUDE)' endif # RESFILE endif # Windows