From 5426506598ea5d4dce127e0a1bcd2b72e881bce7 Mon Sep 17 00:00:00 2001 From: Mats Palmgren Date: Sat, 24 Mar 2018 23:03:44 +0100 Subject: [PATCH] Bug 1447166 part 4 - [css-grid] Make InitializeItemBaselines iterate the GridItemInfo array instead of using a CSSOrderAwareFrameIterator (idempotent change). r=dholbert --- layout/generic/nsGridContainerFrame.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/layout/generic/nsGridContainerFrame.cpp b/layout/generic/nsGridContainerFrame.cpp index 63c6db762561..5d60a84f3074 100644 --- a/layout/generic/nsGridContainerFrame.cpp +++ b/layout/generic/nsGridContainerFrame.cpp @@ -4020,11 +4020,8 @@ nsGridContainerFrame::Tracks::InitializeItemBaselines( nsTArray lastBaselineItems; WritingMode wm = aState.mWM; ComputedStyle* containerSC = aState.mFrame->Style(); - CSSOrderAwareFrameIterator& iter = aState.mIter; - iter.Reset(); - for (; !iter.AtEnd(); iter.Next()) { - nsIFrame* child = *iter; - GridItemInfo& gridItem = aGridItems[iter.ItemIndex()]; + for (GridItemInfo& gridItem : aGridItems) { + nsIFrame* child = gridItem.mFrame; uint32_t baselineTrack = kAutoLine; auto state = ItemState(0); auto childWM = child->GetWritingMode();