From 5455d8494bedaedb5d94b9341695d419aa3009c0 Mon Sep 17 00:00:00 2001 From: Simon Giesecke Date: Wed, 6 May 2020 11:46:42 +0000 Subject: [PATCH] Bug 1626570 - Improve handling of copying arrays in dom/network/. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D73670 --- dom/network/TCPSocketChild.cpp | 4 +--- dom/network/UDPSocketChild.cpp | 5 +---- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/dom/network/TCPSocketChild.cpp b/dom/network/TCPSocketChild.cpp index f9966b6b67a7..446a090c255c 100644 --- a/dom/network/TCPSocketChild.cpp +++ b/dom/network/TCPSocketChild.cpp @@ -163,9 +163,7 @@ nsresult TCPSocketChild::SendSend(const ArrayBuffer& aData, return NS_ERROR_OUT_OF_MEMORY; } - nsTArray arr; - arr.SwapElements(fallibleArr); - SendData(arr); + SendData(SendableData{std::move(fallibleArr)}); return NS_OK; } diff --git a/dom/network/UDPSocketChild.cpp b/dom/network/UDPSocketChild.cpp index 6e6be8589ab9..76867354e084 100644 --- a/dom/network/UDPSocketChild.cpp +++ b/dom/network/UDPSocketChild.cpp @@ -136,10 +136,7 @@ nsresult UDPSocketChild::SendDataInternal(const UDPSocketAddr& aAddr, return NS_ERROR_OUT_OF_MEMORY; } - nsTArray array; - array.SwapElements(fallibleArray); - - SendOutgoingData(array, aAddr); + SendOutgoingData(UDPData{std::move(fallibleArray)}, aAddr); return NS_OK; }