Bug 1438750 - Remove mfbt/double-conversion.h, and change existing users to instead do #include "double-conversion/double-conversion.h" themselves. r=froydnj on a CLOSED TREE

--HG--
extra : amend_source : 72f066d9c75ae5ccd4d1e929896a2b12aa0ddc8c

config/check_spidermonkey_style.py

@@ -61,7 +61,7 @@ included_inclnames_to_ignore = set([
     'ffi.h',                    # generated in ctypes/libffi/
     'devtools/sharkctl.h',      # we ignore devtools/ in general
     'devtools/Instruments.h',   # we ignore devtools/ in general
-    'double-conversion.h',      # strange MFBT case
+    'double-conversion/double-conversion.h', # strange MFBT case
     'javascript-trace.h',       # generated in $OBJDIR if HAVE_DTRACE is defined
     'frontend/ReservedWordsGenerated.h', # generated in $OBJDIR
     'gc/StatsPhasesGenerated.h',         # generated in $OBJDIR

js/src/jsnum.cpp

@@ -11,7 +11,6 @@
 #include "jsnum.h"
 
 #include "mozilla/ArrayUtils.h"
-#include "mozilla/double-conversion.h"
 #include "mozilla/FloatingPoint.h"
 #include "mozilla/RangedPtr.h"
 
@@ -24,6 +23,7 @@
 #include "jsstr.h"
 #include "jstypes.h"
 
+#include "double-conversion/double-conversion.h"
 #include "js/Conversions.h"
 #include "util/DoubleToString.h"
 #include "vm/GlobalObject.h"

mfbt/JSONWriter.h

@@ -92,7 +92,7 @@
 #ifndef mozilla_JSONWriter_h
 #define mozilla_JSONWriter_h
 
-#include "mozilla/double-conversion.h"
+#include "double-conversion/double-conversion.h"
 #include "mozilla/IntegerPrintfMacros.h"
 #include "mozilla/PodOperations.h"
 #include "mozilla/Sprintf.h"

mfbt/decimal/moz-decimal-utils.h

@@ -10,7 +10,7 @@
 // of Decimal.cpp under the Mozilla source without blink core dependencies. Do
 // not include it into any file other than Decimal.cpp.
 
-#include "../double-conversion/double-conversion/double-conversion.h"
+#include "double-conversion/double-conversion.h"
 #include "mozilla/ArrayUtils.h"
 #include "mozilla/Casting.h"
 #include "mozilla/FloatingPoint.h"

mfbt/double-conversion.h

@@ -1,17 +0,0 @@
-/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
-/* vim: set ts=8 sts=2 et sw=2 tw=80: */
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-/*
- * A temporary header providing double-conversion functionality until we change
- * our code to use the double-conversion header directly.
- */
-
-#ifndef mozilla_double_conversion_h
-#define mozilla_double_conversion_h
-
-#include "double-conversion/double-conversion.h"
-
-#endif /* mozilla_double_conversion_h */

mfbt/moz.build

@@ -32,7 +32,6 @@ EXPORTS.mozilla = [
     'DebugOnly.h',
     'decimal/Decimal.h',
     'DefineEnum.h',
-    'double-conversion.h',
     'DoublyLinkedList.h',
     'EndianUtils.h',
     'EnumeratedArray.h',

toolkit/crashreporter/nsExceptionHandlerUtils.cpp

@@ -6,7 +6,7 @@
 
 #include "nsExceptionHandlerUtils.h"
 
-#include "mozilla/double-conversion.h"
+#include "double-conversion/double-conversion.h"
 
 // Format a non-negative double to a string, without using C-library functions,
 // which need to be avoided (.e.g. bug 1240160, comment 10).  Return false if

xpcom/string/nsTSubstring.cpp

@@ -4,12 +4,13 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-#include "nsASCIIMask.h"
+#include "double-conversion/double-conversion.h"
 #include "mozilla/CheckedInt.h"
-#include "mozilla/double-conversion.h"
+#include "mozilla/MathAlgorithms.h"
 #include "mozilla/MemoryReporting.h"
 #include "mozilla/Printf.h"
-#include "mozilla/MathAlgorithms.h"
+
+#include "nsASCIIMask.h"
 
 using double_conversion::DoubleToStringConverter;