Bug 1562194 - update heading with no content text label audit rule from failure to warning. r=nchevobbe

Differential Revision: https://phabricator.services.mozilla.com/D36762

--HG--
extra : moz-landing-system : lando

devtools/server/actors/accessibility/audit/text-label.js

@@ -288,7 +288,7 @@ const headingRule = function(accessible) {
   }
 
   const content = accessible.DOMNode.textContent && accessible.DOMNode.textContent.trim();
-  return content ? null : { score: FAIL, issue: HEADING_NO_CONTENT };
+  return content ? null : { score: WARNING, issue: HEADING_NO_CONTENT };
 };
 
 /**

devtools/server/tests/browser/browser_accessibility_text_label_audit.js

@@ -200,9 +200,9 @@ add_task(async function() {
     ["<h1> with inner content", "#heading-2", null],
     ["<h1> with white space inner content", "#heading-3",
       { score: FAIL, issue: HEADING_NO_NAME }],
-    ["<h1> with aria-label", "#heading-4", { score: FAIL, issue: HEADING_NO_CONTENT }],
+    ["<h1> with aria-label", "#heading-4", { score: WARNING, issue: HEADING_NO_CONTENT }],
     ["<h1> with aria-labelledby", "#heading-5",
-      { score: FAIL, issue: HEADING_NO_CONTENT }],
+      { score: WARNING, issue: HEADING_NO_CONTENT }],
     ["<h1> with inner content and aria-label", "#heading-6", null],
     ["<h1> with inner content and aria-labelledby", "#heading-7", null],
     ["Empty aria heading", "#heading-8", { score: FAIL, issue: HEADING_NO_NAME }],
@@ -210,9 +210,9 @@ add_task(async function() {
     ["Aria heading with white space inner content", "#heading-10",
       { score: FAIL, issue: HEADING_NO_NAME }],
     ["Aria heading with aria-label", "#heading-11",
-      { score: FAIL, issue: HEADING_NO_CONTENT }],
+      { score: WARNING, issue: HEADING_NO_CONTENT }],
     ["Aria heading with aria-labelledby", "#heading-12",
-      { score: FAIL, issue: HEADING_NO_CONTENT }],
+      { score: WARNING, issue: HEADING_NO_CONTENT }],
     ["Aria heading with inner content and aria-label", "#heading-13", null],
     ["Aria heading with inner content and aria-labelledby", "#heading-14", null],
     ["Image map with no name", "#imagemap-1", { score: FAIL, issue: IMAGE_NO_NAME }],