From 55491370c764bc092fbb5a57965f58f1d3bd0be1 Mon Sep 17 00:00:00 2001 From: Nick Alexander Date: Mon, 30 Jul 2012 13:05:04 -0700 Subject: [PATCH] Bug 766354: Don't leak PII from SendTabActivity. r=rnewman --HG-- extra : rebase_source : cd626fd18dec41efb80fd00250b164517bcd5d5b --- mobile/android/base/sync/CommandProcessor.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mobile/android/base/sync/CommandProcessor.java b/mobile/android/base/sync/CommandProcessor.java index a2ea0966d839..73978a96105d 100644 --- a/mobile/android/base/sync/CommandProcessor.java +++ b/mobile/android/base/sync/CommandProcessor.java @@ -152,14 +152,17 @@ public class CommandProcessor { @SuppressWarnings("unchecked") public void sendURIToClientForDisplay(String uri, String clientID, String title, String sender, Context context) { - Logger.info(LOG_TAG, "Sending URI to client: " + uri + " -> " + clientID + " (" + title + ")"); + Logger.info(LOG_TAG, "Sending URI to client " + clientID + "."); + if (Logger.LOG_PERSONAL_INFORMATION) { + Logger.pii(LOG_TAG, "URI is " + uri + "; title is '" + title + "'."); + } - JSONArray args = new JSONArray(); + final JSONArray args = new JSONArray(); args.add(uri); args.add(sender); args.add(title); - Command displayURICommand = new Command("displayURI", args); + final Command displayURICommand = new Command("displayURI", args); this.sendCommand(clientID, displayURICommand, context); }