Bug 1731263 - Add QM_WARNONLY_TRY to some IPC calls in CacheAPI, which might be related to potential shutdown hang; r=dom-storage-reviewers,jstutte

Differential Revision: https://phabricator.services.mozilla.com/D126092

dom/cache/AutoUtils.cpp

@@ -357,7 +357,8 @@ AutoParentOpResult::~AutoParentOpResult() {
       if (action == Forget || result.actorParent() == nullptr) {
         break;
       }
-      Unused << PCacheParent::Send__delete__(result.actorParent());
+
+      QM_WARNONLY_TRY(OkIf(PCacheParent::Send__delete__(result.actorParent())));
       break;
     }
     default:
@@ -366,7 +367,8 @@ AutoParentOpResult::~AutoParentOpResult() {
   }
 
   if (action == Delete && mStreamControl) {
-    Unused << PCacheStreamControlParent::Send__delete__(mStreamControl);
+    QM_WARNONLY_TRY(
+        OkIf(PCacheStreamControlParent::Send__delete__(mStreamControl)));
   }
 
   mStreamCleanupList.Clear();

dom/cache/CacheChild.cpp

@@ -97,7 +97,7 @@ void CacheChild::StartDestroy() {
   MOZ_DIAGNOSTIC_ASSERT(!mListener);
 
   // Start actor destruction from parent process
-  Unused << SendTeardown();
+  QM_WARNONLY_TRY(OkIf(SendTeardown()));
 }
 
 void CacheChild::ActorDestroy(ActorDestroyReason aReason) {

dom/cache/CacheStorageChild.cpp

@@ -87,7 +87,7 @@ void CacheStorageChild::StartDestroy() {
   MOZ_DIAGNOSTIC_ASSERT(!mListener);
 
   // Start actor destruction from parent process
-  Unused << SendTeardown();
+  QM_WARNONLY_TRY(OkIf(SendTeardown()));
 }
 
 void CacheStorageChild::ActorDestroy(ActorDestroyReason aReason) {

dom/cache/CacheStorageParent.cpp

@@ -89,7 +89,9 @@ mozilla::ipc::IPCResult CacheStorageParent::RecvPCacheOpConstructor(
 
   if (NS_WARN_IF(NS_FAILED(mVerifiedStatus))) {
     ErrorResult result(mVerifiedStatus);
-    Unused << CacheOpParent::Send__delete__(actor, std::move(result), void_t());
+
+    QM_WARNONLY_TRY(OkIf(
+        CacheOpParent::Send__delete__(actor, std::move(result), void_t())));
     return IPC_OK();
   }
 

dom/cache/CacheStreamControlChild.cpp

@@ -119,7 +119,8 @@ void CacheStreamControlChild::OpenStream(const nsID& aId,
 
 void CacheStreamControlChild::NoteClosedAfterForget(const nsID& aId) {
   NS_ASSERT_OWNINGTHREAD(CacheStreamControlChild);
-  Unused << SendNoteClosed(aId);
+
+  QM_WARNONLY_TRY(OkIf(SendNoteClosed(aId)));
 
   // A stream has closed.  If we delayed StartDestry() due to this stream
   // being read, then we should check to see if any of the remaining streams

dom/cache/CacheStreamControlParent.cpp

@@ -140,7 +140,8 @@ void CacheStreamControlParent::SetStreamList(
 void CacheStreamControlParent::CloseAll() {
   NS_ASSERT_OWNINGTHREAD(CacheStreamControlParent);
   NotifyCloseAll();
-  Unused << SendCloseAll();
+
+  QM_WARNONLY_TRY(OkIf(SendCloseAll()));
 }
 
 void CacheStreamControlParent::Shutdown() {