Bug 255792, nsSmallVoidArray::ReplaceElementAt does not work in the same way as nsVoidArray::ReplaceElementAt, r=rjesup,sr=alecf

xpcom/ds/nsVoidArray.cpp

@@ -1342,16 +1342,21 @@ nsSmallVoidArray::ReplaceElementAt(void* aElement, PRInt32 aIndex)
       SetSingleChild(aElement);
       return PR_TRUE;
     }
-    return PR_FALSE;
   }
-  else
-  {
-    nsVoidArray* vector = GetChildVector();
-    if (vector)
-      return vector->ReplaceElementAt(aElement, aIndex);
 
-    return PR_FALSE;
+  nsVoidArray* vector = GetChildVector();
+  if (!vector)
+  {
+    if (aIndex == 0)
+    {
+      SetSingleChild(aElement);
+      return PR_TRUE;
+    }
+    vector = SwitchToVector();
+    if (!vector)
+      return PR_FALSE;
   }
+  return vector->ReplaceElementAt(aElement, aIndex);
 }
 
 PRBool