Bug 1230193 - Finish enabling ESLint rule no-undef for devtools/. r=jdescottes

MozReview-Commit-ID: EVFivqFNy8a

--HG--
extra : rebase_source : b9591567dfdbe8f9d7d959c4ee2d0e5c7f43ea09

devtools/.eslintrc.js

@@ -13,15 +13,6 @@ module.exports = {
     "require": true,
   },
   "overrides": [{
-    // XXX Bug 1230193. We're still working on enabling no-undef for these test
-    // directories.
-    "files": [
-      "server/tests/mochitest/**",
-    ],
-    "rules": {
-      "no-undef": "off",
-    }
-  }, {
     "files": [
       "client/framework/**",
     ],

devtools/server/tests/mochitest/.eslintrc.js

@@ -2,5 +2,5 @@
 
 module.exports = {
   // Extend from the common devtools mochitest eslintrc config.
-  "extends": "../../../.eslintrc.xpcshell.js"
+  "extends": "../../../.eslintrc.mochitests.js"
 };

devtools/server/tests/mochitest/Debugger.Source.prototype.element.js

@@ -1,4 +1,5 @@
 /* exported heinrichFun */
+/* global franz */
 "use strict";
 
 function heinrichFun() {

devtools/server/tests/mochitest/test_connectToFrame.html

@@ -14,6 +14,9 @@ Bug 966991 - Test DebuggerServer.connectToFrame
 <script type="application/javascript">
 "use strict";
 
+// Part of this is a frame script.
+/* eslint-env mozilla/frame-script */
+
 const { require } = ChromeUtils.import("resource://devtools/shared/Loader.jsm", {});
 const { DebuggerClient } = require("devtools/shared/client/debugger-client");
 const { DebuggerServer } = require("devtools/server/main");

devtools/server/tests/mochitest/test_css-logic-media-queries.html

@@ -31,6 +31,7 @@ Test that css-logic handles media-queries correctly
     const {require} = ChromeUtils.import("resource://devtools/shared/Loader.jsm", {});
     const Services = require("Services");
     const {CssLogic} = require("devtools/server/actors/inspector/css-logic");
+    const InspectorUtils = require("InspectorUtils");
 
     SimpleTest.waitForExplicitFinish();
 

devtools/server/tests/mochitest/test_getProcess.html

@@ -14,6 +14,9 @@ Bug 1060093 - Test DebuggerServer.getProcess
 <script type="application/javascript">
 "use strict";
 
+// Part of this is a frame script.
+/* eslint-env mozilla/frame-script */
+
 const {require} = ChromeUtils.import("resource://devtools/shared/Loader.jsm", {});
 const {DebuggerClient} = require("devtools/shared/client/debugger-client");
 const {DebuggerServer} = require("devtools/server/main");

devtools/server/tests/mochitest/test_inspector-pseudoclass-lock.html

@@ -20,6 +20,8 @@ window.onload = function() {
   runNextTest();
 };
 
+const InspectorUtils = require("InspectorUtils");
+
 let gInspectee = null;
 let gWalker = null;
 let gCleanupConnection = null;

devtools/server/tests/mochitest/test_webextension-addon-debugging-connect.html

@@ -22,8 +22,10 @@ async function test_connect_addon(oopMode) {
   const extension = ExtensionTestUtils.loadExtension({
     useAddonManager: "temporary",
     background: function() {
+      /* eslint-disable no-undef */
       browser.test.log("background script executed");
       browser.test.sendMessage("background page ready");
+      /* eslint-enable no-undef */
     },
   });
   await extension.startup();