Bug 1530861 - Acknowledged newSource events sent by remote devices on FF66 and less. r=jdescottes

newSource events used to be sent on the target actors on FF66 and before,
this is no longer the case. But we still have to accept them if we connect
to old remotes, otherwise the events are considered as a method reply
and confuses packet ordering.

Differential Revision: https://phabricator.services.mozilla.com/D21394

--HG--
extra : moz-landing-system : lando

devtools/shared/specs/targets/addon.js

@@ -30,6 +30,17 @@ const addonTargetSpec = generateActorSpec({
       response: RetVal("json"),
     },
   },
+
+  events: {
+    // The thread actor is no longer emitting newSource event in the name of the target
+    // actor (bug 1269919), but as we may still connect to older servers which still do,
+    // we have to keep it being mentioned here. Otherwise the event is considered as a
+    // response to a request and confuses the packet ordering.
+    // We can remove that once FF57 is no longer supported.
+    newSource: {
+      type: "newSource",
+    },
+  },
 });
 
 exports.addonTargetSpec = addonTargetSpec;

devtools/shared/specs/targets/browsing-context.js

@@ -136,6 +136,15 @@ const browsingContextTargetSpecPrototype = {
     workerListChanged: {
       type: "workerListChanged",
     },
+
+    // The thread actor is no longer emitting newSource event in the name of the target
+    // actor (bug 1269919), but as we may still connect to older servers which still do,
+    // we have to keep it being mentioned here. Otherwise the event is considered as a
+    // response to a request and confuses the packet ordering.
+    // We can remove that once FF57 is no longer supported.
+    newSource: {
+      type: "newSource",
+    },
   },
 };
 

devtools/shared/specs/targets/content-process.js

@@ -24,6 +24,15 @@ const contentProcessTargetSpec = generateActorSpec({
     workerListChanged: {
       type: "workerListChanged",
     },
+
+    // The thread actor is no longer emitting newSource event in the name of the target
+    // actor (bug 1269919), but as we may still connect to older servers which still do,
+    // we have to keep it being mentioned here. Otherwise the event is considered as a
+    // response to a request and confuses the packet ordering.
+    // We can remove that once FF57 is no longer supported.
+    newSource: {
+      type: "newSource",
+    },
   },
 });
 

devtools/shared/specs/targets/worker.js

@@ -36,6 +36,15 @@ const workerTargetSpec = generateActorSpec({
     "worker-close": {
       type: "close",
     },
+
+    // The thread actor is no longer emitting newSource event in the name of the target
+    // actor (bug 1269919), but as we may still connect to older servers which still do,
+    // we have to keep it being mentioned here. Otherwise the event is considered as a
+    // response to a request and confuses the packet ordering.
+    // We can remove that once FF57 is no longer supported.
+    newSource: {
+      type: "newSource",
+    },
   },
 });