Bug 1451378 - Enable ESLint rule no-undef for more test files in devtools. r=jdescottes

MozReview-Commit-ID: 6q43u1m0hLI

--HG--
extra : rebase_source : 02bf20a95994ac2fb13e3a69e3d504564fcc279d

devtools/.eslintrc.js

@@ -16,12 +16,8 @@ module.exports = {
     // XXX Bug 1230193. We're still working on enabling no-undef for these test
     // directories.
     "files": [
-      "client/memory/test/**",
-      "server/tests/browser/**",
       "server/tests/mochitest/**",
-      "shared/heapsnapshot/tests/unit/**",
       "shared/tests/unit/**",
-      "shared/webconsole/test/**",
     ],
     "rules": {
       "no-undef": "off",

devtools/client/memory/test/browser/.eslintrc.js

@@ -3,14 +3,6 @@
 module.exports = {
   // Extend from the shared list of defined globals for mochitests.
   "extends": "../../../../.eslintrc.mochitests.js",
-  "globals": {
-    "addTab": true,
-    "censusState": true,
-    "refreshTab": true,
-    "removeTab": true,
-    "waitForTime": true,
-    "waitUntilState": true
-  },
   "rules": {
     "no-unused-vars": ["error", { "vars": "local", "args": "none" }],
   }

devtools/client/memory/test/browser/browser_memory_displays_01.js

@@ -7,7 +7,7 @@
  */
 
 const TEST_URL = "http://example.com/browser/devtools/client/memory/test/browser/doc_steady_allocation.html";
-const { viewState, censusState } = require("devtools/client/memory/constants");
+const { viewState } = require("devtools/client/memory/constants");
 const { changeView } = require("devtools/client/memory/actions/view");
 
 this.test = makeMemoryTest(TEST_URL, async function({ tab, panel }) {

devtools/client/memory/test/browser/browser_memory_filter_01.js

@@ -8,7 +8,6 @@
 const {
   dominatorTreeState,
   viewState,
-  censusState,
 } = require("devtools/client/memory/constants");
 const { changeViewAndRefresh, changeView } = require("devtools/client/memory/actions/view");
 

devtools/client/memory/test/browser/browser_memory_individuals_01.js

@@ -9,7 +9,6 @@
 const {
   individualsState,
   viewState,
-  censusState,
 } = require("devtools/client/memory/constants");
 const { changeView } = require("devtools/client/memory/actions/view");
 

devtools/client/memory/test/browser/browser_memory_keyboard-snapshot-list.js

@@ -6,8 +6,7 @@
 "use strict";
 
 const {
-  viewState,
-  censusState
+  viewState
 } = require("devtools/client/memory/constants");
 const {
   takeSnapshotAndCensus

devtools/client/memory/test/browser/browser_memory_keyboard.js

@@ -7,7 +7,6 @@
 "use strict";
 
 const {
-  censusState,
   viewState
 } = require("devtools/client/memory/constants");
 const {

devtools/client/memory/test/browser/browser_memory_simple_01.js

@@ -8,7 +8,7 @@
  */
 
 const TEST_URL = "http://example.com/browser/devtools/client/memory/test/browser/doc_steady_allocation.html";
-const { viewState, censusState } = require("devtools/client/memory/constants");
+const { viewState } = require("devtools/client/memory/constants");
 const { changeView } = require("devtools/client/memory/actions/view");
 
 this.test = makeMemoryTest(TEST_URL, async function({ tab, panel }) {

devtools/client/memory/test/browser/head.js

@@ -4,16 +4,18 @@
 "use strict";
 
 // Load the shared test helpers into this compartment.
+/* import-globals-from ../../../shared/test/shared-head.js */
 Services.scriptloader.loadSubScript(
   "chrome://mochitests/content/browser/devtools/client/shared/test/shared-head.js",
   this);
 
 // Load the shared Redux helpers into this compartment.
+/* import-globals-from ../../../shared/test/shared-redux-head.js */
 Services.scriptloader.loadSubScript(
   "chrome://mochitests/content/browser/devtools/client/shared/test/shared-redux-head.js",
   this);
 
-var { censusDisplays, snapshotState: states } = require("devtools/client/memory/constants");
+var { censusDisplays, censusState, snapshotState: states } = require("devtools/client/memory/constants");
 var { L10N } = require("devtools/client/memory/utils");
 
 Services.prefs.setBoolPref("devtools.memory.enabled", true);

devtools/client/memory/test/chrome/.eslintrc.js

@@ -3,11 +3,6 @@
 module.exports = {
   // Extend from the shared list of defined globals for mochitests.
   "extends": "../../../../.eslintrc.mochitests.js",
-  "globals": {
-    "SimpleTest": true,
-    "ok": true,
-    "requestAnimationFrame": true
-  },
   "rules": {
     "no-unused-vars": ["error", { "vars": "local", "args": "none" }],
   }

devtools/client/memory/test/unit/.eslintrc.js

@@ -6,7 +6,6 @@ module.exports = {
   "rules": {
     "no-unused-vars": ["error", {
       "vars": "local",
-      "varsIgnorePattern": "^run_test$"
     }]
   }
 };

devtools/client/memory/test/unit/head.js

@@ -3,6 +3,9 @@
 
 "use strict";
 
+// via xpcshell.ini
+/* import-globals-from ../../../shared/test/shared-redux-head.js */
+
 var { require } = ChromeUtils.import("resource://devtools/shared/Loader.jsm", {});
 
 var Services = require("Services");

devtools/server/tests/browser/.eslintrc.js

@@ -2,5 +2,5 @@
 
 module.exports = {
   // Extend from the common devtools mochitest eslintrc config.
-  "extends": "../../../.eslintrc.xpcshell.js"
+  "extends": "../../../.eslintrc.mochitests.js"
 };

devtools/server/tests/browser/browser_actor_error.js

@@ -26,12 +26,11 @@ async function test() {
   let { errorActor } = await gClient.listTabs();
   ok(errorActor, "Found the error actor.");
 
-  try {
-    await gClient.request({ to: globalActor, type: "error" });
-    ok(false, "The request is expected to fail.");
-  } catch (e) {
-    ok(true, "The request failed as expected, and was caught by the client");
-  }
+  await Assert.rejects(gClient.request({ to: errorActor, type: "error" }),
+    err => err.error == "unknownError" &&
+           /error occurred while processing 'error/.test(err.message),
+    "The request should be rejected");
+
   await gClient.close();
 
   finish();

devtools/server/tests/browser/browser_storage_cookies-duplicate-names.js

@@ -8,6 +8,7 @@
 // name (and different paths).
 
 const {StorageFront} = require("devtools/shared/fronts/storage");
+/* import-globals-from storage-helpers.js */
 Services.scriptloader.loadSubScript("chrome://mochitests/content/browser/devtools/server/tests/browser/storage-helpers.js", this);
 
 const TESTDATA = {

devtools/server/tests/browser/browser_storage_dynamic_windows.js

@@ -5,6 +5,7 @@
 "use strict";
 
 const { StorageFront } = require("devtools/shared/fronts/storage");
+/* import-globals-from storage-helpers.js */
 Services.scriptloader.loadSubScript(
   "chrome://mochitests/content/browser/devtools/server/tests/browser/storage-helpers.js",
   this);

devtools/server/tests/browser/browser_storage_listings.js

@@ -5,6 +5,7 @@
 "use strict";
 
 const {StorageFront} = require("devtools/shared/fronts/storage");
+/* import-globals-from storage-helpers.js */
 Services.scriptloader.loadSubScript("chrome://mochitests/content/browser/devtools/server/tests/browser/storage-helpers.js", this);
 
 const storeMap = {

devtools/server/tests/browser/doc_force_cc.html

@@ -12,6 +12,7 @@
     <script type="text/javascript">
     "use strict";
 
+    /* global test */
     window.test = function() {
       document.body.expando1 = { cycle: document.body };
       SpecialPowers.Cu.forceCC();

devtools/server/tests/browser/doc_force_gc.html

@@ -13,6 +13,7 @@
     "use strict";
 
     var x = 1;
+    /* global test */
     window.test = function() {
       SpecialPowers.Cu.forceGC();
       document.body.style.borderTop = x + "px solid red";

devtools/server/tests/browser/error-actor.js

@@ -5,6 +5,8 @@
 
 "use strict";
 
+/* global DebuggerServer */
+
 /**
  * Test actor designed to check that clients are properly notified of errors when calling
  * methods on old style actors.

devtools/server/tests/browser/storage-helpers.js

@@ -1,6 +1,9 @@
 /* Any copyright is dedicated to the Public Domain.
    http://creativecommons.org/publicdomain/zero/1.0/ */
 
+// This file assumes head.js is loaded in the global scope.
+/* import-globals-from head.js */
+
 /* exported openTabAndSetupStorage, clearStorage */
 
 "use strict";

devtools/shared/heapsnapshot/tests/unit/head_heapsnapshot.js

@@ -111,7 +111,7 @@ function getFilePath(name, allowMissing = false, usePlatformPathSeparator = fals
 
   path = path.slice(filePrePath.length);
 
-  if (sePlatformPathSeparator && path.match(/^\w:/)) {
+  if (usePlatformPathSeparator && path.match(/^\w:/)) {
     path = path.replace(/\//g, "\\");
   }
 
@@ -335,7 +335,7 @@ function assertLabelAndShallowSize(breakdown, givenDescription,
   dumpn("Given description: " + JSON.stringify(givenDescription, null, 4));
 
   const visitor = new LabelAndShallowSizeVisitor();
-  CensusUtils.walk(breakdown, description, visitor);
+  CensusUtils.walk(breakdown, givenDescription, visitor);
 
   dumpn("Expected shallow size: " + expectedShallowSize);
   dumpn("Actual shallow size: " + visitor.shallowSize());
@@ -435,7 +435,7 @@ function assertDeduplicatedPaths({ target, paths, expectedNodes, expectedEdges }
     }
     equal(count, 1,
       "should have exactly one matching edge for the expected edge = "
-      + JSON.stringify(edge));
+      + JSON.stringify(expectedEdge));
   }
 }
 

tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js

@@ -24,6 +24,7 @@ module.exports = {
     "DOMRequest": false,
     "Debugger": false,
     "DedicatedWorkerGlobalScope": false,
+    "DominatorTree": false,
     "HeapSnapshot": false,
     "IDBFileRequest": false,
     "IDBLocaleAwareKeyRange": false,
@@ -55,6 +56,7 @@ module.exports = {
     "console": true,
     "dump": true,
     "openDialog": false,
+    "saveStack": false,
     "sizeToContent": false,
     // Specific to Firefox
     // eslint-disable-next-line max-len

tools/lint/eslint/eslint-plugin-mozilla/lib/configs/xpcshell-test.js

@@ -9,6 +9,9 @@ module.exports = {
     "_TEST_FILE": false,
     "add_task": false,
     "add_test": false,
+    // Test-only function.
+    "allocationMarker": false,
+    "byteSize": false,
     "deepEqual": false,
     "do_await_remote_message": false,
     "do_check_instanceof": false,
@@ -29,6 +32,7 @@ module.exports = {
     "do_timeout": false,
     "equal": false,
     "executeSoon": false,
+    "gc": false,
     // XPCShell specific function, see XPCShellEnvironment.cpp
     "gczeal": false,
     "greater": false,

tools/lint/eslint/eslint-plugin-mozilla/lib/environments/jsm.js

@@ -35,7 +35,6 @@ module.exports = {
     "DOMException": false,
     "DOMRequest": false,
     "DOMStringList": false,
-    "DominatorTree": false,
     "ErrorEvent": false,
     "Event": false,
     "EventTarget": false,