b=161379 Fix JavaScript warnings in security code

r=ssaux sr=mscott

mailnews/extensions/smime/resources/content/am-smime.js

@@ -145,6 +145,7 @@ function onLockPreference()
 // stomping on the disabled state indiscriminately.
 function disableIfLocked( prefstrArray )
 {
+  var i;
   for (i=0; i<prefstrArray.length; i++) {
     var id = prefstrArray[i].id;
     var element = document.getElementById(id);
@@ -216,7 +217,7 @@ function checkOtherCert(nickname, pref, usage, msgNeedCertWantSame, msgWantSame,
 
   var certdb = Components.classes[nsX509CertDBContractID].getService(nsIX509CertDB);
   if (!certdb)
-    return null;
+    return;
   
   if (email_recipient_cert_usage == usage) {
     matchingOtherCert = certdb.getEmailEncryptionCert(nickname);

security/manager/pki/resources/content/clientauthask.js

@@ -68,7 +68,7 @@ function onLoad()
 function setDetails()
 {
   var index = parseInt(document.getElementById("nicknames").value);
-  details = dialogParams.GetString(index+itemCount+3);
+  var details = dialogParams.GetString(index+itemCount+3);
   document.getElementById("details").value = details;
 }
 

security/manager/pki/resources/content/clientauthask.xul

@@ -56,7 +56,7 @@
     </menulist>
     <description>&clientAuthAsk.message3;</description>
     <textbox readonly="true" id="details" multiline="true"
-      style="height: 11em; width=80em;"/>
+      style="height: 11em;"/>
     </groupbox>
   <separator/>
   <hbox>