From 5897c593026c6f07d6a1fded104c92c2f8f4a254 Mon Sep 17 00:00:00 2001 From: Chris Peterson Date: Thu, 1 Jul 2021 18:37:42 +0000 Subject: [PATCH] Bug 1718408 - Remove unnecessary -Wloop-analysis flag. r=firefox-build-system-reviewers,andi We don't need to manually enable -Wloop-analysis because it just enables: * -Wrange-loop-analysis, which we manually disable. * -Wfor-loop-analysis, which is enabled by -Wmost, which is enabled by -Wall: https://clang.llvm.org/docs/DiagnosticsReference.html#wall Depends on D118900 Differential Revision: https://phabricator.services.mozilla.com/D118901 --- build/moz.configure/warnings.configure | 6 ------ 1 file changed, 6 deletions(-) diff --git a/build/moz.configure/warnings.configure b/build/moz.configure/warnings.configure index 192f9574fedd..a3a20f37a654 100755 --- a/build/moz.configure/warnings.configure +++ b/build/moz.configure/warnings.configure @@ -87,12 +87,6 @@ check_and_add_gcc_warning("-Wempty-init-stmt", cxx_compiler) check_and_add_gcc_warning("-Wfloat-overflow-conversion") check_and_add_gcc_warning("-Wfloat-zero-conversion") -# catches issues around loops -check_and_add_gcc_warning("-Wloop-analysis") -# But, disable range-loop-analysis because it can raise unhelpful false -# positives. -check_and_add_gcc_warning("-Wno-range-loop-analysis") - # catches C++ version forward-compat issues check_and_add_gcc_warning("-Wc++2a-compat", cxx_compiler)