Bug 1185893 - abuse of bind(this) with add/removeEventListener r=gijs

--HG--
extra : commitid : 1GYxHS8fyOs
extra : histedit_source : 076c55f9015ed8289581a0d52ae03e03b9352267

browser/base/content/test/general/browser_fullscreen-window-open.js

@@ -332,7 +332,7 @@ WindowListener.prototype = {
 
     let domwindow = aXULWindow.QueryInterface(Ci.nsIInterfaceRequestor)
                     .getInterface(Ci.nsIDOMWindow);
-    domwindow.addEventListener("load", function onLoad(aEvent) {
+    let onLoad = aEvent => {
       is(domwindow.document.location.href, this.test_url,
         "Opened Window is expected: "+ this.test_title);
       if (this.callback_onSuccess) {
@@ -352,7 +352,8 @@ WindowListener.prototype = {
         domwindow.close();
         executeSoon(this.callBack_onFinalize);
       }
-    }.bind(this), true);
+    };
+    domwindow.addEventListener("load", onLoad, true);
   },
   onCloseWindow: function(aXULWindow) {},
   onWindowTitleChange: function(aXULWindow, aNewTitle) {},

browser/components/loop/modules/MozLoopService.jsm

@@ -898,7 +898,7 @@ let MozLoopServiceInternal = {
         return;
       }
 
-      chatbox.addEventListener("DOMContentLoaded", function loaded(event) {
+      let loaded = event => {
         if (event.target != chatbox.contentDocument) {
           return;
         }
@@ -987,7 +987,8 @@ let MozLoopServiceInternal = {
         pc_static.registerPeerConnectionLifecycleCallback(onPCLifecycleChange);
 
         UITour.notify("Loop:ChatWindowOpened");
-      }.bind(this), true);
+      };
+      chatbox.addEventListener("DOMContentLoaded", loaded, true);
     };
 
     let chatboxInstance = Chat.open(null, origin, "", url, undefined, undefined,

browser/components/migration/IEProfileMigrator.js

@@ -292,7 +292,7 @@ Cookies.prototype = {
   _readCookieFile: function C__readCookieFile(aFile, aCallback) {
     let fileReader = Cc["@mozilla.org/files/filereader;1"].
                      createInstance(Ci.nsIDOMFileReader);
-    fileReader.addEventListener("loadend", (function onLoadEnd() {
+    let onLoadEnd = () => {
       fileReader.removeEventListener("loadend", onLoadEnd, false);
 
       if (fileReader.readyState != fileReader.DONE) {
@@ -310,7 +310,8 @@ Cookies.prototype = {
       } finally {
         aCallback(success);
       }
-    }).bind(this), false);
+    };
+    fileReader.addEventListener("loadend", onLoadEnd, false);
     fileReader.readAsText(new File(aFile));
   },