Bug 1868411 - Remove -moz-non-native-content-theme media feature. r=jwatt

Non-native theme shipped a while ago. Let's make our UA sheet
consistent.

Differential Revision: https://phabricator.services.mozilla.com/D195567

layout/style/GeckoBindings.h

@@ -616,7 +616,6 @@ int32_t Gecko_GetNumStyleThreads();
 mozilla::StyleDisplayMode Gecko_MediaFeatures_GetDisplayMode(
     const mozilla::dom::Document*);
 
-bool Gecko_MediaFeatures_ShouldAvoidNativeTheme(const mozilla::dom::Document*);
 bool Gecko_MediaFeatures_UseOverlayScrollbars(const mozilla::dom::Document*);
 int32_t Gecko_MediaFeatures_GetColorDepth(const mozilla::dom::Document*);
 int32_t Gecko_MediaFeatures_GetMonochromeBitsPerPixel(

layout/style/nsMediaFeatures.cpp

@@ -98,10 +98,6 @@ bool Gecko_MediaFeatures_IsResourceDocument(const Document* aDocument) {
   return aDocument->IsResourceDoc();
 }
 
-bool Gecko_MediaFeatures_ShouldAvoidNativeTheme(const Document* aDocument) {
-  return aDocument->ShouldAvoidNativeTheme();
-}
-
 bool Gecko_MediaFeatures_UseOverlayScrollbars(const Document* aDocument) {
   nsPresContext* pc = aDocument->GetPresContext();
   return pc && pc->UseOverlayScrollbars();

layout/style/res/forms.css

@@ -84,9 +84,9 @@ input {
   appearance: auto;
   -moz-default-appearance: textfield;
   /* The sum of border and padding on block-start and block-end
-     must be the same here, for buttons, and for <select> (including its
-     internal padding magic) */
-  padding: 1px;
+     must be the same here, for buttons, and for <select> */
+  padding-block: 1px;
+  padding-inline: 2px;
   border: 2px inset ButtonBorder;
   background-color: Field;
   color: FieldText;
@@ -96,12 +96,6 @@ input {
   overflow-clip-box: padding-box content-box;
 }
 
-@media (-moz-non-native-content-theme) {
-  input {
-    padding-inline: 2px;
-  }
-}
-
 textarea {
   display: inline-block;
   appearance: auto;
@@ -523,23 +517,13 @@ input:is([type=reset], [type=button], [type=submit]) {
   white-space: pre;
   text-align: center;
   overflow-clip-box: padding-box;
+  padding-inline: 4px;
 }
 
 input[type=color] {
   inline-size: 64px;
   block-size: 32px;
-}
-
-@media (-moz-non-native-content-theme) {
-  button,
-  ::file-selector-button,
-  input:is([type=reset], [type=button], [type=submit]) {
-    padding-inline: 4px;
-  }
-
-  input[type=color] {
-    padding: 4px;
-  }
+  padding: 4px;
 }
 
 button,

layout/style/test/chrome/chrome-only-media-queries.js

@@ -1,7 +1,6 @@
 const CHROME_ONLY_TOGGLES = [
   "-moz-is-glyph",
   "-moz-print-preview",
-  "-moz-non-native-content-theme",
   "-moz-scrollbar-start-backward",
   "-moz-scrollbar-start-forward",
   "-moz-scrollbar-end-backward",

servo/components/style/gecko/media_features.rs

@@ -551,10 +551,6 @@ fn eval_moz_print_preview(context: &Context) -> bool {
     is_print_preview
 }
 
-fn eval_moz_non_native_content_theme(context: &Context) -> bool {
-    unsafe { bindings::Gecko_MediaFeatures_ShouldAvoidNativeTheme(context.device().document()) }
-}
-
 fn eval_moz_is_resource_document(context: &Context) -> bool {
     unsafe { bindings::Gecko_MediaFeatures_IsResourceDocument(context.device().document()) }
 }
@@ -668,7 +664,7 @@ macro_rules! lnf_int_feature {
 /// to support new types in these entries and (2) ensuring that either
 /// nsPresContext::MediaFeatureValuesChanged is called when the value that
 /// would be returned by the evaluator function could change.
-pub static MEDIA_FEATURES: [QueryFeatureDescription; 59] = [
+pub static MEDIA_FEATURES: [QueryFeatureDescription; 58] = [
     feature!(
         atom!("width"),
         AllowsRanges::Yes,
@@ -926,12 +922,6 @@ pub static MEDIA_FEATURES: [QueryFeatureDescription; 59] = [
         Evaluator::BoolInteger(eval_moz_print_preview),
         FeatureFlags::CHROME_AND_UA_ONLY,
     ),
-    feature!(
-        atom!("-moz-non-native-content-theme"),
-        AllowsRanges::No,
-        Evaluator::BoolInteger(eval_moz_non_native_content_theme),
-        FeatureFlags::CHROME_AND_UA_ONLY,
-    ),
     feature!(
         atom!("-moz-overlay-scrollbars"),
         AllowsRanges::No,

xpcom/ds/StaticAtoms.py

@@ -57,7 +57,6 @@ STATIC_ATOMS = [
     Atom("_moz_is_glyph", "-moz-is-glyph"),
     Atom("_moz_original_size", "_moz_original_size"),
     Atom("_moz_print_preview", "-moz-print-preview"),
-    Atom("_moz_non_native_content_theme", "-moz-non-native-content-theme"),
     Atom("menuactive", "_moz-menuactive"),
     Atom("_poundDefault", "#default"),
     Atom("_asterisk", "*"),