Bug 1366750 - Rename nsIIncrementalRunnable to nsIIdleRunnable. r=smaug

The name nsIIdleRunnable makes more sense, since its main use is in
nsIThread::idleDispatch.

MozReview-Commit-ID: H6qchxKnt7a
This commit is contained in:
Andreas Farre 2017-05-16 17:18:33 +02:00
Родитель 073576f302
Коммит 5a1916b791
7 изменённых файлов: 27 добавлений и 28 удалений

Просмотреть файл

@ -13,7 +13,6 @@
#include "nsCycleCollectionParticipant.h"
#include "nsDOMNavigationTiming.h"
#include "nsICancelableRunnable.h"
#include "nsIIncrementalRunnable.h"
#include "nsIRunnable.h"
#include "nsString.h"

Просмотреть файл

@ -563,7 +563,7 @@ NS_INTERFACE_MAP_END_INHERITING(TimeoutHandler)
class IdleRequestExecutor final : public nsIRunnable
, public nsICancelableRunnable
, public nsINamed
, public nsIIncrementalRunnable
, public nsIIdleRunnable
{
public:
explicit IdleRequestExecutor(nsGlobalWindow* aWindow)
@ -650,7 +650,7 @@ NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(IdleRequestExecutor)
NS_INTERFACE_MAP_ENTRY(nsIRunnable)
NS_INTERFACE_MAP_ENTRY(nsICancelableRunnable)
NS_INTERFACE_MAP_ENTRY(nsINamed)
NS_INTERFACE_MAP_ENTRY(nsIIncrementalRunnable)
NS_INTERFACE_MAP_ENTRY(nsIIdleRunnable)
NS_INTERFACE_MAP_ENTRY_AMBIGUOUS(nsISupports, nsIRunnable)
NS_INTERFACE_MAP_END

Просмотреть файл

@ -25,7 +25,7 @@ EXPORTS += [
'MainThreadUtils.h',
'nsEventQueue.h',
'nsICancelableRunnable.h',
'nsIIncrementalRunnable.h',
'nsIIdleRunnable.h',
'nsMemoryPressure.h',
'nsProcess.h',
'nsProxyRelease.h',

Просмотреть файл

@ -4,13 +4,13 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
#ifndef nsIIncrementalRunnable_h__
#define nsIIncrementalRunnable_h__
#ifndef nsIIdleRunnable_h__
#define nsIIdleRunnable_h__
#include "nsISupports.h"
#include "mozilla/TimeStamp.h"
#define NS_IINCREMENTALRUNNABLE_IID \
#define NS_IIDLERUNNABLE_IID \
{ 0x688be92e, 0x7ade, 0x4fdc, \
{ 0x9d, 0x83, 0x74, 0xcb, 0xef, 0xf4, 0xa5, 0x2c } }
@ -19,10 +19,10 @@
* A task interface for tasks that can schedule their work to happen
* in increments bounded by a deadline.
*/
class nsIIncrementalRunnable : public nsISupports
class nsIIdleRunnable : public nsISupports
{
public:
NS_DECLARE_STATIC_IID_ACCESSOR(NS_IINCREMENTALRUNNABLE_IID)
NS_DECLARE_STATIC_IID_ACCESSOR(NS_IIDLERUNNABLE_IID)
/**
* Notify the task of a point in time in the future when the task
@ -31,11 +31,11 @@ public:
virtual void SetDeadline(mozilla::TimeStamp aDeadline) = 0;
protected:
nsIIncrementalRunnable() { }
virtual ~nsIIncrementalRunnable() {}
nsIIdleRunnable() { }
virtual ~nsIIdleRunnable() {}
};
NS_DEFINE_STATIC_IID_ACCESSOR(nsIIncrementalRunnable,
NS_IINCREMENTALRUNNABLE_IID)
NS_DEFINE_STATIC_IID_ACCESSOR(nsIIdleRunnable,
NS_IIDLERUNNABLE_IID)
#endif // nsIIncrementalRunnable_h__
#endif // nsIIdleRunnable_h__

Просмотреть файл

@ -37,7 +37,7 @@
#include "mozilla/Unused.h"
#include "mozilla/dom/ScriptSettings.h"
#include "nsIIdlePeriod.h"
#include "nsIIncrementalRunnable.h"
#include "nsIIdleRunnable.h"
#include "nsThreadSyncDispatch.h"
#include "LeakRefPtr.h"
#include "GeckoProfiler.h"
@ -1157,7 +1157,7 @@ nsThread::GetIdleEvent(nsIRunnable** aEvent, MutexAutoLock& aProofOfLock)
mIdleEvents.GetEvent(false, aEvent, aProofOfLock);
if (*aEvent) {
nsCOMPtr<nsIIncrementalRunnable> incrementalEvent(do_QueryInterface(*aEvent));
nsCOMPtr<nsIIdleRunnable> incrementalEvent(do_QueryInterface(*aEvent));
if (incrementalEvent) {
incrementalEvent->SetDeadline(idleDeadline);
}

Просмотреть файл

@ -84,11 +84,11 @@ CancelableRunnable::Cancel()
return NS_OK;
}
NS_IMPL_ISUPPORTS_INHERITED(IncrementalRunnable, CancelableRunnable,
nsIIncrementalRunnable)
NS_IMPL_ISUPPORTS_INHERITED(IdleRunnable, CancelableRunnable,
nsIIdleRunnable)
void
IncrementalRunnable::SetDeadline(TimeStamp aDeadline)
IdleRunnable::SetDeadline(TimeStamp aDeadline)
{
// Do nothing
}

Просмотреть файл

@ -12,7 +12,7 @@
#include "MainThreadUtils.h"
#include "nsICancelableRunnable.h"
#include "nsIIdlePeriod.h"
#include "nsIIncrementalRunnable.h"
#include "nsIIdleRunnable.h"
#include "nsINamed.h"
#include "nsIRunnable.h"
#include "nsIThreadManager.h"
@ -379,22 +379,22 @@ private:
};
// This class is designed to be subclassed.
class IncrementalRunnable : public CancelableRunnable,
public nsIIncrementalRunnable
class IdleRunnable : public CancelableRunnable,
public nsIIdleRunnable
{
public:
NS_DECL_ISUPPORTS_INHERITED
// nsIIncrementalRunnable
// nsIIdleRunnable
virtual void SetDeadline(TimeStamp aDeadline) override;
IncrementalRunnable() {}
IdleRunnable() {}
protected:
virtual ~IncrementalRunnable() {}
virtual ~IdleRunnable() {}
private:
IncrementalRunnable(const IncrementalRunnable&) = delete;
IncrementalRunnable& operator=(const IncrementalRunnable&) = delete;
IncrementalRunnable& operator=(const IncrementalRunnable&&) = delete;
IdleRunnable(const IdleRunnable&) = delete;
IdleRunnable& operator=(const IdleRunnable&) = delete;
IdleRunnable& operator=(const IdleRunnable&&) = delete;
};
namespace detail {