Bug 1603182: Get rid of gFront from window. r=julienw

Depends on D69488

Differential Revision: https://phabricator.services.mozilla.com/D69898

--HG--
extra : moz-landing-system : lando

devtools/client/performance/panel.js

@@ -142,9 +142,6 @@ PerformancePanel.prototype = {
           await PerformanceController.startRecording();
         }
       }
-
-      // Keep references on window for front for tests.
-      this.panelWin.gFront = performanceFront;
     }
   },
 

devtools/client/performance/test/browser_aaa-run-first-leaktest.js

@@ -23,10 +23,5 @@ add_task(async function() {
   ok(toolbox, "Should have a toolbox available.");
   ok(panel, "Should have a panel available.");
 
-  ok(
-    panel.panelWin.gFront,
-    "Should have a front reference on the panel window."
-  );
-
   await teardownToolboxAndRemoveTab(panel);
 });

devtools/client/performance/test/browser_perf-recording-notices-03.js

@@ -50,16 +50,11 @@ add_task(async function() {
   });
 
   const { panel } = await initPerformanceInTab({ tab: target.localTab });
-  const {
-    gFront,
-    EVENTS,
-    $,
-    PerformanceController,
-    PerformanceView,
-  } = panel.panelWin;
+  const { EVENTS, $, PerformanceController, PerformanceView } = panel.panelWin;
 
   // Set a fast profiler-status update interval.
-  await gFront.setProfilerStatusInterval(10);
+  const performanceFront = await panel.target.getFront("performance");
+  await performanceFront.setProfilerStatusInterval(10);
 
   const DETAILS_CONTAINER = $("#details-pane-container");
   const NORMAL_BUFFER_STATUS_MESSAGE = $(

devtools/client/performance/test/browser_perf-recording-notices-04.js

@@ -44,16 +44,11 @@ add_task(async function() {
     win: window,
   });
 
-  const {
-    gFront,
-    EVENTS,
-    $,
-    PerformanceController,
-    PerformanceView,
-  } = panel.panelWin;
+  const { EVENTS, $, PerformanceController, PerformanceView } = panel.panelWin;
 
   // Set a fast profiler-status update interval
-  await gFront.setProfilerStatusInterval(10);
+  const performanceFront = await panel.target.getFront("performance");
+  await performanceFront.setProfilerStatusInterval(10);
 
   const DETAILS_CONTAINER = $("#details-pane-container");
   const NORMAL_BUFFER_STATUS_MESSAGE = $(

devtools/client/performance/test/browser_perf-recording-notices-05.js

@@ -18,10 +18,11 @@ add_task(async function() {
     win: window,
   });
 
-  const { gFront, $, PerformanceController } = panel.panelWin;
+  const { $, PerformanceController } = panel.panelWin;
 
   // Set a fast profiler-status update interval
-  await gFront.setProfilerStatusInterval(10);
+  const performanceFront = await panel.target.getFront("performance");
+  await performanceFront.setProfilerStatusInterval(10);
 
   let enabled = false;