Backed out changeset be7c53bea22d (bug 1586336) for reftest failures at accesskey.xul on a CLOSED TREE.

2019-10-04 21:22:07 +03:00 · 2019-10-04 21:22:07 +03:00 · 5c3ecc9909
--- a/layout/reftests/forms/textbox/accesskey-1-notref.xul
+++ b/layout/reftests/forms/textbox/accesskey-1-notref.xul
@ -9,7 +9,7 @@
      padding-top: 0px;
      font-size: 36px;
    }
-    label, input {
+    label, textbox {
      -moz-appearance: none;
      background: inherit;
      border: none 0px;
@ -20,7 +20,7 @@
      margin-bottom: 0px;
      padding-bottom: 0px;
    }
-    input {
+    textbox {
      margin-top: 12px;
      padding-top: 8px;
      margin-bottom: 5px;
@ -30,6 +30,6 @@

  <hbox align="baseline">
    <label value="test"/>
-    <input xmlns="http://www.w3.org/1999/xhtml" value="text"/>
+    <textbox value="text"/>
  </hbox>
 </window>
--- a/layout/reftests/forms/textbox/accesskey-1.xul
+++ b/layout/reftests/forms/textbox/accesskey-1.xul
@ -9,7 +9,7 @@
      padding-top: 0px;
      font-size: 36px;
    }
-    label, input {
+    label, textbox {
      -moz-appearance: none;
      background: inherit;
      border: none 0px;
@ -20,7 +20,7 @@
      margin-bottom: 0px;
      padding-bottom: 0px;
    }
-    input {
+    textbox {
      margin-top: 12px;
      padding-top: 8px;
      margin-bottom: 5px;
@ -30,6 +30,6 @@

  <hbox align="baseline">
    <label value="test" accesskey="s"/>
-    <input xmlns="http://www.w3.org/1999/xhtml" value="text"/>
+    <textbox value="text"/>
  </hbox>
 </window>
--- a/layout/reftests/forms/textbox/accesskey-2-ref.xul
+++ b/layout/reftests/forms/textbox/accesskey-2-ref.xul
@ -9,7 +9,7 @@
      padding-top: 0px;
      font-size: 36px;
    }
-    label, input {
+    label, textbox {
      -moz-appearance: none;
      background: inherit;
      border: none 0px;
@ -20,7 +20,7 @@
      margin-bottom: 0px;
      padding-bottom: 0px;
    }
-    input {
+    textbox {
      margin-top: 12px;
      padding-top: 8px;
      margin-bottom: 5px;
@ -31,6 +31,6 @@
  <hbox align="baseline">
    <!-- access key in LTR-overridden Arabic text -->
    <label value="&#x202d;&#x64a;&#x628;&#x631;&#x639;&#x644;&#x627;&#x202c; test" accesskey="&#x639;"/>
-    <input xmlns="http://www.w3.org/1999/xhtml" value=""/>
+    <textbox value=""/>
  </hbox>
 </window>
--- a/layout/reftests/forms/textbox/accesskey-2.xul
+++ b/layout/reftests/forms/textbox/accesskey-2.xul
@ -9,7 +9,7 @@
      padding-top: 0px;
      font-size: 36px;
    }
-    label, input {
+    label, textbox {
      -moz-appearance: none;
      background: inherit;
      border: none 0px;
@ -20,7 +20,7 @@
      margin-bottom: 0px;
      padding-bottom: 0px;
    }
-    input {
+    textbox {
      margin-top: 12px;
      padding-top: 8px;
      margin-bottom: 5px;
@ -31,6 +31,6 @@
  <hbox align="baseline">
    <!-- access key in RTL Arabic text -->
    <label value="&#x627;&#x644;&#x639;&#x631;&#x628;&#x64a; test" accesskey="&#x639;"/>
-    <input xmlns="http://www.w3.org/1999/xhtml" value=""/>
+    <textbox value=""/>
  </hbox>
 </window>
--- a/layout/reftests/forms/textbox/accesskey-3-notref.xul
+++ b/layout/reftests/forms/textbox/accesskey-3-notref.xul
@ -9,7 +9,7 @@
      padding-top: 0px;
      font-size: 36px;
    }
-    label, input {
+    label, textbox {
      -moz-appearance: none;
      background: inherit;
      border: none 0px;
@ -20,7 +20,7 @@
      margin-bottom: 0px;
      padding-bottom: 0px;
    }
-    input {
+    textbox {
      margin-top: 12px;
      padding-top: 8px;
      margin-bottom: 5px;
@ -31,6 +31,6 @@
  <hbox align="baseline">
    <!-- no access key, for != test -->
    <label value="&#x627;&#x644;&#x639;&#x631;&#x628;&#x64a; hello world"/>
-    <input xmlns="http://www.w3.org/1999/xhtml" value=""/>
+    <textbox value=""/>
  </hbox>
 </window>
--- a/layout/reftests/forms/textbox/accesskey-3-ref.xul
+++ b/layout/reftests/forms/textbox/accesskey-3-ref.xul
@ -9,7 +9,7 @@
      padding-top: 0px;
      font-size: 36px;
    }
-    label, input {
+    label, textbox {
      -moz-appearance: none;
      background: inherit;
      border: none 0px;
@ -20,7 +20,7 @@
      margin-bottom: 0px;
      padding-bottom: 0px;
    }
-    input {
+    textbox {
      margin-top: 12px;
      padding-top: 8px;
      margin-bottom: 5px;
@ -31,6 +31,6 @@
  <hbox align="baseline">
    <!-- access key in LTR text that follows RTL text (mixed direction) -->
    <label value="&#x627;&#x644;&#x639;&#x631;&#x628;&#x64a; hello world" accesskey="d"/>
-    <input xmlns="http://www.w3.org/1999/xhtml" value=""/>
+    <textbox value=""/>
  </hbox>
 </window>
--- a/layout/reftests/forms/textbox/accesskey-4-notref.xul
+++ b/layout/reftests/forms/textbox/accesskey-4-notref.xul
@ -9,7 +9,7 @@
      padding-top: 0px;
      font-size: 36px;
    }
-    label, input {
+    label, textbox {
      -moz-appearance: none;
      background: inherit;
      border: none 0px;
@ -20,7 +20,7 @@
      margin-bottom: 0px;
      padding-bottom: 0px;
    }
-    input {
+    textbox {
      margin-top: 12px;
      padding-top: 8px;
      margin-bottom: 5px;
@ -31,6 +31,6 @@
  <hbox align="baseline">
    <!-- no access key, for != test -->
    <label value="&#x627;&#x644;&#x639;&#x631;&#x628;&#x64a; hello world"/>
-    <input xmlns="http://www.w3.org/1999/xhtml" value=""/>
+    <textbox value=""/>
  </hbox>
 </window>
--- a/layout/reftests/forms/textbox/accesskey-4-ref.xul
+++ b/layout/reftests/forms/textbox/accesskey-4-ref.xul
@ -9,7 +9,7 @@
      padding-top: 0px;
      font-size: 36px;
    }
-    label, input {
+    label, textbox {
      -moz-appearance: none;
      background: inherit;
      border: none 0px;
@ -20,7 +20,7 @@
      margin-bottom: 0px;
      padding-bottom: 0px;
    }
-    input {
+    textbox {
      margin-top: 12px;
      padding-top: 8px;
      margin-bottom: 5px;
@ -31,6 +31,6 @@
  <hbox align="baseline">
    <!-- access key in English text following LTR-overridden Arabic -->
    <label value="&#x202d;&#x64a;&#x628;&#x631;&#x639;&#x644;&#x627;&#x202c; hello world" accesskey="w"/>
-    <input xmlns="http://www.w3.org/1999/xhtml" value=""/>
+    <textbox value=""/>
  </hbox>
 </window>
--- a/layout/reftests/forms/textbox/accesskey-4.xul
+++ b/layout/reftests/forms/textbox/accesskey-4.xul
@ -9,7 +9,7 @@
      padding-top: 0px;
      font-size: 36px;
    }
-    label, input {
+    label, textbox {
      -moz-appearance: none;
      background: inherit;
      border: none 0px;
@ -20,7 +20,7 @@
      margin-bottom: 0px;
      padding-bottom: 0px;
    }
-    input {
+    textbox {
      margin-top: 12px;
      padding-top: 8px;
      margin-bottom: 5px;
@ -31,6 +31,6 @@
  <hbox align="baseline">
    <!-- access key in English text following RTL Arabic -->
    <label value="&#x627;&#x644;&#x639;&#x631;&#x628;&#x64a; hello world" accesskey="w"/>
-    <input xmlns="http://www.w3.org/1999/xhtml" value=""/>
+    <textbox value=""/>
  </hbox>
 </window>
--- a/layout/reftests/forms/textbox/align-baseline-1-ref.xul
+++ b/layout/reftests/forms/textbox/align-baseline-1-ref.xul
@ -8,7 +8,7 @@
      margin-top: 12px;
      padding-top: 8px;
    }
-    label, input {
+    label, textbox {
      -moz-appearance: none;
      background: inherit;
      border: none 0px;
@ -21,6 +21,6 @@

  <hbox id="container" align="center">
    <label value="test"/>
-    <input xmlns="http://www.w3.org/1999/xhtml" value="text"/>
+    <textbox value="text"/>
  </hbox>
 </window>
--- a/layout/reftests/forms/textbox/align-baseline-1.xul
+++ b/layout/reftests/forms/textbox/align-baseline-1.xul
@ -8,7 +8,7 @@
      margin-top: 0px;
      padding-top: 0px;
    }
-    label, input {
+    label, textbox {
      -moz-appearance: none;
      background: inherit;
      border: none 0px;
@ -19,7 +19,7 @@
      margin-bottom: 0px;
      padding-bottom: 0px;
    }
-    input {
+    textbox {
      margin-top: 12px;
      padding-top: 8px;
      margin-bottom: 5px;
@ -29,6 +29,6 @@

  <hbox align="baseline">
    <label value="test"/>
-    <input xmlns="http://www.w3.org/1999/xhtml" value="text"/>
+    <textbox value="text"/>
  </hbox>
 </window>
--- a/layout/reftests/xul/accesskey-ref.xul
+++ b/layout/reftests/xul/accesskey-ref.xul
@ -5,19 +5,19 @@
 <window xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">

 <hbox align="start">
-  <label control="b1"><u>L</u>abel1</label><input xmlns="http://www.w3.org/1999/xhtml" id="b1" size="2"/>
-  <label control="b2">Labe<u>l</u>2</label><input xmlns="http://www.w3.org/1999/xhtml" id="b2" size="2"/>
-  <label control="b3">La<u>b</u>el3</label><input xmlns="http://www.w3.org/1999/xhtml" id="b3" size="2"/>
-  <label control="b4">Label4 (<u>X</u>)</label><input xmlns="http://www.w3.org/1999/xhtml" id="b4" size="2"/>
-  <label control="b5" maxwidth="50">Quite a <u>l</u>ong label. Hopefully it will wrap</label><input xmlns="http://www.w3.org/1999/xhtml" id="b5" label="Button5" size="2"/>
+  <label control="b1"><u>L</u>abel1</label><textbox id="b1" size="2"/>
+  <label control="b2">Labe<u>l</u>2</label><textbox id="b2" size="2"/>
+  <label control="b3">La<u>b</u>el3</label><textbox id="b3" size="2"/>
+  <label control="b4">Label4 (<u>X</u>)</label><textbox id="b4" size="2"/>
+  <label control="b5" maxwidth="50">Quite a <u>l</u>ong label. Hopefully it will wrap</label><textbox id="b5" label="Button5" size="2"/>
 </hbox>

 <hbox id="d" align="start">
-  <label control="d1"><u>L</u>abel1</label><input xmlns="http://www.w3.org/1999/xhtml" id="d1" size="2"/>
-  <label control="d2">Labe<u>l</u>2</label><input xmlns="http://www.w3.org/1999/xhtml" id="d2" size="2"/>
-  <label control="d3">La<u>b</u>el3</label><input xmlns="http://www.w3.org/1999/xhtml" id="d3" size="2"/>
-  <label control="d4">Label4 (<u>X</u>)</label><input xmlns="http://www.w3.org/1999/xhtml" id="d4" size="2"/>
-  <label control="d5" maxwidth="50">Quite a <u>l</u>ong label. Hopefully it will wrap</label><input xmlns="http://www.w3.org/1999/xhtml" id="d5" size="2"/>
+  <label control="d1"><u>L</u>abel1</label><textbox id="d1" size="2"/>
+  <label control="d2">Labe<u>l</u>2</label><textbox id="d2" size="2"/>
+  <label control="d3">La<u>b</u>el3</label><textbox id="d3" size="2"/>
+  <label control="d4">Label4 (<u>X</u>)</label><textbox id="d4" size="2"/>
+  <label control="d5" maxwidth="50">Quite a <u>l</u>ong label. Hopefully it will wrap</label><textbox id="d5" size="2"/>
 </hbox>

 </window>
--- a/layout/xul/crashtests/1379332-1.xul
+++ b/layout/xul/crashtests/1379332-1.xul
@ -0,0 +1,9 @@
+<?xml version="1.0"?>
+<window xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
+  <hbox style="visibility: collapse; position: relative">
+    <textbox>
+      <hbox style="position: absolute; display: block; width: 10px; height: 10px">
+      </hbox>
+    </textbox>
+  </hbox>
+</window>
--- a/layout/xul/crashtests/crashtests.list
+++ b/layout/xul/crashtests/crashtests.list
@ -61,4 +61,5 @@ load 583957-1.html
 load 617089.html
 load menulist-focused.xhtml
 load 716503.html
+load chrome://reftest/content/crashtests/layout/xul/crashtests/1379332-1.xul
 load chrome://reftest/content/crashtests/layout/xul/crashtests/1379332-2.xul
--- a/layout/xul/grid/reftests/column-sizing-1-ref.xul
+++ b/layout/xul/grid/reftests/column-sizing-1-ref.xul
@ -7,7 +7,7 @@
      <label value="Left" />
    </vbox>
    <vbox style="background:yellow">
-      <input xmlns="http://www.w3.org/1999/xhtml" value="Right" />
+      <textbox value="Right" />
    </vbox>
  </hbox>
 </window>
--- a/layout/xul/grid/reftests/column-sizing-1.xul
+++ b/layout/xul/grid/reftests/column-sizing-1.xul
@ -8,7 +8,7 @@
        <label value="Left" />
      </column>
      <column style="background:yellow">
-        <input xmlns="http://www.w3.org/1999/xhtml" value="Right" />
+        <textbox value="Right" />
      </column>
    </columns>
  </grid>
--- a/layout/xul/grid/reftests/row-or-column-sizing-1.xul
+++ b/layout/xul/grid/reftests/row-or-column-sizing-1.xul
@ -13,7 +13,7 @@
        <label value="Upper right" />
      </row>
      <row>
-        <input xmlns="http://www.w3.org/1999/xhtml" value="Lower left" />
+        <textbox value="Lower left" />
        <hbox />
      </row>
    </rows>
--- a/layout/xul/grid/reftests/row-or-column-sizing-2.xul
+++ b/layout/xul/grid/reftests/row-or-column-sizing-2.xul
@ -6,7 +6,7 @@
    <columns>
      <column>
        <hbox />
-        <input xmlns="http://www.w3.org/1999/xhtml" value="Lower left" />
+        <textbox value="Lower left" />
      </column>
      <column>
        <label value="Upper right" />
--- a/layout/xul/grid/reftests/row-or-column-sizing-3.xul
+++ b/layout/xul/grid/reftests/row-or-column-sizing-3.xul
@ -19,7 +19,7 @@
        <hbox />
      </row>
      <row>
-        <input xmlns="http://www.w3.org/1999/xhtml" value="Lower left" />
+        <textbox value="Lower left" />
        <hbox />
      </row>
    </rows>
--- a/layout/xul/grid/reftests/row-or-column-sizing-4.xul
+++ b/layout/xul/grid/reftests/row-or-column-sizing-4.xul
@ -6,7 +6,7 @@
    <columns>
      <column>
        <hbox />
-        <input xmlns="http://www.w3.org/1999/xhtml" value="Lower left" />
+        <textbox value="Lower left" />
      </column>
      <column>
        <hbox />
--- a/layout/xul/grid/reftests/row-sizing-1-ref.xul
+++ b/layout/xul/grid/reftests/row-sizing-1-ref.xul
@ -8,7 +8,7 @@
      <label value="Top" />
    </hbox>
    <hbox style="background:yellow">
-      <input xmlns="http://www.w3.org/1999/xhtml" value="Bottom" />
+      <textbox value="Bottom" />
    </hbox>
  </vbox>
 </window>
--- a/layout/xul/grid/reftests/row-sizing-1.xul
+++ b/layout/xul/grid/reftests/row-sizing-1.xul
@ -9,7 +9,7 @@
        <label value="Top" />
      </row>
      <row style="background:yellow">
-        <input xmlns="http://www.w3.org/1999/xhtml" value="Bottom" />
+        <textbox value="Bottom" />
      </row>
    </rows>
  </grid>