Bug 1568874: Rename and refactor some functions. r=jdescottes

Differential Revision: https://phabricator.services.mozilla.com/D60478

--HG--
extra : moz-landing-system : lando

devtools/client/inspector/animation/animation.js

@@ -326,7 +326,7 @@ class AnimationInspector {
 
   onAnimationStateChanged() {
     // Simply update the animations since the state has already been updated.
-    this.updateState([...this.state.animations]);
+    this.fireUpdateAction([...this.state.animations]);
   }
 
   /**
@@ -389,13 +389,13 @@ class AnimationInspector {
     // Also, don't update the state of removed animations since React components
     // may refer to the same instance still.
     try {
-      animations = await this.updateAnimations(animations);
+      animations = await this.refreshAnimationsState(animations);
     } catch (_) {
       console.error(`Updating Animations failed`);
       return;
     }
 
-    this.updateState(animations.concat(addedAnimations));
+    this.fireUpdateAction(animations.concat(addedAnimations));
   }
 
   onElementPickerStarted() {
@@ -490,7 +490,7 @@ class AnimationInspector {
 
     try {
       await this.doSetCurrentTimes(currentTime);
-      animations = await this.updateAnimations(animations);
+      animations = await this.refreshAnimationsState(animations);
     } catch (e) {
       // Expected if we've already been destroyed or other node have been selected
       // in the meantime.
@@ -501,7 +501,7 @@ class AnimationInspector {
     this.isCurrentTimeSet = false;
 
     if (shouldRefresh) {
-      this.updateState(animations);
+      this.fireUpdateAction(animations);
     }
   }
 
@@ -514,7 +514,7 @@ class AnimationInspector {
 
     try {
       await this.animationsFront.setPlaybackRates(animations, playbackRate);
-      animations = await this.updateAnimations(animations);
+      animations = await this.refreshAnimationsState(animations);
     } catch (e) {
       // Expected if we've already been destroyed or other node have been selected
       // in the meantime.
@@ -524,7 +524,7 @@ class AnimationInspector {
       this.setAnimationStateChangedListenerEnabled(true);
     }
 
-    await this.updateState(animations);
+    await this.fireUpdateAction(animations);
   }
 
   async setAnimationsPlayState(doPlay) {
@@ -563,7 +563,7 @@ class AnimationInspector {
         await this.animationsFront.pauseAll();
       }
 
-      animations = await this.updateAnimations(animations);
+      animations = await this.refreshAnimationsState(animations);
     } catch (e) {
       // Expected if we've already been destroyed or other node have been selected
       // in the meantime.
@@ -571,7 +571,7 @@ class AnimationInspector {
       return;
     }
 
-    await this.updateState(animations);
+    await this.fireUpdateAction(animations);
   }
 
   /**
@@ -731,13 +731,13 @@ class AnimationInspector {
             selection.nodeFront
           )
         : [];
-    this.updateState(animations);
+    this.fireUpdateAction(animations);
     this.setAnimationStateChangedListenerEnabled(true);
 
     done();
   }
 
-  async updateAnimations(animations) {
+  async refreshAnimationsState(animations) {
     let error = null;
 
     const promises = animations.map(animation => {
@@ -758,14 +758,14 @@ class AnimationInspector {
       throw new Error(error);
     }
 
-    // Even when removal animation on inspected document, updateAnimations
+    // Even when removal animation on inspected document, refreshAnimationsState
     // might be called before onAnimationsMutation due to the async timing.
-    // Return the animations as result of updateAnimations after getting rid of
+    // Return the animations as result of refreshAnimationsState after getting rid of
     // the animations since they should not display.
     return animations.filter(anim => !!anim.state.type);
   }
 
-  updateState(animations) {
+  fireUpdateAction(animations) {
     // Animation inspector already destroyed
     if (!this.inspector) {
       return;