Bug 1858139 - Use light-dark instead of toolbar[brighttext] in a few more places. r=emilio

Differential Revision: https://phabricator.services.mozilla.com/D190573

browser/themes/shared/downloads/indicator.css

@@ -109,11 +109,7 @@ toolbarpaletteitem > #downloads-button > .toolbarbutton-badge-stack > #downloads
 
 #downloads-button[attention="severe"] > .toolbarbutton-badge-stack > .toolbarbutton-badge {
   background: url(chrome://browser/skin/notification-fill-12.svg) no-repeat center;
-  fill: rgb(226,40,80);
-}
-
-toolbar[brighttext] #downloads-button[attention="severe"] > .toolbarbutton-badge-stack > .toolbarbutton-badge {
-  fill: rgb(255,132,138);
+  fill: light-dark(rgb(226,40,80), rgb(255,132,138));
 }
 
 #downloads-button[animate] > .toolbarbutton-badge-stack > .toolbarbutton-badge {

browser/themes/shared/tabs.css

@@ -334,13 +334,8 @@
       inset-inline-end: -6px;
       z-index: 1; /* Overlay tab title */
       padding: 2px;
-      stroke: var(--tab-icon-overlay-stroke, white);
-      color: var(--tab-icon-overlay-fill, black);
-
-      #TabsToolbar[brighttext] & {
-        stroke: var(--tab-icon-overlay-stroke, black);
-        color: var(--tab-icon-overlay-fill, white);
-      }
+      stroke: var(--tab-icon-overlay-stroke, light-dark(white, black));
+      color: var(--tab-icon-overlay-fill, light-dark(black, white));
     }
   }
 

browser/themes/shared/toolbarbutton-icons.css

@@ -398,11 +398,7 @@
 }
 
 #panic-button[open] {
-  fill: rgb(213, 32, 20);
-}
-
-toolbar[brighttext] #panic-button[open] {
-  fill: #ff848b;
+  fill: light-dark(rgb(213, 32, 20), #ff848b);
 }
 
 #library-button {

browser/themes/windows/browser.css

@@ -37,11 +37,7 @@
   }
 
   #main-menubar > menu[_moz-menuactive="true"] {
-    background-color: hsla(0,0%,0%,.12);
-  }
-
-  #toolbar-menubar[brighttext] > #menubar-items > #main-menubar > menu[_moz-menuactive="true"] {
-    background-color: hsla(0,0%,100%,.22);
+    background-color: light-dark(hsla(0,0%,0%,.12), hsla(0,0%,100%,.22));
   }
 
   /* Use a different color in inactive windows. */
@@ -191,16 +187,10 @@
 
 @media not (prefers-contrast) {
   .titlebar-button:hover {
-    background-color: hsla(0,0%,0%,.12);
+    background-color: light-dark(hsla(0,0%,0%,.12), hsla(0,0%,100%,.22));
   }
   .titlebar-button:hover:active {
-    background-color: hsla(0,0%,0%,.22);
-  }
-  toolbar[brighttext] .titlebar-button:not(.titlebar-close):hover {
-    background-color: hsla(0,0%,100%,.22);
-  }
-  toolbar[brighttext] .titlebar-button:not(.titlebar-close):hover:active {
-    background-color: hsla(0,0%,100%,.32);
+    background-color: light-dark(hsla(0,0%,0%,.22), hsla(0,0%,100%,.32));
   }
 
   .titlebar-close:hover {