From 5ea7438e89af8b95255b8434a8d515285515c1ff Mon Sep 17 00:00:00 2001 From: Mark Striemer Date: Wed, 28 Aug 2019 14:21:14 +0000 Subject: [PATCH] Bug 1576943 - Add a label to the about:config radio buttons r=jaws Differential Revision: https://phabricator.services.mozilla.com/D43632 --HG-- extra : moz-landing-system : lando --- browser/components/aboutconfig/content/aboutconfig.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/browser/components/aboutconfig/content/aboutconfig.js b/browser/components/aboutconfig/content/aboutconfig.js index 4f7498e5af7d..798a5f5fa910 100644 --- a/browser/components/aboutconfig/content/aboutconfig.js +++ b/browser/components/aboutconfig/content/aboutconfig.js @@ -247,9 +247,11 @@ class PrefRow { radio.type = "radio"; radio.name = "type"; radio.value = type; + radio.id = `add-type-${type}`; radio.checked = this.type == type; form.appendChild(radio); - let radioLabel = document.createElement("span"); + let radioLabel = document.createElement("label"); + radioLabel.setAttribute("for", radio.id); document.l10n.setAttributes(radioLabel, STRINGS_ADD_BY_TYPE[type]); form.appendChild(radioLabel); }