Bug 1755986 - Part 1: Apply static-analysis autofixes to dom/streams r=mgaudet

Ran `./mach static-analysis check --fix "--header-filter=mozilla/dom/" dom/streams/` and added only streams headers.

Differential Revision: https://phabricator.services.mozilla.com/D139055

dom/streams/ByteLengthQueuingStrategy.cpp

@@ -13,8 +13,7 @@
 #include "js/TypeDecls.h"
 #include "js/PropertyAndElement.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE_INHERITED(ByteLengthQueuingStrategy,
                                                 BaseQueuingStrategy)
@@ -98,5 +97,4 @@ already_AddRefed<Function> ByteLengthQueuingStrategy::GetSize(
   return function.forget();
 }
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom

dom/streams/ByteLengthQueuingStrategy.h

@@ -18,8 +18,7 @@
 #include "nsWrapperCache.h"
 #include "nsIGlobalObject.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 class ByteLengthQueuingStrategy final : public BaseQueuingStrategy,
                                         public nsWrapperCache {
  public:
@@ -45,7 +44,6 @@ class ByteLengthQueuingStrategy final : public BaseQueuingStrategy,
   already_AddRefed<Function> GetSize(ErrorResult& aRv);
 };
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom
 
 #endif

dom/streams/ByteStreamHelpers.cpp

@@ -10,8 +10,7 @@
 #include "js/experimental/TypedData.h"
 #include "mozilla/ErrorResult.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 // https://streams.spec.whatwg.org/#transfer-array-buffer
 // As some parts of the specifcation want to use the abrupt completion value,
@@ -104,5 +103,4 @@ JSObject* CloneAsUint8Array(JSContext* aCx, JS::HandleObject aObject) {
   return array;
 }
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom

dom/streams/ByteStreamHelpers.h

@@ -10,8 +10,7 @@
 #include "js/TypeDecls.h"
 #include "mozilla/ErrorResult.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 // https://streams.spec.whatwg.org/#transfer-array-buffer
 //
@@ -25,9 +24,8 @@ bool CanTransferArrayBuffer(JSContext* aCx, JS::Handle<JSObject*> aObject,
 // If this returns null, it will leave a pending exception on aCx which
 // must be handled by the caller (in the spec this is always the case
 // currently).
-JSObject* CloneAsUint8Array(JSContext* aCx, JS::HandleObject O);
+JSObject* CloneAsUint8Array(JSContext* aCx, JS::HandleObject aObject);
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom
 
 #endif

dom/streams/CountQueuingStrategy.cpp

@@ -10,8 +10,7 @@
 #include "nsCOMPtr.h"
 #include "nsISupports.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 NS_IMPL_CYCLE_COLLECTION(BaseQueuingStrategy, mGlobal)
 NS_IMPL_CYCLE_COLLECTING_ADDREF(BaseQueuingStrategy)
@@ -101,5 +100,4 @@ already_AddRefed<Function> CountQueuingStrategy::GetSize(ErrorResult& aRv) {
   return function.forget();
 }
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom

dom/streams/CountQueuingStrategy.h

@@ -17,8 +17,7 @@
 #include "nsWrapperCache.h"
 #include "nsIGlobalObject.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 class CountQueuingStrategy final : public BaseQueuingStrategy,
                                    public nsWrapperCache {
@@ -44,7 +43,6 @@ class CountQueuingStrategy final : public BaseQueuingStrategy,
   already_AddRefed<Function> GetSize(ErrorResult& aRv);
 };
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom
 
 #endif  // mozilla_dom_CountQueuingStrategy_h

dom/streams/ReadableByteStreamController.cpp

@@ -38,8 +38,7 @@
 
 #include <algorithm>  // std::min
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 NS_IMPL_CYCLE_COLLECTION_CLASS(ReadableByteStreamController)
 NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(ReadableByteStreamController,
@@ -2132,5 +2131,4 @@ void SetUpReadableByteStreamControllerFromBodyStreamUnderlyingSource(
       errorAlgorithm, highWaterMark, autoAllocateChunkSize, aRv);
 }
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom

dom/streams/ReadableStream.cpp

@@ -68,8 +68,7 @@ inline void ImplCycleCollectionUnlink(
   aReader = AsVariant(mozilla::Nothing());
 }
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 // Only needed for refcounted objects.
 NS_IMPL_CYCLE_COLLECTION_CLASS(ReadableStream)
@@ -965,5 +964,4 @@ already_AddRefed<ReadableStream> ReadableStream::Create(
   return stream.forget();
 }
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom

dom/streams/ReadableStream.h

@@ -23,8 +23,7 @@
 #  error "Shouldn't be compiling with this header without MOZ_DOM_STREAMS set"
 #endif
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 class Promise;
 class ReadableStreamGenericReader;
@@ -197,7 +196,6 @@ CreateReadableByteStream(JSContext* aCx, nsIGlobalObject* aGlobal,
                          UnderlyingSourceCancelCallbackHelper* aCancelAlgorithm,
                          ErrorResult& aRv);
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom
 
 #endif  // mozilla_dom_ReadableStream_h

dom/streams/ReadableStreamBYOBReader.cpp

@@ -20,8 +20,7 @@
 #include "mozilla/dom/ReadableStreamBYOBRequest.h"
 #include "mozilla/dom/ReadableStreamBYOBReader.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE_INHERITED(ReadableStreamBYOBReader,
                                                 ReadableStreamGenericReader,
@@ -350,5 +349,4 @@ already_AddRefed<ReadableStreamBYOBReader> AcquireReadableStreamBYOBReader(
   return reader.forget();
 }
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom

dom/streams/ReadableStreamBYOBReader.h

@@ -18,17 +18,14 @@
 #include "nsWrapperCache.h"
 #include "mozilla/LinkedList.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 class Promise;
 class ReadableStream;
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 class ReadableStreamBYOBReader final : public ReadableStreamGenericReader,
                                        public nsWrapperCache {
@@ -85,7 +82,6 @@ void ReadableStreamBYOBReaderRelease(JSContext* aCx,
                                      ReadableStreamBYOBReader* aReader,
                                      ErrorResult& aRv);
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom
 
 #endif  // mozilla_dom_ReadableStreamBYOBReader_h

dom/streams/ReadableStreamBYOBRequest.cpp

@@ -18,8 +18,7 @@
 #include "nsIGlobalObject.h"
 #include "nsWrapperCache.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 ReadableStreamBYOBRequest::ReadableStreamBYOBRequest(nsIGlobalObject* aGlobal)
     : mGlobal(aGlobal) {
@@ -136,5 +135,4 @@ void ReadableStreamBYOBRequest::SetController(
   mController = aController;
 }
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom

dom/streams/ReadableStreamBYOBRequest.h

@@ -19,8 +19,7 @@
 #include "nsWrapperCache.h"
 #include "nsIGlobalObject.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 class ReadableByteStreamController;
 
@@ -64,7 +63,6 @@ class ReadableStreamBYOBRequest final : public nsISupports,
   JS::Heap<JSObject*> mView;
 };
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom
 
 #endif

dom/streams/ReadableStreamDefaultController.cpp

@@ -21,8 +21,7 @@
 #include "nsCycleCollectionParticipant.h"
 #include "nsISupports.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 NS_IMPL_CYCLE_COLLECTION(ReadableStreamController, mGlobal)
 NS_IMPL_CYCLE_COLLECTING_ADDREF(ReadableStreamController)
@@ -724,5 +723,4 @@ void ReadableStreamDefaultController::ReleaseSteps() {
   // Step 1. Return.
 }
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom

dom/streams/ReadableStreamDefaultController.h

@@ -25,8 +25,7 @@
 #include "nsTArray.h"
 #include "nsISupportsBase.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 class ReadableStream;
 class ReadableStreamDefaultReader;
@@ -174,7 +173,6 @@ extern void ReadableStreamDefaultControllerError(
 extern void ReadableStreamDefaultControllerClearAlgorithms(
     ReadableStreamDefaultController* aController);
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom
 
 #endif  // mozilla_dom_ReadableStreamDefaultController_h

dom/streams/ReadableStreamDefaultReader.cpp

@@ -17,8 +17,7 @@
 #include "nsISupports.h"
 #include "nsWrapperCache.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 NS_IMPL_CYCLE_COLLECTION(ReadableStreamGenericReader, mClosedPromise, mStream,
                          mGlobal)
@@ -424,5 +423,4 @@ void SetUpReadableStreamDefaultReader(JSContext* aCx,
   aReader->ReadRequests().clear();
 }
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom

dom/streams/ReadableStreamDefaultReader.h

@@ -18,8 +18,7 @@
 #include "nsWrapperCache.h"
 #include "mozilla/LinkedList.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 class Promise;
 class ReadableStream;
@@ -103,7 +102,6 @@ void ReadableStreamDefaultReaderRelease(JSContext* aCx,
                                         ReadableStreamDefaultReader* aReader,
                                         ErrorResult& aRv);
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom
 
 #endif  // mozilla_dom_ReadableStreamDefaultReader_h

dom/streams/ReadableStreamGenericReader.h

@@ -12,8 +12,7 @@
 #include "nsISupports.h"
 #include "nsCycleCollectionParticipant.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 class ReadableStream;
 class ReadableStreamDefaultReader;
@@ -71,7 +70,6 @@ bool ReadableStreamReaderGenericInitialize(JSContext* aCx,
 void ReadableStreamReaderGenericRelease(ReadableStreamGenericReader* aReader,
                                         ErrorResult& aRv);
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom
 
 #endif

dom/streams/ReadableStreamTee.cpp

@@ -4,13 +4,13 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-#include "ReadableStream.h"
 #include "js/Exception.h"
 #include "js/TypeDecls.h"
 #include "js/experimental/TypedData.h"
 #include "mozilla/dom/ByteStreamHelpers.h"
 #include "mozilla/dom/PromiseNativeHandler.h"
 #include "mozilla/dom/ReadIntoRequest.h"
+#include "mozilla/dom/ReadableStream.h"
 #include "mozilla/dom/ReadableStreamBYOBReader.h"
 #include "mozilla/dom/ReadableStreamDefaultController.h"
 #include "mozilla/dom/ReadableStreamGenericReader.h"
@@ -272,7 +272,6 @@ MOZ_CAN_RUN_SCRIPT void ByteStreamTeePullAlgorithm(JSContext* aCx,
   }
 
   // Step {17,18}.6: Return a promise resolved with undefined.
-  return;
 }
 
 class NativeByteStreamTeePullAlgorithm final

dom/streams/WritableStreamDefaultController.h

@@ -22,8 +22,7 @@
 #include "nsTArray.h"
 #include "nsISupportsBase.h"
 
-namespace mozilla {
-namespace dom {
+namespace mozilla::dom {
 
 class AbortSignal;
 class WritableStream;
@@ -190,7 +189,6 @@ MOZ_CAN_RUN_SCRIPT extern double WritableStreamDefaultControllerGetChunkSize(
     JSContext* aCx, WritableStreamDefaultController* aController,
     JS::Handle<JS::Value> aChunk, ErrorResult& aRv);
 
-}  // namespace dom
-}  // namespace mozilla
+}  // namespace mozilla::dom
 
 #endif  // mozilla_dom_WritableStreamDefaultController_h