Links toolbar fixes. All are sr=hyatt, a=asa.

Bug 102895 - a few functions in the wrong place. Patch by choess@stwing.upenn.edu, r=sballard@netreach.net.

Bug 102899 - missing icons in Classic. Patch by gerv, r=choess.

Bug 103097 - two line fix to improve perf in auto-show case. Patch by sballard, r=gerv.

Bug 102991 - Links toolbar is officially known as Site Navigation Bar. Patch by gerv, r=choess.

themes/modern/communicator/bookmarks/bookmarksToolbar.css

@@ -58,7 +58,7 @@ toolbarbutton.bookmark-item[disabled="true"]:hover:active
 {
   color               : #9399AB;
   text-decoration     : none;
-  list-style-image    : url("chrome://communicator/skin/bookmarks/bookmark-item-disabled.gif");
+  list-style-image    : url("chrome://communicator/skin/bookmarks/bookmark-item-dis.gif");
   cursor              : default;
 }
 
@@ -67,17 +67,17 @@ toolbarbutton.bookmark-item[disabled="true"][container="true"]:hover,
 toolbarbutton.bookmark-item[disabled="true"][container="true"]:hover:active
 {
   border              : 1px solid transparent !important;
-  list-style-image    : url("chrome://communicator/skin/bookmarks/bookmark-folder-disabled.gif");
+  list-style-image    : url("chrome://communicator/skin/bookmarks/bookmark-folder-dis.gif");
 }
 
 .menuitem-iconic.bookmark-item[disabled="true"]
 {
-  list-style-image    : url("chrome://communicator/skin/bookmarks/bookmark-item-disabled.gif");
+  list-style-image    : url("chrome://communicator/skin/bookmarks/bookmark-item-dis.gif");
 }
 
 .menu-iconic.bookmark-item[disabled="true"][container="true"]
 {
-  list-style-image    : url("chrome://communicator/skin/bookmarks/bookmark-folder-disabled.gif");
+  list-style-image    : url("chrome://communicator/skin/bookmarks/bookmark-folder-dis.gif");
 }
 
 .bookmark-item > .toolbarbutton-box > .toolbarbutton-dropmarker {

xpfe/browser/resources/content/linkToolbarItem.js

@@ -258,8 +258,21 @@ function LinkToolbarTransientMenu (linkType) {
     if(!this.__proto__.displayLink.apply(this, [linkElement])) return false;
 
     this.getXULElement().removeAttribute("collapsed");
-    showMiscellaneousSeperator();
+    showMiscellaneousSeparator();
     return true;
   }
 }
+
+showMiscellaneousSeparator =
+function()
+{
+  document.getElementById("misc-separator").removeAttribute("collapsed");
+}
+
+hideMiscellaneousSeparator =
+function()
+{
+  document.getElementById("misc-separator").setAttribute("collapsed", "true");
+}
 LinkToolbarTransientMenu.prototype = new LinkToolbarMenu;
+

xpfe/browser/resources/content/linkToolbarOverlay.js

@@ -136,13 +136,16 @@ function()
   if (!linkToolbarUI.isLinkToolbarEnabled())
     return;
 
+  if (!linkToolbarHandler.hasItems)
+    return;
+
   linkToolbarUI.doClear();
 }
 
 LinkToolbarUI.prototype.doClear =
 function()
 {
-  this.hideMiscellaneousSeperator();
+  hideMiscellaneousSeparator();
   linkToolbarHandler.clearAllItems();
 }
 
@@ -185,17 +188,6 @@ function(checkedItem)
     this.doClear();
 }
 
-LinkToolbarUI.prototype.showMiscellaneousSeperator =
-function()
-{
-  document.getElementById("misc-seperator").removeAttribute("collapsed");
-}
-
-LinkToolbarUI.prototype.hideMiscellaneousSeperator =
-function()
-{
-  document.getElementById("misc-seperator").setAttribute("collapsed", "true");
-}
 LinkToolbarUI.prototype.initLinkbarVisibilityMenu = 
 function()
 {

xpfe/browser/resources/content/linkToolbarOverlay.xul

@@ -183,7 +183,7 @@
             <menupopup id="link-alternate-popup" />
           </menu>
 
-          <menuseparator collapsed="true" id="misc-seperator" />
+          <menuseparator collapsed="true" id="misc-separator" />
 
         </menupopup>
       </toolbarbutton>

xpfe/browser/resources/locale/en-US/linkToolbar.dtd

@@ -37,7 +37,7 @@
    - ***** END LICENSE BLOCK ***** -->
 
 <!-- Link Toolbar Title -->
-<!ENTITY linkToolbar.label "Link Toolbar">
+<!ENTITY linkToolbar.label "Site Navigation Bar">
 
 <!-- Link Toolbar visibility options -->
 <!ENTITY linkToolbarAlways.label "Show Always">