Bug 813818 - just return nsString by value in GfxInfoBase getters, not perf critical, not worth doing fancy things - r=joe

widget/android/GfxInfo.cpp

@@ -393,22 +393,22 @@ NS_IMETHODIMP GfxInfo::SpoofOSVersion(uint32_t aVersion)
 
 #endif
 
-const nsAString& GfxInfo::Model() const
+nsString GfxInfo::Model() const
 {
   return mModel;
 }
 
-const nsAString& GfxInfo::Hardware() const
+nsString GfxInfo::Hardware() const
 {
   return mHardware;
 }
 
-const nsAString& GfxInfo::Product() const
+nsString GfxInfo::Product() const
 {
   return mProduct;
 }
 
-const nsAString& GfxInfo::Manufacturer() const
+nsString GfxInfo::Manufacturer() const
 {
   return mManufacturer;
 }

widget/android/GfxInfo.h

@@ -48,10 +48,10 @@ public:
 
   void EnsureInitializedFromGfxInfoData();
 
-  virtual const nsAString& Model() const;
-  virtual const nsAString& Hardware() const;
-  virtual const nsAString& Product() const;
-  virtual const nsAString& Manufacturer() const;
+  virtual nsString Model() const;
+  virtual nsString Hardware() const;
+  virtual nsString Product() const;
+  virtual nsString Manufacturer() const;
 
 #ifdef DEBUG
   NS_DECL_ISUPPORTS_INHERITED

widget/xpwidgets/GfxInfoBase.h

@@ -68,10 +68,10 @@ public:
   static nsTArray<GfxDriverInfo>* mDriverInfo;
   static bool mDriverInfoObserverInitialized;
 
-  virtual const nsAString& Model() const { return EmptyString(); }
-  virtual const nsAString& Hardware() const { return EmptyString(); }
-  virtual const nsAString& Product() const { return EmptyString(); }
-  virtual const nsAString& Manufacturer() const { return EmptyString(); }
+  virtual nsString Model() const { return EmptyString(); }
+  virtual nsString Hardware() const { return EmptyString(); }
+  virtual nsString Product() const { return EmptyString(); }
+  virtual nsString Manufacturer() const { return EmptyString(); }
   virtual uint32_t OperatingSystemVersion() const { return 0; }
 
 protected: