Bug 859020 - Remove the MSVC exemption for FAIL_ON_WARNINGS in dom. r=bz

dom/audiochannel/AudioChannelService.cpp

@@ -515,6 +515,6 @@ AudioChannelService::GetInternalType(AudioChannelType aType,
       break;
   }
 
-  MOZ_NOT_REACHED();
+  MOZ_NOT_REACHED("unexpected audio channel type");
   return AUDIO_CHANNEL_INT_LAST;
 }

dom/audiochannel/Makefile.in

@@ -23,9 +23,7 @@ LIBRARY_NAME     = domaudiochannel_s
 LIBXUL_LIBRARY = 1
 FORCE_STATIC_LIB = 1
 EXPORT_LIBRARY = 1
-ifndef _MSC_VER
 FAIL_ON_WARNINGS := 1
-endif # !_MSC_VER
 
 CPPSRCS += \
   AudioChannelService.cpp \

dom/base/Makefile.in

@@ -12,9 +12,7 @@ include $(DEPTH)/config/autoconf.mk
 LIBRARY_NAME	= jsdombase_s
 LIBXUL_LIBRARY	= 1
 FORCE_STATIC_LIB = 1
-ifndef _MSC_VER
 FAIL_ON_WARNINGS := 1
-endif # !_MSC_VER
 
 EXTRA_COMPONENTS = \
   SiteSpecificUserAgent.js \

dom/base/nsScreen.cpp

@@ -390,7 +390,7 @@ nsScreen::MozLockOrientation(const Sequence<nsString>& aOrientations,
 
   // This is only for compilers that don't understand that the previous switch
   // will always return.
-  MOZ_NOT_REACHED();
+  MOZ_NOT_REACHED("unexpected lock orientation permission value");
   return false;
 }
 

dom/indexedDB/Key.cpp

@@ -392,8 +392,10 @@ Key::EncodeNumber(double aFloat, uint8_t aType)
 
   Float64Union pun;
   pun.d = aFloat;
+  // Note: The subtraction from 0 below is necessary to fix
+  // MSVC build warning C4146 (negating an unsigned value).
   uint64_t number = pun.u & PR_UINT64(0x8000000000000000) ?
-                    -pun.u :
+                    (0 - pun.u) :
                     (pun.u | PR_UINT64(0x8000000000000000));
 
   number = NS_SWAP64(number);
@@ -416,9 +418,11 @@ Key::DecodeNumber(const unsigned char*& aPos, const unsigned char* aEnd)
   aPos += sizeof(number);
 
   Float64Union pun;
+  // Note: The subtraction from 0 below is necessary to fix
+  // MSVC build warning C4146 (negating an unsigned value).
   pun.u = number & PR_UINT64(0x8000000000000000) ?
           (number & ~PR_UINT64(0x8000000000000000)) :
-          -number;
+          (0 - number);
 
   return pun.d;
 }

dom/indexedDB/Makefile.in

@@ -12,9 +12,7 @@ include $(DEPTH)/config/autoconf.mk
 LIBRARY_NAME = dom_indexeddb_s
 LIBXUL_LIBRARY = 1
 FORCE_STATIC_LIB = 1
-ifndef _MSC_VER
 FAIL_ON_WARNINGS := 1
-endif # !_MSC_VER
 
 CPPSRCS = \
   AsyncConnectionHelper.cpp \

dom/network/src/Makefile.in

@@ -12,9 +12,7 @@ include $(DEPTH)/config/autoconf.mk
 LIBRARY_NAME     = dom_network_s
 LIBXUL_LIBRARY   = 1
 FORCE_STATIC_LIB = 1
-ifndef _MSC_VER
 FAIL_ON_WARNINGS := 1
-endif # !_MSC_VER
 
 EXTRA_COMPONENTS = \
 	TCPSocket.js \

dom/network/src/TCPSocketParent.cpp

@@ -109,7 +109,7 @@ TCPSocketParent::RecvData(const SendableData& aData)
       break;
 
     default:
-      MOZ_NOT_REACHED();
+      MOZ_NOT_REACHED("unexpected SendableData type");
       return false;
   }
   return true;

dom/power/Makefile.in

@@ -12,9 +12,7 @@ include $(DEPTH)/config/autoconf.mk
 LIBRARY_NAME     = dom_power_s
 LIBXUL_LIBRARY   = 1
 FORCE_STATIC_LIB = 1
-ifndef _MSC_VER
 FAIL_ON_WARNINGS := 1
-endif # !_MSC_VER
 
 include $(topsrcdir)/dom/dom-config.mk
 

dom/power/PowerManagerService.cpp

@@ -119,7 +119,7 @@ PowerManagerService::Reboot()
   // To synchronize any unsaved user data before rebooting.
   SyncProfile();
   hal::Reboot();
-  MOZ_NOT_REACHED();
+  MOZ_NOT_REACHED("hal::Reboot() shouldn't return");
   return NS_OK;
 }
 
@@ -130,7 +130,7 @@ PowerManagerService::PowerOff()
   // To synchronize any unsaved user data before powering off.
   SyncProfile();
   hal::PowerOff();
-  MOZ_NOT_REACHED();
+  MOZ_NOT_REACHED("hal::PowerOff() shouldn't return");
   return NS_OK;
 }
 
@@ -153,7 +153,7 @@ PowerManagerService::Restart()
   sync();
 #endif
   _exit(0);
-  MOZ_NOT_REACHED();
+  MOZ_NOT_REACHED("_exit() shouldn't return");
   return NS_OK;
 }