From 60f57af35ac9de48e2ec68ec5884c77e53e4309d Mon Sep 17 00:00:00 2001 From: Gabriel Luong Date: Mon, 30 Apr 2018 14:35:43 -0400 Subject: [PATCH] Bug 1456680 - Part 5: Remove unused onShowGridLineNamesHighlight method. r=pbro --- .../client/inspector/grids/components/Grid.js | 1 - .../client/inspector/grids/grid-inspector.js | 35 ------------------- devtools/client/inspector/layout/layout.js | 2 -- 3 files changed, 38 deletions(-) diff --git a/devtools/client/inspector/grids/components/Grid.js b/devtools/client/inspector/grids/components/Grid.js index 624e8cdcb67c..023d3c7a481b 100644 --- a/devtools/client/inspector/grids/components/Grid.js +++ b/devtools/client/inspector/grids/components/Grid.js @@ -27,7 +27,6 @@ class Grid extends PureComponent { onShowBoxModelHighlighterForNode: PropTypes.func.isRequired, onShowGridAreaHighlight: PropTypes.func.isRequired, onShowGridCellHighlight: PropTypes.func.isRequired, - onShowGridLineNamesHighlight: PropTypes.func.isRequired, onToggleGridHighlighter: PropTypes.func.isRequired, onToggleShowGridAreas: PropTypes.func.isRequired, onToggleShowGridLineNumbers: PropTypes.func.isRequired, diff --git a/devtools/client/inspector/grids/grid-inspector.js b/devtools/client/inspector/grids/grid-inspector.js index 78411d5dd0e5..97962f209dec 100644 --- a/devtools/client/inspector/grids/grid-inspector.js +++ b/devtools/client/inspector/grids/grid-inspector.js @@ -64,7 +64,6 @@ class GridInspector { this.onSetGridOverlayColor = this.onSetGridOverlayColor.bind(this); this.onShowGridAreaHighlight = this.onShowGridAreaHighlight.bind(this); this.onShowGridCellHighlight = this.onShowGridCellHighlight.bind(this); - this.onShowGridLineNamesHighlight = this.onShowGridLineNamesHighlight.bind(this); this.onSidebarSelect = this.onSidebarSelect.bind(this); this.onToggleGridHighlighter = this.onToggleGridHighlighter.bind(this); this.onToggleShowGridAreas = this.onToggleShowGridAreas.bind(this); @@ -141,7 +140,6 @@ class GridInspector { onSetGridOverlayColor: this.onSetGridOverlayColor, onShowGridAreaHighlight: this.onShowGridAreaHighlight, onShowGridCellHighlight: this.onShowGridCellHighlight, - onShowGridLineNamesHighlight: this.onShowGridLineNamesHighlight, onToggleGridHighlighter: this.onToggleGridHighlighter, onToggleShowGridAreas: this.onToggleShowGridAreas, onToggleShowGridLineNumbers: this.onToggleShowGridLineNumbers, @@ -568,39 +566,6 @@ class GridInspector { this.store.dispatch(updateGridHighlighted(node, true)); } - /** - * Highlights the grid line in the CSS Grid Highlighter for the given grid. - * - * @param {NodeFront} node - * The NodeFront of the grid container element for which the grid - * highlighter is highlighted for. - * @param {Number|null} gridFragmentIndex - * The index of the grid fragment for which the grid highlighter - * is highlighted for. - * @param {String} color - * The color of the grid line for which the grid highlighter - * is highlighted for. - * @param {Number|null} lineNumber - * The line number of the grid for which the grid highlighter - * is highlighted for. - * @param {String|null} type - * The type of line for which the grid line is being highlighted for. - */ - onShowGridLineNamesHighlight(node, gridFragmentIndex, color, lineNumber, type) { - let { highlighterSettings } = this.store.getState(); - - highlighterSettings.showGridLineNames = { - gridFragmentIndex, - lineNumber, - type - }; - highlighterSettings.color = color; - - this.showGridHighlighter(node, highlighterSettings); - - this.store.dispatch(updateGridHighlighted(node, true)); - } - /** * Handler for the inspector sidebar "select" event. Starts tracking reflows * if the layout panel is visible. Otherwise, stop tracking reflows. diff --git a/devtools/client/inspector/layout/layout.js b/devtools/client/inspector/layout/layout.js index 8db68f91e1b6..8d70a6642301 100644 --- a/devtools/client/inspector/layout/layout.js +++ b/devtools/client/inspector/layout/layout.js @@ -54,7 +54,6 @@ class LayoutView { onSetGridOverlayColor, onShowGridAreaHighlight, onShowGridCellHighlight, - onShowGridLineNamesHighlight, onToggleGridHighlighter, onToggleShowGridAreas, onToggleShowGridLineNumbers, @@ -76,7 +75,6 @@ class LayoutView { onShowBoxModelHighlighterForNode, onShowGridAreaHighlight, onShowGridCellHighlight, - onShowGridLineNamesHighlight, onToggleFlexboxHighlighter, onToggleGeometryEditor, onToggleGridHighlighter,