Bug 1562412 - add shippable-l10n-notarization-poller kind r=Callek

Differential Revision: https://phabricator.services.mozilla.com/D57740

--HG--
extra : moz-landing-system : lando

taskcluster/ci/shippable-l10n-notarization-poller/kind.yml

@@ -0,0 +1,19 @@
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this
+# file, You can obtain one at http://mozilla.org/MPL/2.0/.
+---
+loader: taskgraph.loader.single_dep:loader
+
+transforms:
+    - taskgraph.transforms.mac_notarization_poller:transforms
+    - taskgraph.transforms.task:transforms
+
+kind-dependencies:
+    - shippable-l10n-notarization-part-1
+
+job-template:
+    description-suffix: 'Mac Notarization Poller'
+    worker:
+        implementation: notarization-poller
+    attributes:
+        shipping_phase: promote

taskcluster/docs/kinds.rst

@@ -88,6 +88,11 @@ shippable-l10n-notarization-part-1
 
 We switched to a 3-part mac notarization workflow in bug 1562412. This is the first task, which signs the files and submits them for notarization.
 
+shippable-l10n-notarization-poller
+----------------------------------
+
+We switched to a 3-part mac notarization workflow in bug 1562412. This is the second task, which polls Apple for notarization status. Because this is run in a separate, special notarization poller pool, we free up the mac notarization pool for actual signing work.
+
 source-test
 -----------
 

taskcluster/taskgraph/transforms/mac_notarization_poller.py

@@ -10,6 +10,7 @@ from __future__ import absolute_import, print_function, unicode_literals
 from taskgraph.transforms.base import TransformSequence
 from taskgraph.util.attributes import copy_attributes_from_dependent_job
 from taskgraph.util.taskcluster import get_artifact_url
+from taskgraph.util.treeherder import add_suffix, join_symbol
 
 
 transforms = TransformSequence()
@@ -37,17 +38,14 @@ def make_task_description(config, jobs):
             dep_treeherder = dep_job.task.get('extra', {}).get('treeherder', {})
             treeherder.setdefault('tier', dep_treeherder.get('tier', 1))
             treeherder.setdefault('symbol', _generate_treeherder_symbol(
-                dep_treeherder.get('symbol')
+                dep_treeherder.get('groupSymbol', '?'), dep_treeherder.get('symbol')
             ))
-            if dep_treeherder.get('groupSymbol'):
-                treeherder.setdefault('groupSymbol', dep_treeherder['groupSymbol'])
             treeherder.setdefault('kind', 'build')
 
         label = dep_job.label.replace('part-1', 'poller')
         description = (
-            "Initial Signing for locale '{locale}' for build '"
+            "Mac Notarization Poller for build '"
             "{build_platform}/{build_type}'".format(
-                locale=attributes.get('locale', 'en-US'),
                 build_platform=build_platform,
                 build_type=attributes.get('build_type')
             )
@@ -90,6 +88,5 @@ def make_task_description(config, jobs):
         yield task
 
 
-def _generate_treeherder_symbol(build_symbol):
-    symbol = build_symbol + '-poll'
-    return symbol
+def _generate_treeherder_symbol(group_symbol, build_symbol):
+    return join_symbol(group_symbol, add_suffix(build_symbol, '-poll'))