Bug 1267503 - Show the font-inspector in sidebar menu if enabled, r=jdescottes

devtools/client/framework/sidebar.js

@@ -144,8 +144,9 @@ ToolSidebar.prototype = {
     // Add menuitems to the alltabs menu if there are already tabs in the
     // sidebar
     for (let [id, tab] of this._tabs) {
-      if (!tab.hidden) {
-        this._addItemToAllTabsMenu(id, tab, tab.hasAttribute("selected"));
+      let item = this._addItemToAllTabsMenu(id, tab, tab.hasAttribute("selected"));
+      if (tab.hidden) {
+        item.hidden = true;
       }
     }
   },

devtools/client/inspector/inspector-panel.js

@@ -410,7 +410,7 @@ InspectorPanel.prototype = {
     if (Services.prefs.getBoolPref("devtools.fontinspector.enabled") &&
         this.canGetUsedFontFaces) {
       this.fontInspector = new FontInspector(this, this.panelWin);
-      this.panelDoc.getElementById("sidebar-tab-fontinspector").hidden = false;
+      this.sidebar.toggleTab(true, "fontinspector");
     }
 
     this.layoutview = new LayoutView(this, this.panelWin);