Backed out 3 changesets (bug 1446157) for browser chrome failures at browser/base/content/test/static/browser_all_files_referenced.js on a CLOSED TREE

Backed out changeset 2491f8caeffa (bug 1446157)
Backed out changeset be65061c2d72 (bug 1446157)
Backed out changeset de560a993de1 (bug 1446157)

browser/base/content/sanitizeDialog.css

@@ -2,6 +2,19 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
+/* Places tree */
+
+#placesTreechildren {
+  -moz-user-focus: normal;
+}
+
+#placesTreechildren::-moz-tree-cell(grippyRow),
+#placesTreechildren::-moz-tree-cell-text(grippyRow),
+#placesTreechildren::-moz-tree-image(grippyRow) {
+  cursor: grab;
+}
+
+
 /* Sanitize everything warnings */
 
 #sanitizeEverythingWarning,

browser/themes/linux/sanitizeDialog.css

@@ -20,6 +20,17 @@
 }
 
 
+/* Places tree */
+#placesTreechildren::-moz-tree-row(selected),
+#placesTreechildren::-moz-tree-row(grippyRow) {
+  background: #999;
+}
+
+#placesTreechildren::-moz-tree-cell-text(selected) {
+  color: #111;
+}
+
+
 /* Sanitize everything warning box */
 #sanitizeEverythingWarningBox {
   background-color: Window;

browser/themes/osx/sanitizeDialog.css

@@ -16,6 +16,17 @@
 }
 
 
+/* Places tree */
+#placesTreechildren::-moz-tree-row(selected),
+#placesTreechildren::-moz-tree-row(grippyRow) {
+  background: #999;
+}
+
+#placesTreechildren::-moz-tree-cell-text(selected) {
+  color: #111;
+}
+
+
 /* Sanitize everything warning box */
 #sanitizeEverythingWarningBox {
   background-color: Window;

browser/themes/windows/sanitizeDialog.css

@@ -20,6 +20,17 @@
 }
 
 
+/* Places tree */
+#placesTreechildren::-moz-tree-row(selected),
+#placesTreechildren::-moz-tree-row(grippyRow) {
+  background: #999;
+}
+
+#placesTreechildren::-moz-tree-cell-text(selected) {
+  color: #111;
+}
+
+
 /* Sanitize everything warning box */
 #sanitizeEverythingWarningBox {
   background-color: Window;

layout/tools/layout-debug/ui/content/layoutdebug.xul

@@ -49,7 +49,7 @@
   <vbox flex="1">
 
     <toolbox>
-      <menubar id="main-menubar">
+      <menubar id="main-menubar" grippyhidden="true">
         <menu id="menu_file" label="File" accesskey="F">
           <menupopup id="menu_FilePopup">
             <menuitem id="menu_open" label="&ldb.Open.label;" accesskey="&ldb.Open.accesskey;" key="openFileKb" oncommand="openFile()"/>
@@ -92,7 +92,7 @@
         <menu id="menu_Help"/>
       </menubar>
 
-      <toolbar>
+      <toolbar grippyhidden="true">
         <toolbarbutton id="back-button" class="toolbarbutton-1"
                        label="&ldb.BackButton.label;"
                        oncommand="gBrowser.goBack();" />

layout/xul/nsSplitterFrame.cpp

@@ -249,7 +249,15 @@ nsSplitterFrame::AttributeChanged(int32_t aNameSpaceID,
 {
   nsresult rv = nsBoxFrame::AttributeChanged(aNameSpaceID, aAttribute,
                                              aModType);
-  if (aAttribute == nsGkAtoms::state) {
+  // if the alignment changed. Let the grippy know
+  if (aAttribute == nsGkAtoms::align) {
+    // tell the slider its attribute changed so it can
+    // update itself
+    nsIFrame* grippy = nullptr;
+    nsScrollbarButtonFrame::GetChildWithTag(nsGkAtoms::grippy, this, grippy);
+    if (grippy)
+      grippy->AttributeChanged(aNameSpaceID, aAttribute, aModType);
+  } else if (aAttribute == nsGkAtoms::state) {
     mInner->UpdateState();
   }
 

toolkit/content/jar.mn

@@ -94,6 +94,7 @@ toolkit.jar:
    content/global/bindings/scrollbar.xml       (widgets/scrollbar.xml)
    content/global/bindings/scrollbox.xml       (widgets/scrollbox.xml)
    content/global/bindings/spinner.js          (widgets/spinner.js)
+   content/global/bindings/splitter.xml        (widgets/splitter.xml)
    content/global/bindings/stringbundle.xml    (widgets/stringbundle.xml)
 *  content/global/bindings/tabbox.xml          (widgets/tabbox.xml)
    content/global/bindings/text.xml            (widgets/text.xml)

toolkit/content/widgets/splitter.xml

@@ -0,0 +1,28 @@
+<?xml version="1.0"?>
+<!-- This Source Code Form is subject to the terms of the Mozilla Public
+   - License, v. 2.0. If a copy of the MPL was not distributed with this
+   - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
+
+
+<bindings id="splitterBindings"
+   xmlns="http://www.mozilla.org/xbl"
+   xmlns:xul="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul">
+
+  <binding id="grippy" extends="xul:button">
+    <handlers>
+      <handler event="command">
+        <![CDATA[
+          var splitter = this.parentNode;
+          if (splitter) {
+            var state = splitter.getAttribute("state");
+            if (state == "collapsed")
+              splitter.setAttribute("state", "open");
+            else
+              splitter.setAttribute("state", "collapsed");
+          }
+        ]]>
+      </handler>
+    </handlers>
+  </binding>
+
+</bindings>

toolkit/content/xul.css

@@ -845,6 +845,10 @@ dropmarker {
 
 /********** splitter **********/
 
+grippy {
+  -moz-binding: url("chrome://global/content/bindings/splitter.xml#grippy");
+}
+
 .tree-splitter {
   width: 0px;
   max-width: 0px;

toolkit/themes/linux/global/splitter.css

@@ -50,3 +50,16 @@ splitter[orient="vertical"][state="collapsed"][substate="after"] {
 splitter[disabled="true"] {
   cursor: default !important;
 }
+
+/* ::::: splitter grippy ::::: */
+
+grippy {
+  cursor: pointer;
+  min-width: 4px;
+  min-height: 115px;
+}
+
+splitter[orient="vertical"] > grippy {
+  min-width: 115px;
+  min-height: 4px;
+}

toolkit/themes/osx/global/jar.mn

@@ -84,6 +84,10 @@ toolkit.jar:
 * skin/classic/global/in-content/common.css                          (in-content/common.css)
 * skin/classic/global/in-content/info-pages.css                      (in-content/info-pages.css)
   skin/classic/global/splitter/dimple.png                            (splitter/dimple.png)
+  skin/classic/global/splitter/grip-bottom.gif                       (splitter/grip-bottom.gif)
+  skin/classic/global/splitter/grip-top.gif                          (splitter/grip-top.gif)
+  skin/classic/global/splitter/grip-left.gif                         (splitter/grip-left.gif)
+  skin/classic/global/splitter/grip-right.gif                        (splitter/grip-right.gif)
   skin/classic/global/toolbar/spring.png                             (toolbar/spring.png)
   skin/classic/global/toolbar/toolbar-separator.png                  (toolbar/toolbar-separator.png)
   skin/classic/global/tree/arrow-disclosure.svg                      (tree/arrow-disclosure.svg)

toolkit/themes/osx/global/splitter.css

@@ -12,7 +12,7 @@ splitter {
   cursor: ew-resize;
   min-width: 9px;
   min-height: 9px;
-  background: url("chrome://global/skin/splitter/dimple.png") transparent no-repeat center;
+  background: url("chrome://global/skin/splitter/dimple.png") transparent no-repeat center;  
 }
 
 splitter[state="collapsed"][collapse="before"],
@@ -39,7 +39,7 @@ splitter[orient="vertical"] {
   cursor: ns-resize;
   min-width: 0px;
   min-height: 9px;
-  min-width: 9px;
+  min-width: 9px;  
   background: url("chrome://global/skin/splitter/dimple.png") transparent no-repeat center;
 }
 
@@ -56,3 +56,69 @@ splitter[orient="vertical"][state="collapsed"][substate="after"] {
 splitter[disabled="true"] {
   cursor: default !important;
 }
+
+/* ::::: splitter grippy ::::: */
+  
+grippy {
+  cursor: pointer;
+  margin: 0px 1px;
+  min-width: 4px;
+  min-height: 115px;
+  background-color: transparent;
+  background-repeat: no-repeat;
+}
+
+grippy:hover {
+  background-color: ThreeDHighlight;
+}
+
+splitter[orient="vertical"] > grippy {
+  margin: 1px 0px;
+  min-width: 115px;
+  min-height: 4px;
+}
+
+/* ..... normal state ..... */
+
+/* vertical grippies */
+splitter[collapse="before"] > grippy,
+splitter[collapse="after"] > grippy:-moz-locale-dir(rtl) {
+  background-image: url("chrome://global/skin/splitter/grip-left.gif");
+}
+
+splitter[collapse="after"] > grippy,
+splitter[collapse="before"] > grippy:-moz-locale-dir(rtl) {
+  background-image: url("chrome://global/skin/splitter/grip-right.gif");
+}
+
+/* horizontal grippies */
+splitter[collapse="before"][orient="vertical"] > grippy {
+  background-image: url("chrome://global/skin/splitter/grip-top.gif");
+}
+
+splitter[collapse="after"][orient="vertical"] > grippy {
+  background-image: url("chrome://global/skin/splitter/grip-bottom.gif");
+}
+
+/* ..... collapsed state ..... */
+
+/* vertical grippies */
+splitter[collapse="before"][state="collapsed"] > grippy,
+splitter[collapse="after"][state="collapsed"] > grippy:-moz-locale-dir(rtl) {
+  background-image: url("chrome://global/skin/splitter/grip-right.gif");
+}
+
+splitter[collapse="after"][state="collapsed"] > grippy,
+splitter[collapse="before"][state="collapsed"] > grippy:-moz-locale-dir(rtl) {
+  background-image: url("chrome://global/skin/splitter/grip-left.gif");
+}
+
+/* horizontal grippies */
+splitter[collapse="before"][state="collapsed"][orient="vertical"] > grippy {
+  background-image: url("chrome://global/skin/splitter/grip-bottom.gif");
+}
+
+splitter[collapse="after"][state="collapsed"][orient="vertical"] > grippy {
+  background-image: url("chrome://global/skin/splitter/grip-top.gif");
+}
+

toolkit/themes/shared/non-mac.jar.inc.mn

@@ -33,6 +33,10 @@
   skin/classic/global/icons/tabprompts-bgtexture.png       (../../windows/global/icons/tabprompts-bgtexture.png)
   skin/classic/global/icons/warning-16.png                 (../../windows/global/icons/warning-16.png)
   skin/classic/global/icons/warning-64.png                 (../../windows/global/icons/warning-64.png)
+  skin/classic/global/splitter/grip-bottom.gif             (../../windows/global/splitter/grip-bottom.gif)
+  skin/classic/global/splitter/grip-top.gif                (../../windows/global/splitter/grip-top.gif)
+  skin/classic/global/splitter/grip-left.gif               (../../windows/global/splitter/grip-left.gif)
+  skin/classic/global/splitter/grip-right.gif              (../../windows/global/splitter/grip-right.gif)
   skin/classic/global/tree/columnpicker.gif                (../../windows/global/tree/columnpicker.gif)
   skin/classic/global/tree/sort-asc.png                    (../../windows/global/tree/sort-asc.png)
   skin/classic/global/tree/sort-dsc.png                    (../../windows/global/tree/sort-dsc.png)

toolkit/themes/windows/global/splitter.css

@@ -63,3 +63,73 @@ splitter[orient="vertical"][state="collapsed"][substate="after"] {
 splitter[disabled="true"] {
   cursor: default !important;
 }
+
+/* ::::: splitter grippy ::::: */
+
+grippy {
+  cursor: pointer;
+  border-top: 1px solid ThreeDShadow;
+  border-bottom: 1px solid ThreeDShadow;
+  min-width: 4px;
+  min-height: 115px;
+  background-color: transparent;
+  background-repeat: no-repeat;
+}
+
+grippy:hover {
+  background-color: ThreeDHighlight;
+}
+
+splitter[orient="vertical"] > grippy {
+  border-top: none;
+  border-right: 1px solid ThreeDShadow;
+  border-bottom: none;
+  border-left: 1px solid ThreeDShadow;;
+  min-width: 115px;
+  min-height: 4px;
+}
+
+/* ..... normal state ..... */
+
+/* vertical grippies */
+splitter[collapse="before"] > grippy,
+splitter[collapse="after"] > grippy:-moz-locale-dir(rtl) {
+  background-image: url("chrome://global/skin/splitter/grip-left.gif");
+}
+
+splitter[collapse="after"] > grippy,
+splitter[collapse="before"] > grippy:-moz-locale-dir(rtl) {
+  background-image: url("chrome://global/skin/splitter/grip-right.gif");
+}
+
+/* horizontal grippies */
+splitter[collapse="before"][orient="vertical"] > grippy {
+  background-image: url("chrome://global/skin/splitter/grip-top.gif");
+}
+
+splitter[collapse="after"][orient="vertical"] > grippy {
+  background-image: url("chrome://global/skin/splitter/grip-bottom.gif");
+}
+
+/* ..... collapsed state ..... */
+
+/* vertical grippies */
+splitter[collapse="before"][state="collapsed"] > grippy,
+splitter[collapse="after"][state="collapsed"] > grippy:-moz-locale-dir(rtl) {
+  background-image: url("chrome://global/skin/splitter/grip-right.gif");
+}
+
+splitter[collapse="after"][state="collapsed"] > grippy,
+splitter[collapse="before"][state="collapsed"] > grippy:-moz-locale-dir(rtl) {
+  background-image: url("chrome://global/skin/splitter/grip-left.gif");
+}
+
+/* horizontal grippies */
+splitter[collapse="before"][state="collapsed"][orient="vertical"] > grippy {
+  background-image: url("chrome://global/skin/splitter/grip-bottom.gif");
+}
+
+splitter[collapse="after"][state="collapsed"][orient="vertical"] > grippy {
+  background-image: url("chrome://global/skin/splitter/grip-top.gif");
+}
+

xpcom/ds/nsGkAtomList.h

@@ -506,6 +506,7 @@ GK_ATOM(graphicsDocument, "graphics-document")
 GK_ATOM(graphicsObject, "graphics-object")
 GK_ATOM(graphicsSymbol, "graphics-symbol")
 GK_ATOM(grid, "grid")
+GK_ATOM(grippy, "grippy")
 GK_ATOM(group, "group")
 GK_ATOM(groupbox, "groupbox")
 GK_ATOM(groupingSeparator, "grouping-separator")