From 641e43da0be9d8736184f918de15319170e32bc0 Mon Sep 17 00:00:00 2001 From: Jan Henning Date: Mon, 31 Jul 2017 22:45:54 +0200 Subject: [PATCH] Bug 1266683 - Part 3 - Update notifyIMEContext JNI bindings to include private mode info. r=jchen MozReview-Commit-ID: Gl2iRWxo9lE --HG-- extra : rebase_source : 4b0aad157af22dcb96aeb68b199bfa9404902dea --- .../main/java/org/mozilla/gecko/GeckoEditableChild.java | 6 ++++-- widget/android/GeckoEditableSupport.cpp | 3 ++- widget/android/GeneratedJNIWrappers.cpp | 4 ++-- widget/android/GeneratedJNIWrappers.h | 7 ++++--- 4 files changed, 12 insertions(+), 8 deletions(-) diff --git a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditableChild.java b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditableChild.java index bae6ce4c35cb..834f2830466f 100644 --- a/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditableChild.java +++ b/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoEditableChild.java @@ -158,12 +158,14 @@ final class GeckoEditableChild extends JNIObject implements IGeckoEditableChild @WrapForJNI(calledFrom = "gecko") private void notifyIMEContext(final int state, final String typeHint, - final String modeHint, final String actionHint) { + final String modeHint, final String actionHint, + final boolean inPrivateBrowsing) { if (DEBUG) { ThreadUtils.assertOnGeckoThread(); Log.d(LOGTAG, "notifyIMEContext(" + GeckoEditable.getConstantName( GeckoEditableListener.class, "IME_STATE_", state) + ", \"" + - typeHint + "\", \"" + modeHint + "\", \"" + actionHint + "\")"); + typeHint + "\", \"" + modeHint + "\", \"" + actionHint + "\", " + + "inPrivateBrowsing=" + inPrivateBrowsing + ")"); } try { diff --git a/widget/android/GeckoEditableSupport.cpp b/widget/android/GeckoEditableSupport.cpp index cf8ff022397a..34a8a94a0c04 100644 --- a/widget/android/GeckoEditableSupport.cpp +++ b/widget/android/GeckoEditableSupport.cpp @@ -1197,7 +1197,8 @@ GeckoEditableSupport::SetInputContext(const InputContext& aContext, mEditable->NotifyIMEContext(mInputContext.mIMEState.mEnabled, mInputContext.mHTMLInputType, mInputContext.mHTMLInputInputmode, - mInputContext.mActionHint); + mInputContext.mActionHint, + mInputContext.mInPrivateBrowsing); }); } diff --git a/widget/android/GeneratedJNIWrappers.cpp b/widget/android/GeneratedJNIWrappers.cpp index 7918fd1684ae..11bae4ddfab9 100644 --- a/widget/android/GeneratedJNIWrappers.cpp +++ b/widget/android/GeneratedJNIWrappers.cpp @@ -640,9 +640,9 @@ auto GeckoEditableChild::NotifyIME(int32_t a0) const -> void constexpr char GeckoEditableChild::NotifyIMEContext_t::name[]; constexpr char GeckoEditableChild::NotifyIMEContext_t::signature[]; -auto GeckoEditableChild::NotifyIMEContext(int32_t a0, mozilla::jni::String::Param a1, mozilla::jni::String::Param a2, mozilla::jni::String::Param a3) const -> void +auto GeckoEditableChild::NotifyIMEContext(int32_t a0, mozilla::jni::String::Param a1, mozilla::jni::String::Param a2, mozilla::jni::String::Param a3, bool a4) const -> void { - return mozilla::jni::Method::Call(GeckoEditableChild::mCtx, nullptr, a0, a1, a2, a3); + return mozilla::jni::Method::Call(GeckoEditableChild::mCtx, nullptr, a0, a1, a2, a3, a4); } constexpr char GeckoEditableChild::OnDefaultKeyEvent_t::name[]; diff --git a/widget/android/GeneratedJNIWrappers.h b/widget/android/GeneratedJNIWrappers.h index ac393f77b198..a8178ba88d42 100644 --- a/widget/android/GeneratedJNIWrappers.h +++ b/widget/android/GeneratedJNIWrappers.h @@ -1831,10 +1831,11 @@ public: int32_t, mozilla::jni::String::Param, mozilla::jni::String::Param, - mozilla::jni::String::Param> Args; + mozilla::jni::String::Param, + bool> Args; static constexpr char name[] = "notifyIMEContext"; static constexpr char signature[] = - "(ILjava/lang/String;Ljava/lang/String;Ljava/lang/String;)V"; + "(ILjava/lang/String;Ljava/lang/String;Ljava/lang/String;Z)V"; static const bool isStatic = false; static const mozilla::jni::ExceptionMode exceptionMode = mozilla::jni::ExceptionMode::ABORT; @@ -1844,7 +1845,7 @@ public: mozilla::jni::DispatchTarget::CURRENT; }; - auto NotifyIMEContext(int32_t, mozilla::jni::String::Param, mozilla::jni::String::Param, mozilla::jni::String::Param) const -> void; + auto NotifyIMEContext(int32_t, mozilla::jni::String::Param, mozilla::jni::String::Param, mozilla::jni::String::Param, bool) const -> void; struct OnDefaultKeyEvent_t { typedef GeckoEditableChild Owner;