From 64bff94e92404846f254d0a21b04d2648aa75cf5 Mon Sep 17 00:00:00 2001 From: Ehsan Akhgari Date: Mon, 1 Sep 2014 18:01:37 -0400 Subject: [PATCH] Bug 1061058 - Fix more bad implicit constructors in docshell/dom/uriloader; r=smaug --HG-- extra : rebase_source : 4dd9d4bab0b552834cd24051d7dc920950a2e8b2 --- docshell/base/nsDefaultURIFixup.h | 2 +- dom/filesystem/FileSystemPermissionRequest.h | 2 +- uriloader/exthandler/mac/nsMIMEInfoMac.h | 4 ++-- uriloader/exthandler/nsMIMEInfoImpl.h | 8 ++++---- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/docshell/base/nsDefaultURIFixup.h b/docshell/base/nsDefaultURIFixup.h index a0ce599d0e9a..ab92e242bcd2 100644 --- a/docshell/base/nsDefaultURIFixup.h +++ b/docshell/base/nsDefaultURIFixup.h @@ -45,7 +45,7 @@ public: NS_DECL_ISUPPORTS NS_DECL_NSIURIFIXUPINFO - nsDefaultURIFixupInfo(const nsACString& aOriginalInput); + explicit nsDefaultURIFixupInfo(const nsACString& aOriginalInput); friend class nsDefaultURIFixup; diff --git a/dom/filesystem/FileSystemPermissionRequest.h b/dom/filesystem/FileSystemPermissionRequest.h index e349c792c379..632f295fcbba 100644 --- a/dom/filesystem/FileSystemPermissionRequest.h +++ b/dom/filesystem/FileSystemPermissionRequest.h @@ -32,7 +32,7 @@ public: NS_DECL_NSICONTENTPERMISSIONREQUEST NS_DECL_NSIRUNNABLE private: - FileSystemPermissionRequest(FileSystemTaskBase* aTask); + explicit FileSystemPermissionRequest(FileSystemTaskBase* aTask); virtual ~FileSystemPermissionRequest(); diff --git a/uriloader/exthandler/mac/nsMIMEInfoMac.h b/uriloader/exthandler/mac/nsMIMEInfoMac.h index 884e32b596fd..247610e42e80 100644 --- a/uriloader/exthandler/mac/nsMIMEInfoMac.h +++ b/uriloader/exthandler/mac/nsMIMEInfoMac.h @@ -9,8 +9,8 @@ class nsMIMEInfoMac : public nsMIMEInfoImpl { public: - nsMIMEInfoMac(const char* aMIMEType = "") : nsMIMEInfoImpl(aMIMEType) {} - nsMIMEInfoMac(const nsACString& aMIMEType) : nsMIMEInfoImpl(aMIMEType) {} + explicit nsMIMEInfoMac(const char* aMIMEType = "") : nsMIMEInfoImpl(aMIMEType) {} + explicit nsMIMEInfoMac(const nsACString& aMIMEType) : nsMIMEInfoImpl(aMIMEType) {} nsMIMEInfoMac(const nsACString& aType, HandlerClass aClass) : nsMIMEInfoImpl(aType, aClass) {} diff --git a/uriloader/exthandler/nsMIMEInfoImpl.h b/uriloader/exthandler/nsMIMEInfoImpl.h index f26396d119ec..a9e02381cdd4 100644 --- a/uriloader/exthandler/nsMIMEInfoImpl.h +++ b/uriloader/exthandler/nsMIMEInfoImpl.h @@ -67,8 +67,8 @@ class nsMIMEInfoBase : public nsIMIMEInfo { }; // nsMIMEInfoBase methods - nsMIMEInfoBase(const char *aMIMEType = ""); - nsMIMEInfoBase(const nsACString& aMIMEType); + explicit nsMIMEInfoBase(const char *aMIMEType = ""); + explicit nsMIMEInfoBase(const nsACString& aMIMEType); nsMIMEInfoBase(const nsACString& aType, HandlerClass aClass); void SetMIMEType(const nsACString & aMIMEType) { mSchemeOrType = aMIMEType; } @@ -159,8 +159,8 @@ class nsMIMEInfoBase : public nsIMIMEInfo { */ class nsMIMEInfoImpl : public nsMIMEInfoBase { public: - nsMIMEInfoImpl(const char *aMIMEType = "") : nsMIMEInfoBase(aMIMEType) {} - nsMIMEInfoImpl(const nsACString& aMIMEType) : nsMIMEInfoBase(aMIMEType) {} + explicit nsMIMEInfoImpl(const char *aMIMEType = "") : nsMIMEInfoBase(aMIMEType) {} + explicit nsMIMEInfoImpl(const nsACString& aMIMEType) : nsMIMEInfoBase(aMIMEType) {} nsMIMEInfoImpl(const nsACString& aType, HandlerClass aClass) : nsMIMEInfoBase(aType, aClass) {} virtual ~nsMIMEInfoImpl() {}