Bug 1680277 - 3/3: Use AXTextArea for multiline and aria text boxes. r=morgan

By spec, it would need to be an area for aria-multiline=true and a field for aria-multiline=false. Chrome seems to assign all aria text boxes to areas. For some reason this allows VO to recognize links when editing. Webkit doesn't need this, for some reason and can get links announces in AXTextField as well.

Depends on D99312

Differential Revision: https://phabricator.services.mozilla.com/D99313

accessible/mac/mozAccessible.h

@@ -111,6 +111,9 @@ inline mozAccessible* GetNativeFromGeckoAccessible(
 // Handle a role change
 - (void)handleRoleChanged:(mozilla::a11y::role)newRole;
 
+// Get ARIA role
+- (nsStaticAtom*)ARIARole;
+
 #pragma mark - mozAccessible protocol / widget
 
 // override

accessible/mac/mozAccessible.mm

@@ -41,8 +41,6 @@ using namespace mozilla::a11y;
 @interface mozAccessible ()
 - (BOOL)providesLabelNotTitle;
 
-- (nsStaticAtom*)ARIARole;
-
 - (void)maybePostLiveRegionChanged;
 @end
 

accessible/mac/mozTextAccessible.h

@@ -24,6 +24,9 @@
 // override
 - (NSNumber*)moxInsertionPointLineNumber;
 
+// override
+- (NSString*)moxRole;
+
 // override
 - (NSString*)moxSubrole;
 

accessible/mac/mozTextAccessible.mm

@@ -134,6 +134,15 @@ inline NSString* ToNSString(id aValue) {
   return (lineNumber >= 0) ? [NSNumber numberWithInt:lineNumber] : nil;
 }
 
+- (NSString*)moxRole {
+  if ([self ARIARole] == nsGkAtoms::textbox ||
+      [self stateWithMask:states::MULTI_LINE]) {
+    return NSAccessibilityTextAreaRole;
+  }
+
+  return [super moxRole];
+}
+
 - (NSString*)moxSubrole {
   MOZ_ASSERT(!mGeckoAccessible.IsNull());
 

accessible/tests/browser/mac/browser_roles_elements.js

@@ -73,6 +73,12 @@ addAccessibleTask(
   <div id="timer" role="timer"></div>
   <div id="tooltip" role="tooltip"></div>
 
+  <!-- text entries -->
+  <div id="textbox_multiline" role="textbox" aria-multiline="true"></div>
+  <div id="textbox_singleline" role="textbox" aria-multiline="false"></div>
+  <textarea id="textArea"></textarea>
+  <input id="textInput">
+
   <!-- True HTML5 search box -->
   <input type="search" id="htmlSearch" />
 
@@ -175,6 +181,12 @@ addAccessibleTask(
     testRoleAndSubRole(accDoc, "timer", null, "AXApplicationTimer");
     testRoleAndSubRole(accDoc, "tooltip", "AXGroup", "AXUserInterfaceTooltip");
 
+    // Text boxes
+    testRoleAndSubRole(accDoc, "textbox_multiline", "AXTextArea");
+    testRoleAndSubRole(accDoc, "textbox_singleline", "AXTextArea");
+    testRoleAndSubRole(accDoc, "textArea", "AXTextArea");
+    testRoleAndSubRole(accDoc, "textInput", "AXTextField");
+
     // True HTML5 search field
     testRoleAndSubRole(accDoc, "htmlSearch", "AXTextField", "AXSearchField");