Bug 616001 - Sync needs to check moz_places.guid and moz_bookmarks.guid if it exists.

Part 3 - Tests for a v11 places database running in Firefox 3.5/3.6

services/sync/tests/unit/head_appinfo.js.in

@@ -1,3 +1,5 @@
+var gProfD;
+
 // Load httpd from the add-on test harness or from xpcshell and declare Cc, etc.
 // without a var/const so they don't get hoisted and conflict with load_httpd.
 if (this.do_load_httpd_js == null) {
@@ -6,10 +8,15 @@ if (this.do_load_httpd_js == null) {
   Cr = Components.results;
   Cu = Components.utils;
   Cu.import("resource://harness/modules/httpd.js");
+
+  let file = Cc["@mozilla.org/file/directory_service;1"]
+               .getService(Ci.nsIProperties)
+               .get("ProfD", Ci.nsIFile);  
+  gProfD = file.clone();
 }
 else {
   do_load_httpd_js();
-  do_get_profile();
+  gProfD = do_get_profile();
 }
 
 Cu.import("resource://gre/modules/XPCOMUtils.jsm");

services/sync/tests/unit/test_places_guid_downgrade.js

@@ -0,0 +1,174 @@
+Cu.import("resource://services-sync/util.js");
+Cu.import("resource://services-sync/engines.js");
+Cu.import("resource://services-sync/engines/history.js");
+Cu.import("resource://services-sync/engines/bookmarks.js");
+
+const kDBName = "places.sqlite";
+const storageSvc = Cc["@mozilla.org/storage/service;1"]
+                     .getService(Ci.mozIStorageService);
+
+const fxuri = Utils.makeURI("http://getfirefox.com/");
+const tburi = Utils.makeURI("http://getthunderbird.com/");
+
+function setPlacesDatabase(aFileName) {
+  removePlacesDatabase();
+  _("Copying over places.sqlite.");
+  let file = do_get_file(aFileName);
+  file.copyTo(gProfD, kDBName);
+}
+
+function removePlacesDatabase() {
+  _("Removing places.sqlite.");
+  let file = gProfD.clone();
+  file.append(kDBName);
+  try {
+    file.remove(false);
+  } catch (ex) {
+    // Windows is awesome. NOT.
+  }
+}
+
+Svc.Obs.add("places-shutdown", function () {
+  do_timeout(0, removePlacesDatabase);
+});
+
+
+// Verify initial database state. Function borrowed from places tests.
+function test_initial_state() {
+  // Mostly sanity checks our starting DB to make sure it's setup as we expect
+  // it to be.
+  let dbFile = gProfD.clone();
+  dbFile.append(kDBName);
+  let db = storageSvc.openUnsharedDatabase(dbFile);
+
+  let stmt = db.createStatement("PRAGMA journal_mode");
+  do_check_true(stmt.executeStep());
+  // WAL journal mode should have been unset this database when it was migrated
+  // down to v10.
+  do_check_neq(stmt.getString(0).toLowerCase(), "wal");
+  stmt.finalize();
+
+  do_check_true(db.indexExists("moz_bookmarks_guid_uniqueindex"));
+  do_check_true(db.indexExists("moz_places_guid_uniqueindex"));
+
+  // There should be a non-zero amount of bookmarks without a guid.
+  stmt = db.createStatement(
+    "SELECT COUNT(1) "
+  + "FROM moz_bookmarks "
+  + "WHERE guid IS NULL "
+  );
+  do_check_true(stmt.executeStep());
+  do_check_neq(stmt.getInt32(0), 0);
+  stmt.finalize();
+
+  // There should be a non-zero amount of places without a guid.
+  stmt = db.createStatement(
+    "SELECT COUNT(1) "
+  + "FROM moz_places "
+  + "WHERE guid IS NULL "
+  );
+  do_check_true(stmt.executeStep());
+  do_check_neq(stmt.getInt32(0), 0);
+  stmt.finalize();
+
+  // Check our schema version to make sure it is actually at 10.
+  do_check_eq(db.schemaVersion, 10);
+
+  db.close();
+}
+
+function test_history_guids() {
+  let engine = new HistoryEngine();
+  let store = engine._store;
+
+  Svc.History.addPageWithDetails(fxuri, "Get Firefox!", Date.now() * 1000);
+  Svc.History.addPageWithDetails(tburi, "Get Thunderbird!", Date.now() * 1000);
+
+  // Hack: flush the places db by adding a random bookmark.
+  let uri = Utils.makeURI("http://mozilla.com/");
+  let fxid = Svc.Bookmark.insertBookmark(
+    Svc.Bookmark.toolbarFolder, uri, Svc.Bookmark.DEFAULT_INDEX, "Mozilla");
+
+  let fxguid = store.GUIDForUri(fxuri, true);
+  let tbguid = store.GUIDForUri(tburi, true);
+  dump("fxguid: " + fxguid + "\n");
+  dump("tbguid: " + tbguid + "\n");
+
+  _("History: Verify GUIDs are added to the guid column.");
+  let stmt = Utils.createStatement(
+    Svc.History.DBConnection,
+    "SELECT id FROM moz_places WHERE guid = :guid");
+
+  stmt.params.guid = fxguid;
+  let result = Utils.queryAsync(stmt, ["id"]);
+  do_check_eq(result.length, 1);
+
+  stmt.params.guid = tbguid;
+  result = Utils.queryAsync(stmt, ["id"]);
+  do_check_eq(result.length, 1);
+
+  _("History: Verify GUIDs weren't added to annotations.");
+  stmt = Utils.createStatement(
+    Svc.History.DBConnection,
+    "SELECT a.content AS guid FROM moz_annos a WHERE guid = :guid");
+
+  stmt.params.guid = fxguid;
+  result = Utils.queryAsync(stmt, ["guid"]);
+  do_check_eq(result.length, 0);
+
+  stmt.params.guid = tbguid;
+  result = Utils.queryAsync(stmt, ["guid"]);
+  do_check_eq(result.length, 0);
+}
+
+function test_bookmark_guids() {
+  let engine = new BookmarksEngine();
+  let store = engine._store;
+
+  let fxid = Svc.Bookmark.insertBookmark(
+    Svc.Bookmark.toolbarFolder, fxuri, Svc.Bookmark.DEFAULT_INDEX,
+    "Get Firefox!");
+  let tbid = Svc.Bookmark.insertBookmark(
+    Svc.Bookmark.toolbarFolder, tburi, Svc.Bookmark.DEFAULT_INDEX,
+    "Get Thunderbird!");
+
+  let fxguid = store.GUIDForId(fxid);
+  let tbguid = store.GUIDForId(tbid);
+
+  _("Bookmarks: Verify GUIDs are added to the guid column.");
+  let stmt = Utils.createStatement(
+    Svc.History.DBConnection,
+    "SELECT id FROM moz_bookmarks WHERE guid = :guid");
+
+  stmt.params.guid = fxguid;
+  let result = Utils.queryAsync(stmt, ["id"]);
+  do_check_eq(result.length, 1);
+  do_check_eq(result[0].id, fxid);
+
+  stmt.params.guid = tbguid;
+  result = Utils.queryAsync(stmt, ["id"]);
+  do_check_eq(result.length, 1);
+  do_check_eq(result[0].id, tbid);
+
+  _("Bookmarks: Verify GUIDs weren't added to annotations.");
+  stmt = Utils.createStatement(
+    Svc.History.DBConnection,
+    "SELECT a.content AS guid FROM moz_items_annos a WHERE guid = :guid");
+
+  stmt.params.guid = fxguid;
+  result = Utils.queryAsync(stmt, ["guid"]);
+  do_check_eq(result.length, 0);
+
+  stmt.params.guid = tbguid;
+  result = Utils.queryAsync(stmt, ["guid"]);
+  do_check_eq(result.length, 0);
+}
+
+function run_test() {
+  setPlacesDatabase("places_v10_from_v11.sqlite");
+
+  _("Verify initial setup: v11 database is available");
+  test_initial_state();
+  test_history_guids();
+  test_bookmark_guids();
+}