Bug 1598468 - [remote] Temporarily stop emitting the "Target.receivedMessageFromTarget" event. r=remote-protocol-reviewers,ato

This event is currently sent for each and every message,
and as such duplicates every log entry as displayed when
having the Puppeteer debug logs turned on.

Until we can fix it to behave correctly, it should be
disabled.

Differential Revision: https://phabricator.services.mozilla.com/D54273

--HG--
extra : moz-landing-system : lando

remote/Connection.jsm

@@ -102,16 +102,18 @@ class Connection {
     // session. `Target.attachToTarget` creates the secondary session and
     // returns the session ID.
     if (sessionId) {
-      this.sendEvent("Target.receivedMessageFromTarget", {
-        sessionId,
-        // receivedMessageFromTarget is expected to send a raw CDP packet
-        // in the `message` property and it to be already serialized to a
-        // string
-        message: JSON.stringify({
-          id,
-          result,
-        }),
-      });
+      // Temporarily disabled due to spamming of the console (bug 1598468).
+      // Event should only be sent on protocol messages (eg. attachedToTarget)
+      // this.sendEvent("Target.receivedMessageFromTarget", {
+      //   sessionId,
+      //   // receivedMessageFromTarget is expected to send a raw CDP packet
+      //   // in the `message` property and it to be already serialized to a
+      //   // string
+      //   message: JSON.stringify({
+      //     id,
+      //     result,
+      //   }),
+      // });
     }
   }
 
@@ -146,13 +148,15 @@ class Connection {
     // session. `Target.attachToTarget` creates the secondary session and
     // returns the session ID.
     if (sessionId) {
-      this.sendEvent("Target.receivedMessageFromTarget", {
-        sessionId,
-        message: JSON.stringify({
-          method,
-          params,
-        }),
-      });
+      // Temporarily disabled due to spamming of the console (bug 1598468).
+      // Event should only be sent on protocol messages (eg. attachedToTarget)
+      // this.sendEvent("Target.receivedMessageFromTarget", {
+      //   sessionId,
+      //   message: JSON.stringify({
+      //     method,
+      //     params,
+      //   }),
+      // });
     }
   }
 

remote/test/browser/target/browser.ini

@@ -11,5 +11,6 @@ support-files =
 [browser_browserContext.js]
 [browser_closeTarget.js]
 [browser_sendMessageToTarget.js]
+skip-if = true  # bug 1598468 - temporarily stop emitting event due to spamming
 [browser_setDiscoverTargets.js]
 [browser_targetDestroyed.js]