Bug 930380 - Make sure *SOURCES only point to existing files. r=gps

gfx/skia/moz.build

@@ -544,7 +544,7 @@ CPP_SOURCES += [
 
 if not CONFIG['INTEL_ARCHITECTURE'] and CONFIG['CPU_ARCH'] == 'arm' and CONFIG['GNU_CC']:
     SSRCS += [
-        'memset.arm.S',
+        'src/opts/memset.arm.S',
     ]
 
 LIBRARY_NAME = 'skia'

gfx/tests/gtest/moz.build

@@ -27,12 +27,14 @@ GTEST_CPP_SOURCES += [
 # Because of gkmedia on windows we wont find these
 # symbols in xul.dll.
 if CONFIG['MOZ_WIDGET_TOOLKIT'] != 'windows':
-    GTEST_CPP_SOURCES += [
+    GTEST_CPP_SOURCES += [ '%s/gfx/2d/unittest/%s' % (TOPSRCDIR, p) for p in [
         'TestBase.cpp',
-        'TestMoz2D.cpp',
         'TestPoint.cpp',
-        'TestRect.cpp',
         'TestScaling.cpp',
+    ]]
+    GTEST_CPP_SOURCES += [
+        'TestMoz2D.cpp',
+        'TestRect.cpp',
     ]
 
 LIBXUL_LIBRARY = True

ipc/chromium/moz.build

@@ -166,19 +166,19 @@ if os_macosx:
         'src/chrome/common/transport_dib_mac.cc',
     ]
     CMMSRCS += [
-        'base_paths_mac.mm',
-        'chrome_application_mac.mm',
-        'chrome_paths_mac.mm',
-        'file_util_mac.mm',
-        'file_version_info_mac.mm',
-        'mac_util.mm',
-        'mach_ipc_mac.mm',
-        'message_pump_mac.mm',
-        'platform_thread_mac.mm',
-        'process_util_mac.mm',
-        'scoped_nsautorelease_pool.mm',
-        'sys_string_conversions_mac.mm',
-        'worker_pool_mac.mm',
+        'src/base/base_paths_mac.mm',
+        'src/base/chrome_application_mac.mm',
+        'src/base/file_util_mac.mm',
+        'src/base/file_version_info_mac.mm',
+        'src/base/mac_util.mm',
+        'src/base/message_pump_mac.mm',
+        'src/base/platform_thread_mac.mm',
+        'src/base/process_util_mac.mm',
+        'src/base/scoped_nsautorelease_pool.mm',
+        'src/base/sys_string_conversions_mac.mm',
+        'src/base/worker_pool_mac.mm',
+        'src/chrome/common/chrome_paths_mac.mm',
+        'src/chrome/common/mach_ipc_mac.mm',
     ]
 
 if os_linux:

media/libtheora/lib/Makefile.in

@@ -84,6 +84,12 @@ armopts-gnu.S: armopts.s
 %-gnu.$(ASM_SUFFIX): %.s
 	$(PERL) $(srcdir)/arm/arm2gnu.pl < $< > $@
 
+ASFILES += $(addsuffix .$(ASM_SUFFIX), \
+  armbits-gnu \
+  armfrag-gnu \
+  armidct-gnu \
+  armloop-gnu \
+)
 endif
 endif
 

media/libtheora/lib/moz.build

@@ -8,15 +8,6 @@ MODULE = 'theora'
 
 LIBRARY_NAME = 'theora'
 
-if CONFIG['OS_TEST'] == 'arm' and CONFIG['GNU_AS']:
-    asm_suffix = CONFIG['ASM_SUFFIX']
-    ASFILES += [ '%s.%s' % (f, asm_suffix) for f in [
-        'armbits-gnu',
-        'armfrag-gnu',
-        'armidct-gnu',
-        'armloop-gnu',
-    ]]
-
 CSRCS += [
     'apiwrapper.c',
     'bitpack.c',

media/libvpx/moz.build

@@ -33,7 +33,7 @@ EXPORTS.vpx += [
 
 if CONFIG['VPX_NEED_OBJ_INT_EXTRACT']:
     HOST_CSRCS += [
-        'obj_int_extract.c',
+        'build/make/obj_int_extract.c',
     ]
 
 LIBRARY_NAME = 'vpx'

python/mozbuild/mozbuild/frontend/emitter.py

@@ -128,7 +128,9 @@ class TreeMetadataEmitter(LoggingMixin):
             yield XPIDLFile(sandbox, mozpath.join(sandbox['SRCDIR'], idl),
                 xpidl_module)
 
-        for symbol in ('CPP_SOURCES', 'CSRCS'):
+        for symbol in ('CPP_SOURCES', 'CSRCS', 'ASFILES', 'CMMSRCS', 'SSRCS',
+                       'GTEST_CMM_SOURCES', 'GTEST_CPP_SOURCES',
+                       'GTEST_C_SOURCES', 'HOST_CPPSRCS', 'HOST_CSRCS'):
             for src in (sandbox[symbol] or []):
                 if not os.path.exists(os.path.join(sandbox['SRCDIR'], src)):
                     raise SandboxValidationError('Reference to a file that '

python/mozbuild/mozbuild/test/backend/data/variable_passthru/moz.build

@@ -38,7 +38,7 @@ CSRCS += ['bar.c', 'foo.c']
 
 CMMSRCS = ['bar.mm', 'foo.mm']
 
-SSRCS = ['bar.S', 'foo.S']
+SSRCS = ['baz.S', 'foo.S']
 
 FAIL_ON_WARNINGS = True
 LIBXUL_LIBRARY = True

python/mozbuild/mozbuild/test/backend/test_recursivemake.py

@@ -355,7 +355,7 @@ class TestRecursiveMakeBackend(BackendTester):
                 'SIMPLE_PROGRAMS += foo.x',
             ],
             'SSRCS': [
-                'SSRCS += bar.S',
+                'SSRCS += baz.S',
                 'SSRCS += foo.S',
             ],
         }

python/mozbuild/mozbuild/test/frontend/data/variable-passthru/moz.build

@@ -38,7 +38,7 @@ CSRCS += ['fans.c', 'tans.c']
 
 CMMSRCS = ['fans.mm', 'tans.mm']
 
-SSRCS = ['fans.S', 'tans.S']
+SSRCS = ['bans.S', 'fans.S']
 
 FAIL_ON_WARNINGS = True
 LIBXUL_LIBRARY = True

python/mozbuild/mozbuild/test/frontend/test_emitter.py

@@ -162,7 +162,7 @@ class TestEmitterBasic(unittest.TestCase):
             SDK_LIBRARY=['fans.sdk', 'tans.sdk'],
             SHARED_LIBRARY_LIBS=['fans.sll', 'tans.sll'],
             SIMPLE_PROGRAMS=['fans.x', 'tans.x'],
-            SSRCS=['fans.S', 'tans.S'],
+            SSRCS=['bans.S', 'fans.S'],
         )
 
         variables = objs[1].variables

testing/gtest/moz.build

@@ -62,7 +62,7 @@ CPP_SOURCES += [
 LIBRARY_NAME = 'gtest'
 
 GTEST_CPP_SOURCES += [
-    'SanityTest.cpp',
+    'mozilla/SanityTest.cpp',
 ]
 
 LIBXUL_LIBRARY = True

toolkit/crashreporter/google-breakpad/src/common/moz.build

@@ -77,7 +77,7 @@ if CONFIG['OS_ARCH'] == 'Darwin':
 
 if CONFIG['OS_TARGET'] == 'Android':
     SSRCS += [
-        'breakpad_getcontext.S',
+        'android/breakpad_getcontext.S',
     ]
 
 LIBRARY_NAME = 'breakpad_common_s'

uriloader/exthandler/moz.build

@@ -67,9 +67,9 @@ CPP_SOURCES += [
 
 if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'cocoa':
     CMMSRCS += [
-        'nsLocalHandlerAppMac.mm',
-        'nsMIMEInfoMac.mm',
-        'nsOSHelperAppService.mm',
+        'mac/nsLocalHandlerAppMac.mm',
+        'mac/nsMIMEInfoMac.mm',
+        'mac/nsOSHelperAppService.mm',
     ]
 else:
     CPP_SOURCES += [