From 6633529d6397b35f710f85a40af4388ab0611443 Mon Sep 17 00:00:00 2001 From: "ben%bengoodger.com" Date: Thu, 6 Nov 2003 08:43:48 +0000 Subject: [PATCH] Notes --- toolkit/mozapps/installer/windows/wizard/setup/xpi.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/toolkit/mozapps/installer/windows/wizard/setup/xpi.c b/toolkit/mozapps/installer/windows/wizard/setup/xpi.c index 533355269441..4f318a62b666 100644 --- a/toolkit/mozapps/installer/windows/wizard/setup/xpi.c +++ b/toolkit/mozapps/installer/windows/wizard/setup/xpi.c @@ -380,6 +380,13 @@ void cbXPIProgress(const char* msg, PRInt32 val, PRInt32 max) dlgInfo.nFileBars = 0; + // XXXben this is a really nasty hack. We shouldn't be parsing the msg value + // to find out what sort of progress notification this is. Really, the installer + // listener system needs to be rearchitected to send out a message type (int) + // and a message value, and the listeners can synthesize a display message if + // they want to. As it stands, the strings that are used here are NOT localizable + // (hard coded over in mozilla/xpinstall/src), which blows dead goats through + // straws. if ((!strncmp(msg, "Installing: ", 12) || !strncmp(msg, "Replacing: ", 11)) && (max != 0 && val <= max)) {