Bug 1478000 - nICEr and nrappkit should use the same warnings under clang-cl as with clang; r=dmajor

Summary:
This adds a clangcl flag to gyp.mozbuild and then uses that to set the same
warnings flags for clang-cl as for clang.

Reviewers: dmajor

Tags: #secure-revision

Bug #: 1478000

Differential Revision: https://phabricator.services.mozilla.com/D2427

--HG--
extra : rebase_source : 6137d2f59e5504d448d4fb32a7e734756ff76afa

build/gyp.mozbuild

@@ -26,6 +26,7 @@ gyp_vars.update({
     # basic stuff for everything
     'include_internal_video_render': 0,
     'clang': 1 if CONFIG['CC_TYPE'] == 'clang' else 0,
+    'clang_cl': 1 if CONFIG['CC_TYPE'] == 'clang-cl' else 0,
     'clang_use_chrome_plugins': 0,
     'enable_protobuf': 0,
     'include_tests': 0,

media/mtransport/third_party/nICEr/nicer.gyp

@@ -204,8 +204,20 @@
                  ],
               }],
 
+              # Windows, clang-cl build
+              [ 'clang_cl == 1', {
+                'cflags_mozilla': [
+                    '-Wall',
+                    '-Wno-parentheses',
+                    '-Wno-strict-prototypes',
+                    '-Wmissing-prototypes',
+                    '-Wno-format',
+                    '-Wno-format-security',
+                 ],
+              }],
+
               ## Linux/Android
-              [ '(OS == "linux") or (OS=="android")', {
+              [ '(OS == "linux") or (OS == "android")', {
                 'cflags_mozilla': [
                     '-Wall',
                     '-Wno-parentheses',

media/mtransport/third_party/nrappkit/nrappkit.gyp

@@ -201,6 +201,18 @@
                  ],
               }],
 
+              # Windows, clang-cl build
+              [ 'clang_cl == 1', {
+                'cflags_mozilla': [
+                    '-Wall',
+                    '-Wno-parentheses',
+                    '-Wno-strict-prototypes',
+                    '-Wmissing-prototypes',
+                    '-Wno-format',
+                    '-Wno-format-security',
+                 ],
+              }],
+
               ## Linux/Android
               [ '(OS == "linux") or (OS == "android")', {
                  'cflags_mozilla': [