From 67c0e7ceb25cfae2fec7f06efbd46d04a3e0b264 Mon Sep 17 00:00:00 2001 From: David Major Date: Fri, 29 Jun 2018 13:28:09 -0400 Subject: [PATCH] Bug 1471310: Disable the emptiness assertion in ProtectedRegionTree. r=nbp This is causing random failures with clang-cl and per the bug discussion we have better mechanisms to catch leaks. --- js/src/ds/MemoryProtectionExceptionHandler.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/js/src/ds/MemoryProtectionExceptionHandler.cpp b/js/src/ds/MemoryProtectionExceptionHandler.cpp index a46cd204f36f..7a2123f80450 100644 --- a/js/src/ds/MemoryProtectionExceptionHandler.cpp +++ b/js/src/ds/MemoryProtectionExceptionHandler.cpp @@ -78,11 +78,7 @@ class ProtectedRegionTree } ~ProtectedRegionTree() { - // See Bug 1445619: Currently many users of the JS engine are leaking - // the world, unfortunately LifoAlloc owned by JSRuntimes have - // registered memory regions. sProtectedRegionsInit = false; - MOZ_ASSERT_IF(!JSRuntime::hasLiveRuntimes(), tree.empty()); } void insert(uintptr_t addr, size_t size) {