diff --git a/devtools/client/responsive.html/index.js b/devtools/client/responsive.html/index.js index 8c9b7a80fc24..b80f097614af 100644 --- a/devtools/client/responsive.html/index.js +++ b/devtools/client/responsive.html/index.js @@ -136,7 +136,10 @@ window.setViewportSize = (width, height) => { /** * Called by manager.js when tests want to use the viewport's message manager. + * It is packed into an object because this is the format most easily usable + * with ContentTask.spawn(). */ window.getViewportMessageManager = () => { - return document.querySelector("iframe.browser").frameLoader; + let { messageManager } = document.querySelector("iframe.browser").frameLoader; + return { messageManager }; }; diff --git a/devtools/client/responsive.html/test/browser/browser_exit_button.js b/devtools/client/responsive.html/test/browser/browser_exit_button.js index 48b85b4ae09c..81f5aa1148de 100644 --- a/devtools/client/responsive.html/test/browser/browser_exit_button.js +++ b/devtools/client/responsive.html/test/browser/browser_exit_button.js @@ -14,10 +14,9 @@ addRDMTask(TEST_URL, function*({ ui, manager }) { // Wait until the viewport has been added yield waitUntilState(store, state => state.viewports.length == 1); - let browser = toolWindow.document.querySelector(".browser"); let exitButton = toolWindow.document.getElementById("global-exit-button"); - yield waitForFrameLoad(browser, TEST_URL); + yield waitForFrameLoad(ui, TEST_URL); ok(manager.isActiveForTab(ui.tab), "Responsive Design Mode active for the tab"); diff --git a/devtools/client/responsive.html/test/browser/browser_viewport_basics.js b/devtools/client/responsive.html/test/browser/browser_viewport_basics.js index e2ab7c2bd020..236fc069559d 100644 --- a/devtools/client/responsive.html/test/browser/browser_viewport_basics.js +++ b/devtools/client/responsive.html/test/browser/browser_viewport_basics.js @@ -14,16 +14,17 @@ addRDMTask(TEST_URL, function*({ ui }) { yield waitUntilState(store, state => state.viewports.length == 1); // A single viewport of default size appeared - let browser = ui.toolWindow.document.querySelector(".browser"); - is(browser.width, "320", "Viewport has default width"); - is(browser.height, "480", "Viewport has default height"); + let viewport = ui.toolWindow.document.querySelector(".viewport-content"); + + is(ui.toolWindow.getComputedStyle(viewport).getPropertyValue("width"), + "320px", "Viewport has default width"); + is(ui.toolWindow.getComputedStyle(viewport).getPropertyValue("height"), + "480px", "Viewport has default height"); // Browser's location should match original tab - // TODO: For the moment, we have parent process